ale/test/command_callback/test_prospector_command_callback.vader

Before:
  call ale#assert#SetUpLinterTest('python', 'prospector')

After:
  call ale#assert#TearDownLinterTest()

Execute(Setting executable to 'pipenv' appends 'run prospector'):
  let g:ale_python_prospector_executable = 'path/to/pipenv'

  AssertLinter 'path/to/pipenv',
  \ ale#Escape('path/to/pipenv') . ' run prospector'
  \   .  '  --messages-only --absolute-paths --zero-exit --output-format json %s'

Execute(Pipenv is detected when python_prospector_auto_pipenv is set):
  let g:ale_python_prospector_auto_pipenv = 1
  call ale#test#SetFilename('/testplugin/test/python_fixtures/pipenv/whatever.py')

  AssertLinter 'pipenv',
  \ ale#Escape('pipenv') . ' run prospector'
  \   .  '  --messages-only --absolute-paths --zero-exit --output-format json %s'
Allow all Python linter executables to be set to `pipenv`. It appends ` run {linter_name}`, analogously to the Ruby linters when the executable is set to `bundle` 2018-06-05 02:43:02 +00:00			`Before:`
Massively reduce the amount of code needed for linter tests 2018-07-15 17:24:53 +00:00			`call ale#assert#SetUpLinterTest('python', 'prospector')`
Allow all Python linter executables to be set to `pipenv`. It appends ` run {linter_name}`, analogously to the Ruby linters when the executable is set to `bundle` 2018-06-05 02:43:02 +00:00
			`After:`
Massively reduce the amount of code needed for linter tests 2018-07-15 17:24:53 +00:00			`call ale#assert#TearDownLinterTest()`
Allow all Python linter executables to be set to `pipenv`. It appends ` run {linter_name}`, analogously to the Ruby linters when the executable is set to `bundle` 2018-06-05 02:43:02 +00:00
			`Execute(Setting executable to 'pipenv' appends 'run prospector'):`
			`let g:ale_python_prospector_executable = 'path/to/pipenv'`

Massively reduce the amount of code needed for linter tests 2018-07-15 17:24:53 +00:00			`AssertLinter 'path/to/pipenv',`
Allow all Python linter executables to be set to `pipenv`. It appends ` run {linter_name}`, analogously to the Ruby linters when the executable is set to `bundle` 2018-06-05 02:43:02 +00:00			`\ ale#Escape('path/to/pipenv') . ' run prospector'`
Massively reduce the amount of code needed for linter tests 2018-07-15 17:24:53 +00:00			`\ . ' --messages-only --absolute-paths --zero-exit --output-format json %s'`
Add python_[linter]_auto_pipenv options for python linters (fixes #1656) When set to true, and the buffer is currently inside a pipenv, GetExecutable will return "pipenv", which will trigger the existing functionality to append the correct pipenv arguments to run each linter. Defaults to false. I was going to implement ale#python#PipenvPresent by invoking `pipenv --venv` or `pipenv --where`, but it seemed to be abominably slow, even to the point where the test suite wasn't even finishing ("Tried to run tests 3 times"). The diff is: diff --git a/autoload/ale/python.vim b/autoload/ale/python.vim index 7baae079..8c100d41 100644 --- a/autoload/ale/python.vim +++ b/autoload/ale/python.vim @@ -106,5 +106,9 @@ endfunction " Detects whether a pipenv environment is present. function! ale#python#PipenvPresent(buffer) abort - return findfile('Pipfile.lock', expand('#' . a:buffer . ':p:h') . ';') isnot# '' + let l:cd_string = ale#path#BufferCdString(a:buffer) + let l:output = systemlist(l:cd_string . 'pipenv --where')[0] + " `pipenv --where` returns the path to the dir containing the Pipfile + " if in a pipenv, or some error text otherwise. + return strpart(l:output, 0, 18) !=# "No Pipfile present" endfunction Using vim's `findfile` is much faster, behaves correctly in the majority of situations, and also works reliably when the `pipenv` command doesn't exist. 2018-07-12 03:02:23 +00:00
			`Execute(Pipenv is detected when python_prospector_auto_pipenv is set):`
			`let g:ale_python_prospector_auto_pipenv = 1`
			`call ale#test#SetFilename('/testplugin/test/python_fixtures/pipenv/whatever.py')`

			`AssertLinter 'pipenv',`
			`\ ale#Escape('pipenv') . ' run prospector'`
			`\ . ' --messages-only --absolute-paths --zero-exit --output-format json %s'`