2016-10-03 18:55:55 +00:00
|
|
|
" Author: w0rp <devw0rp@gmail.com>
|
|
|
|
" Description: flake8 for python files
|
|
|
|
|
2016-11-14 17:52:31 +00:00
|
|
|
let g:ale_python_flake8_executable =
|
|
|
|
\ get(g:, 'ale_python_flake8_executable', 'flake8')
|
|
|
|
|
2017-04-15 12:35:54 +00:00
|
|
|
" Support an old setting as a fallback.
|
|
|
|
let s:default_options = get(g:, 'ale_python_flake8_args', '')
|
|
|
|
let g:ale_python_flake8_options =
|
|
|
|
\ get(g:, 'ale_python_flake8_options', s:default_options)
|
2016-11-14 17:52:31 +00:00
|
|
|
|
2017-02-06 11:12:21 +00:00
|
|
|
" A map from Python executable paths to semver strings parsed for those
|
|
|
|
" executables, so we don't have to look up the version number constantly.
|
|
|
|
let s:version_cache = {}
|
|
|
|
|
2016-11-14 17:52:31 +00:00
|
|
|
function! ale_linters#python#flake8#GetExecutable(buffer) abort
|
|
|
|
return g:ale_python_flake8_executable
|
|
|
|
endfunction
|
|
|
|
|
2017-02-06 11:12:21 +00:00
|
|
|
function! ale_linters#python#flake8#VersionCheck(buffer) abort
|
|
|
|
let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
|
|
|
|
|
|
|
|
" If we have previously stored the version number in a cache, then
|
|
|
|
" don't look it up again.
|
|
|
|
if has_key(s:version_cache, l:executable)
|
|
|
|
" Returning an empty string skips this command.
|
|
|
|
return ''
|
|
|
|
endif
|
|
|
|
|
|
|
|
return ale_linters#python#flake8#GetExecutable(a:buffer) . ' --version'
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
" Get the flake8 version from the output, or the cache.
|
|
|
|
function! s:GetVersion(buffer, version_output) abort
|
|
|
|
let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
|
|
|
|
let l:version = []
|
|
|
|
|
|
|
|
" Get the version from the cache.
|
|
|
|
if has_key(s:version_cache, l:executable)
|
|
|
|
return s:version_cache[l:executable]
|
|
|
|
endif
|
|
|
|
|
|
|
|
if !empty(a:version_output)
|
|
|
|
" Parse the version string, and store it in the cache.
|
|
|
|
let l:version = ale#semver#Parse(a:version_output[0])
|
|
|
|
let s:version_cache[l:executable] = l:version
|
|
|
|
endif
|
|
|
|
|
|
|
|
return l:version
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
" flake8 versions 3 and up support the --stdin-display-name argument.
|
|
|
|
function! s:SupportsDisplayName(version) abort
|
|
|
|
return !empty(a:version) && ale#semver#GreaterOrEqual(a:version, [3, 0, 0])
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#python#flake8#GetCommand(buffer, version_output) abort
|
|
|
|
let l:version = s:GetVersion(a:buffer, a:version_output)
|
|
|
|
|
|
|
|
" Only include the --stdin-display-name argument if we can parse the
|
|
|
|
" flake8 version, and it is recent enough to support it.
|
|
|
|
let l:display_name_args = s:SupportsDisplayName(l:version)
|
|
|
|
\ ? '--stdin-display-name %s'
|
|
|
|
\ : ''
|
|
|
|
|
2016-11-14 17:52:31 +00:00
|
|
|
return ale_linters#python#flake8#GetExecutable(a:buffer)
|
2017-02-06 11:12:21 +00:00
|
|
|
\ . ' ' . g:ale_python_flake8_args . ' ' . l:display_name_args . ' -'
|
2016-11-14 17:52:31 +00:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 18:51:29 +00:00
|
|
|
call ale#linter#Define('python', {
|
2016-09-15 19:20:41 +00:00
|
|
|
\ 'name': 'flake8',
|
2016-11-14 17:52:31 +00:00
|
|
|
\ 'executable_callback': 'ale_linters#python#flake8#GetExecutable',
|
2017-02-06 11:12:21 +00:00
|
|
|
\ 'command_chain': [
|
|
|
|
\ {'callback': 'ale_linters#python#flake8#VersionCheck'},
|
|
|
|
\ {'callback': 'ale_linters#python#flake8#GetCommand'},
|
|
|
|
\ ],
|
2016-10-20 14:23:23 +00:00
|
|
|
\ 'callback': 'ale#handlers#HandlePEP8Format',
|
2016-09-13 21:23:37 +00:00
|
|
|
\})
|