marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #3381 from andreypopp/gofmt-stding-stdout

Browse source 
Use stdin/stdout to communicate with gofmt
This commit is contained in:
Horacio Sanson 2020-11-29 18:59:48 +09:00 committed by GitHub
commit 03b6978a27
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
autoload/ale/fixers/gofmt.vim
View file

@ -11,9 +11,6 @@ function! ale#fixers#gofmt#Fix(buffer) abort
return { return {
\ 'command': l:env . ale#Escape(l:executable) \ 'command': l:env . ale#Escape(l:executable)
\ . ' -l -w'
\ . (empty(l:options) ? '' : ' ' . l:options) \ . (empty(l:options) ? '' : ' ' . l:options)
\ . ' %t',
\ 'read_temporary_file': 1,
\} \}
endfunction endfunction

14
test/fixers/test_gofmt_fixer_callback.vader
View file

@ -21,10 +21,7 @@ Execute(The gofmt callback should return the correct default values):
AssertEqual AssertEqual
\ { \ {
\ 'read_temporary_file': 1, \ 'command': ale#Escape('xxxinvalid'),
\ 'command': ale#Escape('xxxinvalid')
\ . ' -l -w'
\ . ' %t',
\ }, \ },
\ ale#fixers#gofmt#Fix(bufnr('')) \ ale#fixers#gofmt#Fix(bufnr(''))
@ -35,11 +32,8 @@ Execute(The gofmt callback should include custom gofmt options):
AssertEqual AssertEqual
\ { \ {
\ 'read_temporary_file': 1,
\ 'command': ale#Escape('xxxinvalid') \ 'command': ale#Escape('xxxinvalid')
\ . ' -l -w' \ . ' ' . g:ale_go_gofmt_options,
\ . ' ' . g:ale_go_gofmt_options
\ . ' %t',
\ }, \ },
\ ale#fixers#gofmt#Fix(bufnr('')) \ ale#fixers#gofmt#Fix(bufnr(''))
@ -50,9 +44,7 @@ Execute(The gofmt callback should support Go environment variables):
AssertEqual AssertEqual
\ { \ {
\ 'read_temporary_file': 1,
\ 'command': ale#Env('GO111MODULE', 'off') \ 'command': ale#Env('GO111MODULE', 'off')
\ . ale#Escape('xxxinvalid') . ' -l -w' \ . ale#Escape('xxxinvalid')
\ . ' %t',
\ }, \ },
\ ale#fixers#gofmt#Fix(bufnr('')) \ ale#fixers#gofmt#Fix(bufnr(''))