From 105bc5569550925af3b5f679145e1a13e0840344 Mon Sep 17 00:00:00 2001
From: Pierre-Nicolas Clauss <pinicarus@protonmail.com>
Date: Sun, 17 Jan 2021 14:10:11 +0100
Subject: [PATCH] refactor(erlang/dialyzer): remove file placeholder from
 options

Signed-off-by: Pierre-Nicolas Clauss <pinicarus@protonmail.com>
---
 ale_linters/erlang/dialyzer.vim                               | 4 ++--
 doc/ale-erlang.txt                                            | 4 ++--
 .../test_erlang_dialyzer_command_callback.vader               | 1 +
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/ale_linters/erlang/dialyzer.vim b/ale_linters/erlang/dialyzer.vim
index 41898d9c..a97c9520 100644
--- a/ale_linters/erlang/dialyzer.vim
+++ b/ale_linters/erlang/dialyzer.vim
@@ -7,8 +7,7 @@ let g:ale_erlang_dialyzer_options =
 \   get(g:, 'ale_erlang_dialyzer_options', '-Wunmatched_returns'
 \                                        . ' -Werror_handling'
 \                                        . ' -Wrace_conditions'
-\                                        . ' -Wunderspecs'
-\                                        . ' %s')
+\                                        . ' -Wunderspecs')
 let g:ale_erlang_dialyzer_plt_file =
 \   get(g:, 'ale_erlang_dialyzer_plt_file', '')
 let g:ale_erlang_dialyzer_rebar3_profile =
@@ -59,6 +58,7 @@ function! ale_linters#erlang#dialyzer#GetCommand(buffer) abort
     \   . ' -n'
     \   . ' --plt ' . ale#Escape(ale_linters#erlang#dialyzer#GetPlt(a:buffer))
     \   . ' ' . l:options
+    \   . ' %s'
 
     return l:command
 endfunction
diff --git a/doc/ale-erlang.txt b/doc/ale-erlang.txt
index 47524e05..93ac7915 100644
--- a/doc/ale-erlang.txt
+++ b/doc/ale-erlang.txt
@@ -16,10 +16,10 @@ g:ale_erlang_dialyzer_executable             *g:ale_erlang_dialyzer_executable*
 g:ale_erlang_dialyzer_options                   *g:ale_erlang_dialyzer_options*
                                                 *b:ale_erlang_dialyzer_options*
   Type: |String|
-  Default: `'-Wunmatched_returns -Werror_handling -Wrace_conditions -Wunderspec %s'`
+  Default: `'-Wunmatched_returns -Werror_handling -Wrace_conditions -Wunderspec'`
 
   This variable can be changed to specify the options to pass to the dialyzer
-  executable. The `%s` marker can be used to denote the current file.
+  executable.
 
 g:ale_erlang_dialyzer_plt_file                 *g:ale_erlang_dialyzer_plt_file*
                                                *b:ale_erlang_dialyzer_plt_file*
diff --git a/test/command_callback/test_erlang_dialyzer_command_callback.vader b/test/command_callback/test_erlang_dialyzer_command_callback.vader
index 97e0455f..5e818d7f 100644
--- a/test/command_callback/test_erlang_dialyzer_command_callback.vader
+++ b/test/command_callback/test_erlang_dialyzer_command_callback.vader
@@ -31,6 +31,7 @@ Execute(The command should accept configured options.):
     \ ale#Escape('dialyzer')
     \ . ' -n --plt ' . ale#Escape(expand('$HOME/.dialyzer_plt'))
     \ . ' -r ' . expand('$HOME')
+    \ . ' %s'
 
 Execute(The command should accept configured PLT file.):
     let b:ale_erlang_dialyzer_plt_file = 'custom-plt'