marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1129 from aliou/rubocop-cop-as-error-code

Browse source 
#852 - Capture error codes for Rubocop
This commit is contained in:
w0rp 2017-11-14 18:16:22 +00:00 committed by GitHub
commit 2e9cd978a2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
ale_linters/ruby/rubocop.vim
View file

@ -34,7 +34,8 @@ function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort
\ 'lnum': l:error['location']['line'] + 0,
\ 'col': l:start_col,
\ 'end_col': l:start_col + l:error['location']['length'] - 1,
\ 'text': printf('%s [%s]', l:error['message'], l:error['cop_name']),
\ 'code': l:error['cop_name'],
\ 'text': l:error['message'],
\ 'type': ale_linters#ruby#rubocop#GetType(l:error['severity']),
\})
endfor

12
test/handler/test_rubocop_handler.vader
View file

@ -12,28 +12,32 @@ Execute(The rubocop handler should parse lines correctly):
\ 'lnum': 83,
\ 'col': 29,
\ 'end_col': 35,
\ 'text': 'Prefer single-quoted strings... [Style/SomeCop]',
\ 'text': 'Prefer single-quoted strings...',
\ 'code': 'Style/SomeCop',
\ 'type': 'W',
\ },
\ {
\ 'lnum': 12,
\ 'col': 2,
\ 'end_col': 2,
\ 'text': 'Some error [Style/SomeOtherCop]',
\ 'text': 'Some error',
\ 'code': 'Style/SomeOtherCop',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 10,
\ 'col': 5,
\ 'end_col': 12,
\ 'text': 'Regular warning [Style/WarningCop]',
\ 'text': 'Regular warning',
\ 'code': 'Style/WarningCop',
\ 'type': 'W',
\ },
\ {
\ 'lnum': 11,
\ 'col': 1,
\ 'end_col': 1,
\ 'text': 'Another error [Style/SpaceBeforeBlockBraces]',
\ 'text': 'Another error',
\ 'code': 'Style/SpaceBeforeBlockBraces',
\ 'type': 'E',
\ },
\ ],