marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #3551 from fenuks/bugfix-3506

Browse source 
Fix clang-tidy ignoring compile-commands.json
This commit is contained in:
Horacio Sanson 2021-01-23 01:55:40 +09:00 committed by GitHub
commit 33f2f8ddcd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ale_linters/cpp/clangtidy.vim
View file

@ -23,11 +23,13 @@ function! ale_linters#cpp#clangtidy#GetCommand(buffer, output) abort
let l:options = ale#Var(a:buffer, 'cpp_clangtidy_options') let l:options = ale#Var(a:buffer, 'cpp_clangtidy_options')
let l:cflags = ale#c#GetCFlags(a:buffer, a:output) let l:cflags = ale#c#GetCFlags(a:buffer, a:output)
let l:options .= !empty(l:options) ? ale#Pad(l:cflags) : l:cflags let l:options .= !empty(l:options) ? ale#Pad(l:cflags) : l:cflags
endif
" Tell clang-tidy a .h header with a C++ filetype in Vim is a C++ file. " Tell clang-tidy a .h header with a C++ filetype in Vim is a C++ file
if expand('#' . a:buffer) =~# '\.h$' " only when compile-commands.json file is not there. Adding these
let l:options .= !empty(l:options) ? ' -x c++' : '-x c++' " flags makes clang-tidy completely ignore compile commmands.
if expand('#' . a:buffer) =~# '\.h$'
let l:options .= !empty(l:options) ? ' -x c++' : '-x c++'
endif
endif endif
" Get the options to pass directly to clang-tidy " Get the options to pass directly to clang-tidy

1
test/command_callback/test_clang_tidy_command_callback.vader
View file

@ -68,7 +68,6 @@ Execute(The build directory should be used for header files):
\ ale#Escape('clang-tidy') \ ale#Escape('clang-tidy')
\ . ' -checks=' . ale#Escape('*') . ' %s' \ . ' -checks=' . ale#Escape('*') . ' %s'
\ . ' -p ' . ale#Escape('/foo/bar') \ . ' -p ' . ale#Escape('/foo/bar')
\ . ' -- -x c++'
call ale#test#SetFilename('test.hpp') call ale#test#SetFilename('test.hpp')