marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix #553 - Filter out errors from other files for gometalinter

Browse source
This commit is contained in:
w0rp 2017-05-15 20:43:55 +01:00
parent 2503eda68b
commit 548c1a1007
2 changed files with 24 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ale_linters/go/gometalinter.vim
View file

@ -22,7 +22,7 @@ function! ale_linters#go#gometalinter#Handler(buffer, lines) abort
for l:match in ale_linters#go#gometalinter#GetMatches(a:lines) for l:match in ale_linters#go#gometalinter#GetMatches(a:lines)
" Omit errors from files other than the one currently open " Omit errors from files other than the one currently open
if ale#path#IsBufferPath(a:buffer, l:match[0]) if !ale#path#IsBufferPath(a:buffer, l:match[1])
continue continue
endif endif

25
test/handler/test_gometalinter_handler.vader
View file

@ -30,7 +30,7 @@ Execute (The gometalinter handler should handle names with spaces):
\ ]), 'v:val[1:5]') \ ]), 'v:val[1:5]')
Execute (The gometalinter handler should handle relative paths correctly): Execute (The gometalinter handler should handle relative paths correctly):
:file! /foo/bar/baz.go silent file /foo/bar/baz.go
AssertEqual AssertEqual
\ [ \ [
@ -47,7 +47,28 @@ Execute (The gometalinter handler should handle relative paths correctly):
\ 'type': 'E', \ 'type': 'E',
\ }, \ },
\ ], \ ],
\ ale_linters#go#gometalinter#Handler(42, [ \ ale_linters#go#gometalinter#Handler(bufnr(''), [
\ 'baz.go:12:3:warning: expected ''package'', found ''IDENT'' gibberish (staticcheck)', \ 'baz.go:12:3:warning: expected ''package'', found ''IDENT'' gibberish (staticcheck)',
\ 'baz.go:37:5:error: expected ''package'', found ''IDENT'' gibberish (golint)', \ 'baz.go:37:5:error: expected ''package'', found ''IDENT'' gibberish (golint)',
\ ]) \ ])
Execute (The gometalinter handler should filter out errors from other files):
silent file! /some/path/sql.go
AssertEqual
\ [],
\ ale_linters#go#gometalinter#Handler(bufnr(''), [
\ '/some/path/interface_implementation_test.go:417::warning: cyclomatic complexity 24 of function testGetUserHeaders() is high (> 10) (gocyclo)',
\ '/some/path/sql_helpers.go:38::warning: cyclomatic complexity 11 of function CreateTestUserMetadataDB() is high (> 10) (gocyclo)',
\ '/some/path/sql_alpha.go:560:7:warning: ineffectual assignment to err (ineffassign)',
\ '/some/path/sql_alpha.go:589:7:warning: ineffectual assignment to err (ineffassign)',
\ '/some/path/sql_test.go:124:9:warning: should not use basic type untyped string as key in context.WithValue (golint)',
\ '/some/path/interface_implementation_test.go:640::warning: declaration of "cfg" shadows declaration at sql_test.go:21 (vetshadow)',
\ '/some/path/sql_helpers.go:55::warning: declaration of "err" shadows declaration at sql_helpers.go:48 (vetshadow)',
\ '/some/path/sql_helpers.go:91::warning: declaration of "err" shadows declaration at sql_helpers.go:48 (vetshadow)',
\ '/some/path/sql_helpers.go:108::warning: declaration of "err" shadows declaration at sql_helpers.go:48 (vetshadow)',
\ '/some/path/user_metadata_db.go:149::warning: declaration of "err" shadows declaration at user_metadata_db.go:140 (vetshadow)',
\ '/some/path/user_metadata_db.go:188::warning: declaration of "err" shadows declaration at user_metadata_db.go:179 (vetshadow)',
\ '/some/path/queries_alpha.go:62::warning: Potential hardcoded credentials,HIGH,LOW (gas)',
\ ])