marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix the regex of phpmd

Browse source
This commit is contained in:
Diego Oliveira 2017-10-22 14:56:09 -02:00
parent 47577564a2
commit 5b986ce5d3
2 changed files with 25 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ale_linters/php/phpmd.vim
View file

@ -14,7 +14,7 @@ function! ale_linters#php#phpmd#Handle(buffer, lines) abort
" Matches against lines like the following:
"
" /path/to/some-filename.php:18 message
let l:pattern = '^.*:\(\d\+\)\t\(.\+\)$'
let l:pattern = '^.*:\(\d\+\)\s\+\(.\+\)$'
let l:output = []
for l:match in ale#util#GetMatches(a:lines, l:pattern)

24
test/handler/test_php_phpmd_handler.vader Normal file
View file

@ -0,0 +1,24 @@
Before:
runtime ale_linters/php/phpmd.vim
Execute(The php static analyzer handler should parse errors from phpmd):
AssertEqual
\ [
\ {
\ 'lnum': 22,
\ 'type': 'W',
\ 'text': "Avoid unused local variables such as '$response'.",
\ },
\ {
\ 'lnum': 14,
\ 'type': 'W',
\ 'text': "The method test uses an else expression. Else is never necessary and you can simplify the code to work without else.",
\ },
\ ],
\ ale_linters#php#phpmd#Handle(347, [
\ "example.php:22 Avoid unused local variables such as '$response'.",
\ "example.php:14 The method test uses an else expression. Else is never necessary and you can simplify the code to work without else.",
\ ])
After:
call ale#linter#Reset()