From 62602569b33d61d899da4345009dcc4b373d80d8 Mon Sep 17 00:00:00 2001 From: Eddie Lebow Date: Thu, 15 Aug 2019 00:00:34 -0400 Subject: [PATCH] clangcheck: Add -fno-color-diagnostics Also change to the modern --extra-arg syntax. --- ale_linters/cpp/clangcheck.vim | 2 +- .../test_cpp_clangcheck_command_callbacks.vader | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ale_linters/cpp/clangcheck.vim b/ale_linters/cpp/clangcheck.vim index 7d32a57c..4cb04864 100644 --- a/ale_linters/cpp/clangcheck.vim +++ b/ale_linters/cpp/clangcheck.vim @@ -20,7 +20,7 @@ function! ale_linters#cpp#clangcheck#GetCommand(buffer) abort " being generated. These are only added if no build directory can be " detected. return '%e -analyze %s' - \ . (empty(l:build_dir) ? ' -extra-arg -Xclang -extra-arg -analyzer-output=text' : '') + \ . (empty(l:build_dir) ? ' --extra-arg=-Xclang --extra-arg=-analyzer-output=text --extra-arg=-fno-color-diagnostics': '') \ . ale#Pad(l:user_options) \ . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '') endfunction diff --git a/test/command_callback/test_cpp_clangcheck_command_callbacks.vader b/test/command_callback/test_cpp_clangcheck_command_callbacks.vader index 7aa09eed..188141d5 100644 --- a/test/command_callback/test_cpp_clangcheck_command_callbacks.vader +++ b/test/command_callback/test_cpp_clangcheck_command_callbacks.vader @@ -7,7 +7,7 @@ After: Execute(The executable should be configurable): AssertLinter 'clang-check', \ ale#Escape('clang-check') - \ . ' -analyze %s -extra-arg -Xclang -extra-arg -analyzer-output=text' + \ . ' -analyze %s --extra-arg=-Xclang --extra-arg=-analyzer-output=text --extra-arg=-fno-color-diagnostics' let b:ale_cpp_clangcheck_executable = 'foobar' @@ -15,7 +15,7 @@ Execute(The executable should be configurable): " being generated. AssertLinter 'foobar', \ ale#Escape('foobar') - \ . ' -analyze %s -extra-arg -Xclang -extra-arg -analyzer-output=text' + \ . ' -analyze %s --extra-arg=-Xclang --extra-arg=-analyzer-output=text --extra-arg=-fno-color-diagnostics' Execute(The options should be configurable): let b:ale_cpp_clangcheck_options = '--something' @@ -23,7 +23,7 @@ Execute(The options should be configurable): AssertLinter 'clang-check', \ ale#Escape('clang-check') \ . ' -analyze %s' - \ . ' -extra-arg -Xclang -extra-arg -analyzer-output=text' + \ . ' --extra-arg=-Xclang --extra-arg=-analyzer-output=text --extra-arg=-fno-color-diagnostics' \ . ' --something' Execute(The build directory should be used when set):