marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #2150 from mvgrimes/perl-linter-data-fix

Browse source 
Update the perl-linter's l:pattern to catch missing errors
This commit is contained in:
w0rp 2018-12-20 16:22:10 +00:00 committed by GitHub
commit 73ca1e7191
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ale_linters/perl/perl.vim
View file

@ -18,7 +18,7 @@ function! ale_linters#perl#perl#Handle(buffer, lines) abort
return []
endif
let l:pattern = '\(.\+\) at \(.\+\) line \(\d\+\)'
let l:pattern = '\(..\{-}\) at \(..\{-}\) line \(\d\+\)'
let l:output = []
let l:basename = expand('#' . a:buffer . ':t')

16
test/handler/test_perl_handler.vader
View file

@ -91,3 +91,19 @@ Execute(The Perl linter reports errors even when mixed with warnings):
\ 'syntax error at - line 8, at EOF',
\ 'Execution of t.pl aborted due to compilation errors.',
\ ])
Execute(The Perl linter reports errors even when an additional file location is included):
AssertEqual
\ [
\ {'lnum': '5', 'type': 'E', 'text': '"my" variable $foo masks earlier declaration in same scope'},
\ {'lnum': '6', 'type': 'E', 'text': '"my" variable $foo masks earlier declaration in same scope'},
\ {'lnum': '11', 'type': 'E', 'text': 'Global symbol "$asdf" requires explicit package name (did you forget to declare "my $asdf"?)'},
\ {'lnum': '12', 'type': 'E', 'text': 'Global symbol "$asdf" requires explicit package name (did you forget to declare "my $asdf"?)'},
\ ],
\ ale_linters#perl#perl#Handle(bufnr(''), [
\ '"my" variable $foo masks earlier declaration in same scope at - line 5.',
\ '"my" variable $foo masks earlier declaration in same scope at - line 6, at <DATA> line 1.',
\ 'Global symbol "$asdf" requires explicit package name (did you forget to declare "my $asdf"?) at - line 11.',
\ 'Global symbol "$asdf" requires explicit package name (did you forget to declare "my $asdf"?) at - line 12, <DATA> line 1.',
\ 'Execution of t.pl aborted due to compilation errors.',
\ ])