marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1861 from dimbleby/goto-definition-column

Browse source 
Fix out-by-one error in column on goto-definition
This commit is contained in:
w0rp 2018-08-28 10:11:44 +01:00 committed by GitHub
commit b6112aedc3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
autoload/ale/definition.vim
View file

@ -49,7 +49,7 @@ function! ale#definition#HandleLSPResponse(conn_id, response) abort
for l:item in l:result for l:item in l:result
let l:filename = ale#path#FromURI(l:item.uri) let l:filename = ale#path#FromURI(l:item.uri)
let l:line = l:item.range.start.line + 1 let l:line = l:item.range.start.line + 1
let l:column = l:item.range.start.character let l:column = l:item.range.start.character + 1
call ale#util#Open(l:filename, l:line, l:column, l:options) call ale#util#Open(l:filename, l:line, l:column, l:options)
break break

8
test/test_go_to_definition.vader
View file

@ -213,7 +213,7 @@ Execute(Other files should be jumped to for LSP definition responses):
\ 'edit +3 ' . fnameescape(ale#path#Simplify(g:dir . '/completion_dummy_file')), \ 'edit +3 ' . fnameescape(ale#path#Simplify(g:dir . '/completion_dummy_file')),
\ ], \ ],
\ g:expr_list \ g:expr_list
AssertEqual [3, 7], getpos('.')[1:2] AssertEqual [3, 8], getpos('.')[1:2]
AssertEqual {}, ale#definition#GetMap() AssertEqual {}, ale#definition#GetMap()
Execute(Locations inside the same file should be jumped to without using :edit): Execute(Locations inside the same file should be jumped to without using :edit):
@ -235,7 +235,7 @@ Execute(Locations inside the same file should be jumped to without using :edit):
\ [ \ [
\ ], \ ],
\ g:expr_list \ g:expr_list
AssertEqual [3, 7], getpos('.')[1:2] AssertEqual [3, 8], getpos('.')[1:2]
AssertEqual {}, ale#definition#GetMap() AssertEqual {}, ale#definition#GetMap()
Execute(Other files should be jumped to in tabs for LSP definition responses): Execute(Other files should be jumped to in tabs for LSP definition responses):
@ -258,7 +258,7 @@ Execute(Other files should be jumped to in tabs for LSP definition responses):
\ 'tabedit +3 ' . fnameescape(ale#path#Simplify(g:dir . '/completion_dummy_file')), \ 'tabedit +3 ' . fnameescape(ale#path#Simplify(g:dir . '/completion_dummy_file')),
\ ], \ ],
\ g:expr_list \ g:expr_list
AssertEqual [3, 7], getpos('.')[1:2] AssertEqual [3, 8], getpos('.')[1:2]
AssertEqual {}, ale#definition#GetMap() AssertEqual {}, ale#definition#GetMap()
Execute(Definition responses with lists should be handled): Execute(Definition responses with lists should be handled):
@ -289,7 +289,7 @@ Execute(Definition responses with lists should be handled):
\ 'edit +3 ' . fnameescape(ale#path#Simplify(g:dir . '/completion_dummy_file')), \ 'edit +3 ' . fnameescape(ale#path#Simplify(g:dir . '/completion_dummy_file')),
\ ], \ ],
\ g:expr_list \ g:expr_list
AssertEqual [3, 7], getpos('.')[1:2] AssertEqual [3, 8], getpos('.')[1:2]
AssertEqual {}, ale#definition#GetMap() AssertEqual {}, ale#definition#GetMap()
Execute(Definition responses with null response should be handled): Execute(Definition responses with null response should be handled):