marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #1869 from Steap/feature/gitlint-ignore-whitespace

Browse source 
gitcommit: fully implement warn_about_trailing_whitespace
This commit is contained in:
w0rp 2018-09-03 11:27:19 +01:00 committed by GitHub
commit c1f0956d9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ale_linters/gitcommit/gitlint.vim
View file

@ -23,9 +23,11 @@ function! ale_linters#gitcommit#gitlint#Handle(buffer, lines) abort
for l:match in ale#util#GetMatches(a:lines, l:pattern)
let l:code = l:match[2]
if l:code is# 'T2' && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
if !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
if l:code is# 'T2' || l:code is# 'B2'
continue
endif
endif
let l:item = {
\ 'lnum': l:match[1] + 0,

19
test/handler/test_gitlint_handler.vader
View file

@ -61,6 +61,19 @@ Execute(Disabling trailing whitespace warnings should work):
\ '8: T2 Trailing whitespace',
\])
AssertEqual
\ [
\ {
\ 'lnum': 8,
\ 'type': 'E',
\ 'text': 'Trailing whitespace',
\ 'code': 'B2',
\ },
\ ],
\ ale_linters#gitcommit#gitlint#Handle(bufnr(''), [
\ '8: B2 Trailing whitespace',
\])
let b:ale_warn_about_trailing_whitespace = 0
AssertEqual
@ -68,3 +81,9 @@ Execute(Disabling trailing whitespace warnings should work):
\ ale_linters#gitcommit#gitlint#Handle(bufnr(''), [
\ '8: T2 Trailing whitespace',
\ ])
AssertEqual
\ [],
\ ale_linters#gitcommit#gitlint#Handle(bufnr(''), [
\ '8: B2 Trailing whitespace',
\ ])