Merge pull request #1964 from dlresende/master
Fix PMD not working with classes without package
This commit is contained in:
commit
e984497ec9
2 changed files with 16 additions and 1 deletions
|
@ -2,7 +2,7 @@
|
|||
" Description: PMD for Java files
|
||||
|
||||
function! ale_linters#java#pmd#Handle(buffer, lines) abort
|
||||
let l:pattern = '"\(\d\+\)",".\+","\(.\+\)","\(\d\+\)","\(\d\+\)","\(.\+\)","\(.\+\)","\(.\+\)"$'
|
||||
let l:pattern = '"\(\d\+\)",".*","\(.\+\)","\(\d\+\)","\(\d\+\)","\(.\+\)","\(.\+\)","\(.\+\)"$'
|
||||
let l:output = []
|
||||
|
||||
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
||||
|
|
|
@ -25,3 +25,18 @@ Execute(The pmd handler should parse lines correctly):
|
|||
\ '"1","rsb.performance.test.ros","/home/languitar/src/rsb-performance-test-api-ros/src/main/java/rsb/performance/test/ros/NodeHolder.java","3","18","Each class should declare at least one constructor","Code Style","AtLeastOneConstructor"',
|
||||
\ '"2","rsb.performance.test.ros","/home/languitar/src/rsb-performance-test-api-ros/src/main/java/rsb/performance/test/ros/NodeHolder.java","1","36","Local variable ''node'' could be declared final","Code Style","LocalVariableCouldBeFinal"'
|
||||
\ ])
|
||||
|
||||
Execute(The pmd handler should parse lines correctly for java files that use unnamed packages):
|
||||
AssertEqual
|
||||
\ [
|
||||
\ {
|
||||
\ 'lnum': 8,
|
||||
\ 'text': 'Avoid unused local variables such as ''stest''.',
|
||||
\ 'code': 'Best Practices - UnusedLocalVariable',
|
||||
\ 'type': 'W',
|
||||
\ },
|
||||
\ ],
|
||||
\ ale_linters#java#pmd#Handle(666, [
|
||||
\ '"Problem","Package","File","Priority","Line","Description","Rule set","Rule"',
|
||||
\ '"1","","/Users/diego/Projects/github.com/dlresende/kata-fizz-buzz/src/main/java/App.java","3","8","Avoid unused local variables such as ''stest''.","Best Practices","UnusedLocalVariable"'
|
||||
\ ])
|
||||
|
|
Reference in a new issue