marc/ale
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fixers/xo: support monorepos

Browse source
This commit is contained in:
Charles B Johnson 2020-06-29 18:40:43 -05:00
parent 8ffde14039
commit f17beadb49
No known key found for this signature in database
GPG key ID: 390184033B3454E3
8 changed files with 16 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
autoload/ale/handlers/xo.vim
View file

@ -29,7 +29,7 @@ function! ale#handlers#xo#HandleJSON(buffer, lines) abort
endfunction
function! ale#handlers#xo#GetProjectRoot(buffer) abort
let l:package_path = ale#path#FindNearestFile(a:buffer, 'package.json')
let l:modules_dir = ale#path#FindNearestDirectory(a:buffer, 'node_modules')
return empty(l:package_path) ? '' : fnamemodify(l:package_path, ':p:h')
return empty(l:modules_dir) ? '' : fnamemodify(l:modules_dir, ':h:h')
endfunction

14
test/fixers/test_xo_fixer_callback.vader
View file

@ -7,39 +7,39 @@ After:
call ale#assert#TearDownFixerTest()
Execute(The xo callback should return the correct default values):
call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.js')
call ale#test#SetFilename('../xo-test-files/monorepo/packages/a/index.js')
AssertFixer
\ {
\ 'read_temporary_file': 1,
\ 'command': (has('win32') ? 'node.exe ' : '')
\ . ale#Escape(ale#path#Simplify(g:dir . '/../eslint-test-files/react-app/node_modules/xo/cli.js'))
\ . ale#Escape(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo/node_modules/xo/cli.js'))
\ . ' --fix %t',
\ }
Execute(The xo callback should include custom xo options):
let g:ale_javascript_xo_options = '--space'
call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.js')
call ale#test#SetFilename('../xo-test-files/monorepo/packages/a/index.js')
AssertFixer
\ {
\ 'read_temporary_file': 1,
\ 'command': (has('win32') ? 'node.exe ' : '')
\ . ale#Escape(ale#path#Simplify(g:dir . '/../eslint-test-files/react-app/node_modules/xo/cli.js'))
\ . ale#Escape(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo/node_modules/xo/cli.js'))
\ . ' --fix %t'
\ . ' --space',
\ }
Execute(--stdin should be used when xo is new enough):
let g:ale_javascript_xo_options = '--space'
call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.js')
call ale#test#SetFilename('../xo-test-files/monorepo/packages/a/index.js')
GivenCommandOutput ['0.30.0']
AssertFixer
\ {
\ 'command': ale#path#CdString(ale#path#Simplify(g:dir . '/../eslint-test-files'))
\ 'command': ale#path#CdString(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo'))
\ . (has('win32') ? 'node.exe ' : '')
\ . ale#Escape(ale#path#Simplify(g:dir . '/../eslint-test-files/react-app/node_modules/xo/cli.js'))
\ . ale#Escape(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo/node_modules/xo/cli.js'))
\ . ' --stdin --stdin-filename %s'
\ . ' --fix'
\ . ' --space',

14
test/fixers/test_xots_fixer_callback.vader
View file

@ -7,39 +7,39 @@ After:
call ale#assert#TearDownFixerTest()
Execute(The xo callback should return the correct default values):
call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.ts')
call ale#test#SetFilename('../xo-test-files/monorepo/packages/a/index.ts')
AssertFixer
\ {
\ 'read_temporary_file': 1,
\ 'command': (has('win32') ? 'node.exe ' : '')
\ . ale#Escape(ale#path#Simplify(g:dir . '/../eslint-test-files/react-app/node_modules/xo/cli.js'))
\ . ale#Escape(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo/node_modules/xo/cli.js'))
\ . ' --fix %t',
\ }
Execute(The xo callback should include custom xo options):
let g:ale_typescript_xo_options = '--space'
call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.ts')
call ale#test#SetFilename('../xo-test-files/monorepo/packages/a/index.ts')
AssertFixer
\ {
\ 'read_temporary_file': 1,
\ 'command': (has('win32') ? 'node.exe ' : '')
\ . ale#Escape(ale#path#Simplify(g:dir . '/../eslint-test-files/react-app/node_modules/xo/cli.js'))
\ . ale#Escape(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo/node_modules/xo/cli.js'))
\ . ' --fix %t'
\ . ' --space',
\ }
Execute(--stdin should be used when xo is new enough):
let g:ale_typescript_xo_options = '--space'
call ale#test#SetFilename('../eslint-test-files/react-app/subdir/testfile.ts')
call ale#test#SetFilename('../xo-test-files/monorepo/packages/a/index.ts')
GivenCommandOutput ['0.30.0']
AssertFixer
\ {
\ 'command': ale#path#CdString(ale#path#Simplify(g:dir . '/../eslint-test-files'))
\ 'command': ale#path#CdString(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo'))
\ . (has('win32') ? 'node.exe ' : '')
\ . ale#Escape(ale#path#Simplify(g:dir . '/../eslint-test-files/react-app/node_modules/xo/cli.js'))
\ . ale#Escape(ale#path#Simplify(g:dir . '/../xo-test-files/monorepo/node_modules/xo/cli.js'))
\ . ' --stdin --stdin-filename %s'
\ . ' --fix'
\ . ' --space',

0
test/xo-test-files/monorepo/node_modules/xo/cli.js generated vendored Normal file
View file

0
test/xo-test-files/monorepo/package.json Normal file
View file

0
test/xo-test-files/monorepo/packages/a/index.js Normal file
View file

0
test/xo-test-files/monorepo/packages/a/index.ts Normal file
View file

0
test/xo-test-files/monorepo/packages/a/package.json Normal file
View file