Merge pull request #3576 from cyyever/fish_indent

Fish indent

autoload/ale/fix/registry.vim

@@ -216,6 +216,11 @@ let s:default_registry = {
 \       'suggested_filetypes': ['cmake'],
 \       'description': 'Fix CMake files with cmake-format.',
 \   },
+\   'fish_indent': {
+\       'function': 'ale#fixers#fish_indent#Fix',
+\       'suggested_filetypes': ['fish'],
+\       'description': 'Format fish scripts using fish_indent.',
+\   },
 \   'gofmt': {
 \       'function': 'ale#fixers#gofmt#Fix',
 \       'suggested_filetypes': ['go'],

autoload/ale/fixers/fish_indent.vim

@@ -0,0 +1,19 @@
+" Author: Chen YuanYuan <cyyever@outlook.com>
+" Description: Integration of fish_indent with ALE.
+
+call ale#Set('fish_fish_indent_executable', 'fish_indent')
+call ale#Set('fish_fish_indent_options', '')
+
+function! ale#fixers#fish_indent#Fix(buffer) abort
+    let l:executable = ale#Var(a:buffer, 'fish_fish_indent_executable')
+    let l:options = ale#Var(a:buffer, 'fish_fish_indent_options')
+    let l:filename = ale#Escape(bufname(a:buffer))
+
+    return {
+    \   'command': ale#Escape(l:executable)
+    \       . ' -w '
+    \       . (empty(l:options) ? '' : ' ' . l:options)
+    \       . ' %t',
+    \   'read_temporary_file': 1,
+    \}
+endfunction

doc/ale-fish.txt

@@ -10,5 +10,22 @@ displaying errors if an error message is not found.
 If ALE is not showing any errors but your file does not run as expected, run
 `fish -n <file.fish>` from the command line.
 
+===============================================================================
+fish_indent                                               *ale-fish-fish_indent*
+
+g:ale_fish_fish_indent_executable            *g:ale_fish_fish_indent_executable*
+                                             *b:ale_fish_fish_indent_executable*
+  Type: |String|
+  Default: `'fish_indent'`
+
+  This variable can be changed to use a different executable for fish_indent.
+
+g:ale_fish_fish_indent_options                  *g:ale_fish_fish_indent_options*
+                                                *b:ale_fish_fish_indent_options*
+  Type: |String|
+  Default: `''`
+
+  This variable can be set to pass additional options to fish_indent.
+
 ===============================================================================
   vim:tw=78:ts=2:sts=2:sw=2:ft=help:norl:

doc/ale-supported-languages-and-tools.txt

@@ -152,6 +152,7 @@ Notes:
   * `erlc`
 * Fish
   * `fish` (-n flag)
+  * `fish_indent`
 * Fortran
   * `gcc`
   * `language_server`

doc/ale.txt

@@ -2699,6 +2699,7 @@ documented in additional help files.
   eruby...................................|ale-eruby-options|
     ruumba................................|ale-eruby-ruumba|
   fish....................................|ale-fish-options|
+    fish_indent...........................|ale-fish-fish_indent|
   fortran.................................|ale-fortran-options|
     gcc...................................|ale-fortran-gcc|
     language_server.......................|ale-fortran-language-server|

supported-tools.md

@@ -161,6 +161,7 @@ formatting.
   * [erlc](http://erlang.org/doc/man/erlc.html)
 * Fish
   * fish [-n flag](https://linux.die.net/man/1/fish)
+  * [fish_indent](https://fishshell.com/docs/current/cmds/fish_indent.html)
 * Fortran
   * [gcc](https://gcc.gnu.org/)
   * [language_server](https://github.com/hansec/fortran-language-server)

test/fixers/test_fish_indent_fixer_callback.vader

@@ -0,0 +1,40 @@
+Before:
+  Save g:ale_fish_fish_indent_executable
+  Save g:ale_fish_fish_indent_options
+
+  " Use an invalid global executable, so we don't match it.
+  let g:ale_fish_fish_indent_executable = 'xxxinvalid'
+  let g:ale_fish_fish_indent_options = ''
+
+  call ale#test#SetDirectory('/testplugin/test/fixers')
+
+After:
+  Restore
+
+  call ale#test#RestoreDirectory()
+
+Execute(The fish_indent callback should return the correct default values):
+  call ale#test#SetFilename('../fish_files/testfile.fish')
+
+  AssertEqual
+  \ {
+  \   'read_temporary_file': 1,
+  \   'command': ale#Escape('xxxinvalid')
+  \   . ' -w '
+  \   . ' %t',
+  \ },
+  \ ale#fixers#fish_indent#Fix(bufnr(''))
+
+Execute(The fish_indent callback should include custom fish_indent options):
+  let g:ale_fish_fish_indent_options = "-d"
+  call ale#test#SetFilename('../fish_files/testfile.fish')
+
+  AssertEqual
+  \ {
+  \   'read_temporary_file': 1,
+  \   'command': ale#Escape('xxxinvalid')
+  \   . ' -w '
+  \   . ' -d'
+  \   . ' %t',
+  \ },
+  \ ale#fixers#fish_indent#Fix(bufnr(''))