From 72161b82ef29a7f6a1eb575533f61abd6ad13b53 Mon Sep 17 00:00:00 2001 From: Jasper Woudenberg Date: Mon, 26 Jun 2017 15:37:04 +0200 Subject: [PATCH] Elm linter shows full error ranges --- ale_linters/elm/make.vim | 2 ++ test/handler/test_elmmake_handler.vader | 10 ++++++++++ 2 files changed, 12 insertions(+) diff --git a/ale_linters/elm/make.vim b/ale_linters/elm/make.vim index da81287c..0a570ff6 100644 --- a/ale_linters/elm/make.vim +++ b/ale_linters/elm/make.vim @@ -23,6 +23,8 @@ function! ale_linters#elm#make#Handle(buffer, lines) abort call add(l:output, { \ 'lnum': l:error.region.start.line, \ 'col': l:error.region.start.column, + \ 'end_lnum': l:error.region.end.line, + \ 'end_col': l:error.region.end.column, \ 'type': (l:error.type ==? 'error') ? 'E' : 'W', \ 'text': l:error.overview, \ 'detail': l:error.overview . "\n\n" . l:error.details diff --git a/test/handler/test_elmmake_handler.vader b/test/handler/test_elmmake_handler.vader index 3f10a60d..cbd7ac9f 100644 --- a/test/handler/test_elmmake_handler.vader +++ b/test/handler/test_elmmake_handler.vader @@ -7,6 +7,8 @@ Execute(The elm-make handler should parse lines correctly): \ { \ 'lnum': 33, \ 'col': 1, + \ 'end_lnum': 33, + \ 'end_col': 19, \ 'type': 'W', \ 'text': 'warning overview', \ 'detail': "warning overview\n\nwarning details", @@ -14,6 +16,8 @@ Execute(The elm-make handler should parse lines correctly): \ { \ 'lnum': 404, \ 'col': 1, + \ 'end_lnum': 408, + \ 'end_col': 18, \ 'type': 'E', \ 'text': 'error overview 1', \ 'detail': "error overview 1\n\nerror details 1", @@ -21,6 +25,8 @@ Execute(The elm-make handler should parse lines correctly): \ { \ 'lnum': 406, \ 'col': 5, + \ 'end_lnum': 407, + \ 'end_col': 17, \ 'type': 'E', \ 'text': 'error overview 2', \ 'detail': "error overview 2\n\nerror details 2", @@ -28,6 +34,8 @@ Execute(The elm-make handler should parse lines correctly): \ { \ 'lnum': 406, \ 'col': 5, + \ 'end_lnum': 406, + \ 'end_col': 93, \ 'type': 'E', \ 'text': 'error overview 3', \ 'detail': "error overview 3\n\nerror details 3", @@ -44,6 +52,8 @@ Execute(The elm-make handler should put an error on the first line if a line can \ { \ 'lnum': 33, \ 'col': 1, + \ 'end_lnum': 33, + \ 'end_col': 19, \ 'type': 'W', \ 'text': 'warning overview', \ 'detail': "warning overview\n\nwarning details",