Bump the ALE version to v3.1.0

README.md

@@ -81,7 +81,6 @@ other content at [w0rp.com](https://w0rp.com).
     18. [How can I configure ALE differently for different buffers?](#faq-buffer-configuration)
     19. [How can I configure the height of the list in which ALE displays errors?](#faq-list-window-height)
     20. [How can I run linters or fixers via Docker or a VM?](#faq-vm)
-    21. [How can I change the borders for floating preview windows?](#faq-window-borders)
 
 <a name="supported-languages"></a>
 
@@ -908,23 +907,3 @@ tools are well-integrated with ALE, and ALE is properly configured to run the
 correct commands and map filename paths between different file systems. See
 `:help ale-lint-other-machines` for the full documentation on how to configure
 ALE to support this.
-
-<a name="faq-window-borders"></a>
-
-### 5.xxi. How can I change the borders for floating preview windows?
-
-Borders for floating preview windows are enabled by default. You can use the
-`g:ale_floating_window_border` setting to configure them.
-
-You could disable the border with an empty list.
-
-```vim
-let g:ale_floating_window_border = []
-```
-
-If the terminal supports Unicode, you might try setting the value like below, to
-make it look nicer.
-
-```vim
-let g:ale_floating_window_border = ['│', '─', '╭', '╮', '╯', '╰']
-```

ale_linters/ansible/ansible_lint.vim

@@ -1,4 +1,4 @@
-" Authors: Bjorn Neergaard <bjorn@neersighted.com>, Vytautas Macionis <vytautas.macionis@manomail.de>
+" Author: Bjorn Neergaard <bjorn@neersighted.com>
 " Description: ansible-lint for ansible-yaml files
 
 call ale#Set('ansible_ansible_lint_executable', 'ansible-lint')
@@ -7,7 +7,7 @@ function! ale_linters#ansible#ansible_lint#GetExecutable(buffer) abort
     return ale#Var(a:buffer, 'ansible_ansible_lint_executable')
 endfunction
 
-function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
+function! ale_linters#ansible#ansible_lint#Handle(buffer, lines) abort
     for l:line in a:lines[:10]
         if match(l:line, '^Traceback') >= 0
             return [{
@@ -18,86 +18,39 @@ function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
         endif
     endfor
 
-    let l:version_group = ale#semver#GTE(a:version, [5, 0, 0]) ? '>=5.0.0' : '<5.0.0'
+    " Matches patterns line the following:
+    "
+    " test.yml:35: [EANSIBLE0002] Trailing whitespace
+    let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?: \[?([[:alnum:]]+)\]? (.*)$'
     let l:output = []
 
-    if '>=5.0.0' is# l:version_group
-        " Matches patterns line the following:
-        "      test.yml:3:148: syntax-check 'var' is not a valid attribute for a Play
-        "      roles/test/tasks/test.yml:8: [package-latest] [VERY_LOW] Package installs should not use latest
-        "      D:\test\tasks\test.yml:8: [package-latest] [VERY_LOW] package installs should not use latest
-        let l:pattern = '\v^(%([a-zA-Z]:)?[^:]+):(\d+):%((\d+):)? %(\[([-[:alnum:]]+)\]) %(\[([_[:alnum:]]+)\]) (.*)$'
-        let l:error_codes = { 'VERY_HIGH': 'E', 'HIGH': 'E', 'MEDIUM': 'W', 'LOW': 'W', 'VERY_LOW': 'W', 'INFO': 'I' }
+    for l:match in ale#util#GetMatches(a:lines, l:pattern)
+        let l:code = l:match[4]
 
-        for l:match in ale#util#GetMatches(a:lines, l:pattern)
-            if ale#path#IsBufferPath(a:buffer, l:match[1])
-                call add(l:output, {
-                \   'lnum': l:match[2] + 0,
-                \   'col': l:match[3] + 0,
-                \   'text': l:match[6],
-                \   'code': l:match[4],
-                \   'type': l:error_codes[l:match[5]],
-                \})
-            endif
-        endfor
-    endif
+        if l:code is# 'EANSIBLE0002'
+        \&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
+            " Skip warnings for trailing whitespace if the option is off.
+            continue
+        endif
 
-    if '<5.0.0' is# l:version_group
-        " Matches patterns line the following:
-        "      test.yml:35: [EANSIBLE0002] Trailing whitespace
-        let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?: \[?([[:alnum:]]+)\]? (.*)$'
-
-        for l:match in ale#util#GetMatches(a:lines, l:pattern)
-            let l:code = l:match[4]
-
-            if l:code is# 'EANSIBLE0002'
-            \&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
-                " Skip warnings for trailing whitespace if the option is off.
-                continue
-            endif
-
-            if ale#path#IsBufferPath(a:buffer, l:match[1])
-                call add(l:output, {
-                \   'lnum': l:match[2] + 0,
-                \   'col': l:match[3] + 0,
-                \   'text': l:match[5],
-                \   'code': l:code,
-                \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
-                \})
-            endif
-        endfor
-    endif
+        if ale#path#IsBufferPath(a:buffer, l:match[1])
+            call add(l:output, {
+            \   'lnum': l:match[2] + 0,
+            \   'col': l:match[3] + 0,
+            \   'text': l:match[5],
+            \   'code': l:code,
+            \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
+            \})
+        endif
+    endfor
 
     return l:output
 endfunction
 
-function! ale_linters#ansible#ansible_lint#GetCommand(buffer, version) abort
-    let l:commands = {
-    \   '>=5.0.0': '%e --parseable-severity -x yaml',
-    \   '<5.0.0': '%e -p %t'
-    \}
-    let l:command = ale#semver#GTE(a:version, [5, 0]) ? l:commands['>=5.0.0'] : l:commands['<5.0.0']
-
-    return l:command
-endfunction
-
 call ale#linter#Define('ansible', {
 \   'name': 'ansible_lint',
 \   'aliases': ['ansible', 'ansible-lint'],
 \   'executable': function('ale_linters#ansible#ansible_lint#GetExecutable'),
-\   'command': {buffer -> ale#semver#RunWithVersionCheck(
-\       buffer,
-\       ale_linters#ansible#ansible_lint#GetExecutable(buffer),
-\       '%e --version',
-\       function('ale_linters#ansible#ansible_lint#GetCommand'),
-\   )},
-\   'callback': {buffer, lines -> ale#semver#RunWithVersionCheck(
-\       buffer,
-\       ale_linters#ansible#ansible_lint#GetExecutable(buffer),
-\       '%e --version',
-\       {buffer, version -> ale_linters#ansible#ansible_lint#Handle(
-\           buffer,
-\           l:version,
-\           lines)},
-\   )},
+\   'command': '%e -p %t',
+\   'callback': 'ale_linters#ansible#ansible_lint#Handle',
 \})

ale_linters/c/cppcheck.vim

@@ -5,13 +5,15 @@ call ale#Set('c_cppcheck_executable', 'cppcheck')
 call ale#Set('c_cppcheck_options', '--enable=style')
 
 function! ale_linters#c#cppcheck#GetCommand(buffer) abort
+    let l:cd_command = ale#handlers#cppcheck#GetCdCommand(a:buffer)
     let l:compile_commands_option = ale#handlers#cppcheck#GetCompileCommandsOptions(a:buffer)
     let l:buffer_path_include = empty(l:compile_commands_option)
     \   ? ale#handlers#cppcheck#GetBufferPathIncludeOptions(a:buffer)
     \   : ''
     let l:template = ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
 
-    return '%e -q --language=c'
+    return l:cd_command
+    \   . '%e -q --language=c'
     \   . l:template
     \   . ale#Pad(l:compile_commands_option)
     \   . ale#Pad(ale#Var(a:buffer, 'c_cppcheck_options'))
@@ -23,7 +25,6 @@ call ale#linter#Define('c', {
 \   'name': 'cppcheck',
 \   'output_stream': 'both',
 \   'executable': {b -> ale#Var(b, 'c_cppcheck_executable')},
-\   'cwd': function('ale#handlers#cppcheck#GetCwd'),
 \   'command': function('ale_linters#c#cppcheck#GetCommand'),
 \   'callback': 'ale#handlers#cppcheck#HandleCppCheckFormat',
 \})

ale_linters/cpp/cppcheck.vim

@@ -5,13 +5,15 @@ call ale#Set('cpp_cppcheck_executable', 'cppcheck')
 call ale#Set('cpp_cppcheck_options', '--enable=style')
 
 function! ale_linters#cpp#cppcheck#GetCommand(buffer) abort
+    let l:cd_command = ale#handlers#cppcheck#GetCdCommand(a:buffer)
     let l:compile_commands_option = ale#handlers#cppcheck#GetCompileCommandsOptions(a:buffer)
     let l:buffer_path_include = empty(l:compile_commands_option)
     \   ? ale#handlers#cppcheck#GetBufferPathIncludeOptions(a:buffer)
     \   : ''
     let l:template = ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
 
-    return '%e -q --language=c++'
+    return l:cd_command
+    \   . '%e -q --language=c++'
     \   . l:template
     \   . ale#Pad(l:compile_commands_option)
     \   . ale#Pad(ale#Var(a:buffer, 'cpp_cppcheck_options'))
@@ -23,7 +25,6 @@ call ale#linter#Define('cpp', {
 \   'name': 'cppcheck',
 \   'output_stream': 'both',
 \   'executable': {b -> ale#Var(b, 'cpp_cppcheck_executable')},
-\   'cwd': function('ale#handlers#cppcheck#GetCwd'),
 \   'command': function('ale_linters#cpp#cppcheck#GetCommand'),
 \   'callback': 'ale#handlers#cppcheck#HandleCppCheckFormat',
 \})

ale_linters/cs/csc.vim

@@ -3,10 +3,14 @@ call ale#Set('cs_csc_source', '')
 call ale#Set('cs_csc_assembly_path', [])
 call ale#Set('cs_csc_assemblies', [])
 
-function! ale_linters#cs#csc#GetCwd(buffer) abort
-    let l:cwd = ale#Var(a:buffer, 'cs_csc_source')
+function! s:GetWorkingDirectory(buffer) abort
+    let l:working_directory = ale#Var(a:buffer, 'cs_csc_source')
 
-    return !empty(l:cwd) ? l:cwd : expand('#' . a:buffer . ':p:h')
+    if !empty(l:working_directory)
+        return l:working_directory
+    endif
+
+    return expand('#' . a:buffer . ':p:h')
 endfunction
 
 function! ale_linters#cs#csc#GetCommand(buffer) abort
@@ -30,7 +34,8 @@ function! ale_linters#cs#csc#GetCommand(buffer) abort
 
     " The code is compiled as a module and the output is redirected to a
     " temporary file.
-    return 'csc /unsafe'
+    return ale#path#CdString(s:GetWorkingDirectory(a:buffer))
+    \    . 'csc /unsafe'
     \    . ale#Pad(ale#Var(a:buffer, 'cs_csc_options'))
     \    . ale#Pad(l:lib_option)
     \    . ale#Pad(l:r_option)
@@ -52,7 +57,8 @@ function! ale_linters#cs#csc#Handle(buffer, lines) abort
     \    '^\v([^ ]+)\s+([Cc][sS][^ ]+):\s+(.+)$',
     \]
     let l:output = []
-    let l:dir = ale_linters#cs#csc#GetCwd(a:buffer)
+
+    let l:dir = s:GetWorkingDirectory(a:buffer)
 
     for l:match in ale#util#GetMatches(a:lines, l:patterns)
         if len(l:match) > 6 && strlen(l:match[5]) > 2 && l:match[5][:1] is? 'CS'
@@ -83,7 +89,6 @@ call ale#linter#Define('cs',{
 \   'name': 'csc',
 \   'output_stream': 'stdout',
 \   'executable': 'csc',
-\   'cwd': function('ale_linters#cs#csc#GetCwd'),
 \   'command': function('ale_linters#cs#csc#GetCommand'),
 \   'callback': 'ale_linters#cs#csc#Handle',
 \   'lint_file': 1

ale_linters/cs/mcsc.vim

@@ -3,10 +3,14 @@ call ale#Set('cs_mcsc_source', '')
 call ale#Set('cs_mcsc_assembly_path', [])
 call ale#Set('cs_mcsc_assemblies', [])
 
-function! ale_linters#cs#mcsc#GetCwd(buffer) abort
-    let l:cwd = ale#Var(a:buffer, 'cs_mcsc_source')
+function! s:GetWorkingDirectory(buffer) abort
+    let l:working_directory = ale#Var(a:buffer, 'cs_mcsc_source')
 
-    return !empty(l:cwd) ? l:cwd : expand('#' . a:buffer . ':p:h')
+    if !empty(l:working_directory)
+        return l:working_directory
+    endif
+
+    return expand('#' . a:buffer . ':p:h')
 endfunction
 
 function! ale_linters#cs#mcsc#GetCommand(buffer) abort
@@ -30,7 +34,8 @@ function! ale_linters#cs#mcsc#GetCommand(buffer) abort
 
     " The code is compiled as a module and the output is redirected to a
     " temporary file.
-    return 'mcs -unsafe'
+    return ale#path#CdString(s:GetWorkingDirectory(a:buffer))
+    \    . 'mcs -unsafe'
     \    . ale#Pad(ale#Var(a:buffer, 'cs_mcsc_options'))
     \    . ale#Pad(l:lib_option)
     \    . ale#Pad(l:r_option)
@@ -53,7 +58,7 @@ function! ale_linters#cs#mcsc#Handle(buffer, lines) abort
     \]
     let l:output = []
 
-    let l:dir = ale_linters#cs#mcsc#GetCwd(a:buffer)
+    let l:dir = s:GetWorkingDirectory(a:buffer)
 
     for l:match in ale#util#GetMatches(a:lines, l:patterns)
         if len(l:match) > 6 && strlen(l:match[5]) > 2 && l:match[5][:1] is? 'CS'
@@ -84,7 +89,6 @@ call ale#linter#Define('cs',{
 \   'name': 'mcsc',
 \   'output_stream': 'stderr',
 \   'executable': 'mcs',
-\   'cwd': function('ale_linters#cs#mcsc#GetCwd'),
 \   'command': function('ale_linters#cs#mcsc#GetCommand'),
 \   'callback': 'ale_linters#cs#mcsc#Handle',
 \   'lint_file': 1

ale_linters/d/dmd.vim

@@ -1,37 +1,35 @@
 " Author: w0rp <devw0rp@gmail.com>
 " Description: "dmd for D files"
 
-function! s:GetDUBCommand(buffer) abort
+function! ale_linters#d#dmd#GetDUBCommand(buffer) abort
     " If we can't run dub, then skip this command.
-    if executable('dub')
+    if !executable('dub')
         " Returning an empty string skips to the DMD command.
-        let l:config = ale#d#FindDUBConfig(a:buffer)
-
-        " To support older dub versions, we just change the directory to the
-        " directory where we found the dub config, and then run `dub describe`
-        " from that directory.
-        if !empty(l:config)
-            return [fnamemodify(l:config, ':h'), 'dub describe --import-paths']
-        endif
+        return ''
     endif
 
-    return ['', '']
+    let l:dub_file = ale#d#FindDUBConfig(a:buffer)
+
+    if empty(l:dub_file)
+        return ''
+    endif
+
+    " To support older dub versions, we just change the directory to
+    " the directory where we found the dub config, and then run `dub describe`
+    " from that directory.
+    return 'cd ' . ale#Escape(fnamemodify(l:dub_file, ':h'))
+    \   . ' && dub describe --import-paths'
 endfunction
 
 function! ale_linters#d#dmd#RunDUBCommand(buffer) abort
-    let [l:cwd, l:command] = s:GetDUBCommand(a:buffer)
+    let l:command = ale_linters#d#dmd#GetDUBCommand(a:buffer)
 
     if empty(l:command)
         " If we can't run DUB, just run DMD.
         return ale_linters#d#dmd#DMDCommand(a:buffer, [], {})
     endif
 
-    return ale#command#Run(
-    \   a:buffer,
-    \   l:command,
-    \   function('ale_linters#d#dmd#DMDCommand'),
-    \   {'cwd': l:cwd},
-    \)
+    return ale#command#Run(a:buffer, l:command, function('ale_linters#d#dmd#DMDCommand'))
 endfunction
 
 function! ale_linters#d#dmd#DMDCommand(buffer, dub_output, meta) abort

ale_linters/elixir/credo.vim

@@ -56,7 +56,11 @@ function! ale_linters#elixir#credo#GetConfigFile() abort
 endfunction
 
 function! ale_linters#elixir#credo#GetCommand(buffer) abort
-    return 'mix help credo && '
+    let l:project_root = ale#handlers#elixir#FindMixUmbrellaRoot(a:buffer)
+    let l:mode = ale_linters#elixir#credo#GetMode()
+
+    return ale#path#CdString(l:project_root)
+    \ . 'mix help credo && '
     \ . 'mix credo ' . ale_linters#elixir#credo#GetMode()
     \ . ale_linters#elixir#credo#GetConfigFile()
     \ . ' --format=flycheck --read-from-stdin %s'
@@ -65,7 +69,6 @@ endfunction
 call ale#linter#Define('elixir', {
 \   'name': 'credo',
 \   'executable': 'mix',
-\   'cwd': function('ale#handlers#elixir#FindMixUmbrellaRoot'),
 \   'command': function('ale_linters#elixir#credo#GetCommand'),
 \   'callback': 'ale_linters#elixir#credo#Handle',
 \})

ale_linters/elixir/dialyxir.vim

@@ -25,10 +25,17 @@ function! ale_linters#elixir#dialyxir#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#elixir#dialyxir#GetCommand(buffer) abort
+    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
+
+    return ale#path#CdString(l:project_root)
+    \ . ' mix help dialyzer && mix dialyzer'
+endfunction
+
 call ale#linter#Define('elixir', {
 \   'name': 'dialyxir',
 \   'executable': 'mix',
-\   'cwd': function('ale#handlers#elixir#FindMixProjectRoot'),
-\   'command': 'mix help dialyzer && mix dialyzer',
+\   'command': function('ale_linters#elixir#dialyxir#GetCommand'),
 \   'callback': 'ale_linters#elixir#dialyxir#Handle',
 \})
+

ale_linters/elixir/dogma.vim

@@ -29,11 +29,17 @@ function! ale_linters#elixir#dogma#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#elixir#dogma#GetCommand(buffer) abort
+    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
+
+    return ale#path#CdString(l:project_root)
+    \ . ' mix help dogma && mix dogma %s --format=flycheck'
+endfunction
+
 call ale#linter#Define('elixir', {
 \   'name': 'dogma',
 \   'executable': 'mix',
-\   'cwd': function('ale#handlers#elixir#FindMixProjectRoot'),
-\   'command': 'mix help dogma && mix dogma %s --format=flycheck',
+\   'command': function('ale_linters#elixir#dogma#GetCommand'),
 \   'lint_file': 1,
 \   'callback': 'ale_linters#elixir#dogma#Handle',
 \})

ale_linters/elixir/mix.vim

@@ -30,15 +30,22 @@ function! ale_linters#elixir#mix#Handle(buffer, lines) abort
 endfunction
 
 function! ale_linters#elixir#mix#GetCommand(buffer) abort
+    let l:project_root = ale#handlers#elixir#FindMixProjectRoot(a:buffer)
+
     let l:temp_dir = ale#command#CreateDirectory(a:buffer)
 
-    return ale#Env('MIX_BUILD_PATH', l:temp_dir) . 'mix compile %s'
+    let l:mix_build_path = has('win32')
+    \   ? 'set MIX_BUILD_PATH=' . ale#Escape(l:temp_dir) . ' &&'
+    \   : 'MIX_BUILD_PATH=' . ale#Escape(l:temp_dir)
+
+    return ale#path#CdString(l:project_root)
+    \ . l:mix_build_path
+    \ . ' mix compile %s'
 endfunction
 
 call ale#linter#Define('elixir', {
 \   'name': 'mix',
 \   'executable': 'mix',
-\   'cwd': function('ale#handlers#elixir#FindMixProjectRoot'),
 \   'command': function('ale_linters#elixir#mix#GetCommand'),
 \   'callback': 'ale_linters#elixir#mix#Handle',
 \   'lint_file': 1,

ale_linters/elm/make.vim

@@ -186,19 +186,20 @@ function! ale_linters#elm#make#IsTest(buffer) abort
     endif
 endfunction
 
-function! ale_linters#elm#make#GetCwd(buffer) abort
-    let l:root_dir = ale_linters#elm#make#GetRootDir(a:buffer)
-
-    return !empty(l:root_dir) ? l:root_dir : ''
-endfunction
-
 " Return the command to execute the linter in the projects directory.
 " If it doesn't, then this will fail when imports are needed.
 function! ale_linters#elm#make#GetCommand(buffer) abort
     let l:executable = ale_linters#elm#make#GetExecutable(a:buffer)
+    let l:root_dir = ale_linters#elm#make#GetRootDir(a:buffer)
     let l:is_v19 = ale_linters#elm#make#IsVersionGte19(a:buffer)
     let l:is_using_elm_test = l:executable =~# 'elm-test$'
 
+    if empty(l:root_dir)
+        let l:dir_set_cmd = ''
+    else
+        let l:dir_set_cmd = 'cd ' . ale#Escape(l:root_dir) . ' && '
+    endif
+
     " elm-test needs to know the path of elm-make if elm isn't installed globally.
     " https://github.com/rtfeldman/node-test-runner/blob/57728f10668f2d2ab3179e7e3208bcfa9a1f19aa/README.md#--compiler
     if l:is_v19 && l:is_using_elm_test
@@ -212,9 +213,7 @@ function! ale_linters#elm#make#GetCommand(buffer) abort
     " a sort of flag to tell the compiler not to generate an output file,
     " which is why this is hard coded here.
     " Source: https://github.com/elm-lang/elm-compiler/blob/19d5a769b30ec0b2fc4475985abb4cd94cd1d6c3/builder/src/Generate/Output.hs#L253
-    return '%e make --report=json --output=/dev/null'
-    \   . l:elm_test_compiler_flag
-    \   . '%t'
+    return l:dir_set_cmd . '%e make --report=json --output=/dev/null' . l:elm_test_compiler_flag . '%t'
 endfunction
 
 function! ale_linters#elm#make#GetExecutable(buffer) abort
@@ -236,7 +235,6 @@ call ale#linter#Define('elm', {
 \   'name': 'make',
 \   'executable': function('ale_linters#elm#make#GetExecutable'),
 \   'output_stream': 'both',
-\   'cwd': function('ale_linters#elm#make#GetCwd'),
 \   'command': function('ale_linters#elm#make#GetCommand'),
 \   'callback': 'ale_linters#elm#make#Handle'
 \})

ale_linters/go/gobuild.vim

@@ -10,7 +10,8 @@ function! ale_linters#go#gobuild#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'go_gobuild_options')
 
     " Run go test in local directory with relative path
-    return ale#go#EnvString(a:buffer)
+    return ale#path#BufferCdString(a:buffer)
+    \   . ale#go#EnvString(a:buffer)
     \   . ale#Var(a:buffer, 'go_go_executable') . ' test'
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . ' -c -o /dev/null ./'
@@ -49,7 +50,6 @@ call ale#linter#Define('go', {
 \   'name': 'gobuild',
 \   'aliases': ['go build'],
 \   'executable': {b -> ale#Var(b, 'go_go_executable')},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#go#gobuild#GetCommand'),
 \   'output_stream': 'stderr',
 \   'callback': 'ale_linters#go#gobuild#Handler',

ale_linters/go/golangci_lint.vim

@@ -12,12 +12,14 @@ function! ale_linters#go#golangci_lint#GetCommand(buffer) abort
 
 
     if l:lint_package
-        return ale#go#EnvString(a:buffer)
+        return ale#path#BufferCdString(a:buffer)
+        \   . ale#go#EnvString(a:buffer)
         \   . '%e run '
         \   .  l:options
     endif
 
-    return ale#go#EnvString(a:buffer)
+    return ale#path#BufferCdString(a:buffer)
+    \   . ale#go#EnvString(a:buffer)
     \   . '%e run '
     \   . ale#Escape(l:filename)
     \   . ' ' . l:options
@@ -51,7 +53,6 @@ endfunction
 call ale#linter#Define('go', {
 \   'name': 'golangci-lint',
 \   'executable': {b -> ale#Var(b, 'go_golangci_lint_executable')},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#go#golangci_lint#GetCommand'),
 \   'callback': 'ale_linters#go#golangci_lint#Handler',
 \   'lint_file': 1,

ale_linters/go/gometalinter.vim

@@ -13,12 +13,14 @@ function! ale_linters#go#gometalinter#GetCommand(buffer) abort
     " BufferCdString is used so that we can be sure the paths output from gometalinter can
     " be calculated to absolute paths in the Handler
     if l:lint_package
-        return ale#go#EnvString(a:buffer)
+        return ale#path#BufferCdString(a:buffer)
+        \   . ale#go#EnvString(a:buffer)
         \   . '%e'
         \   . (!empty(l:options) ? ' ' . l:options : '') . ' .'
     endif
 
-    return ale#go#EnvString(a:buffer)
+    return ale#path#BufferCdString(a:buffer)
+    \   . ale#go#EnvString(a:buffer)
     \   . '%e'
     \   . ' --include=' . ale#Escape(ale#util#EscapePCRE(l:filename))
     \   . (!empty(l:options) ? ' ' . l:options : '') . ' .'
@@ -51,7 +53,6 @@ endfunction
 call ale#linter#Define('go', {
 \   'name': 'gometalinter',
 \   'executable': {b -> ale#Var(b, 'go_gometalinter_executable')},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#go#gometalinter#GetCommand'),
 \   'callback': 'ale_linters#go#gometalinter#Handler',
 \   'lint_file': 1,

ale_linters/go/gosimple.vim

@@ -1,11 +1,15 @@
 " Author: Ben Reedy <https://github.com/breed808>
 " Description: gosimple for Go files
 
+function! ale_linters#go#gosimple#GetCommand(buffer) abort
+    return ale#path#BufferCdString(a:buffer) . ' '
+    \   . ale#go#EnvString(a:buffer) . 'gosimple .'
+endfunction
+
 call ale#linter#Define('go', {
 \   'name': 'gosimple',
 \   'executable': 'gosimple',
-\   'cwd': '%s:h',
-\   'command': {b -> ale#go#EnvString(b) . 'gosimple .'},
+\   'command': function('ale_linters#go#gosimple#GetCommand'),
 \   'callback': 'ale#handlers#go#Handler',
 \   'output_stream': 'both',
 \   'lint_file': 1,

ale_linters/go/gotype.vim

@@ -1,23 +1,19 @@
 " Author: Jelte Fennema <github-public@jeltef.nl>
 " Description: gotype for Go files
 
-function! ale_linters#go#gotype#GetExecutable(buffer) abort
+function! ale_linters#go#gotype#GetCommand(buffer) abort
     if expand('#' . a:buffer . ':p') =~# '_test\.go$'
         return ''
     endif
 
-    return 'gotype'
-endfunction
-
-function! ale_linters#go#gotype#GetCommand(buffer) abort
-    return ale#go#EnvString(a:buffer) . 'gotype -e .'
+    return ale#path#BufferCdString(a:buffer) . ' '
+    \   . ale#go#EnvString(a:buffer) . 'gotype -e .'
 endfunction
 
 call ale#linter#Define('go', {
 \   'name': 'gotype',
 \   'output_stream': 'stderr',
-\   'executable': function('ale_linters#go#gotype#GetExecutable'),
-\   'cwd': '%s:h',
+\   'executable': 'gotype',
 \   'command': function('ale_linters#go#gotype#GetCommand'),
 \   'callback': 'ale#handlers#go#Handler',
 \   'lint_file': 1,

ale_linters/go/govet.vim

@@ -10,7 +10,8 @@ call ale#Set('go_govet_options', '')
 function! ale_linters#go#govet#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'go_govet_options')
 
-    return ale#go#EnvString(a:buffer)
+    return ale#path#BufferCdString(a:buffer) . ' '
+    \   . ale#go#EnvString(a:buffer)
     \   . ale#Var(a:buffer, 'go_go_executable') . ' vet '
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . ' .'
@@ -21,7 +22,6 @@ call ale#linter#Define('go', {
 \   'aliases': ['go vet'],
 \   'output_stream': 'stderr',
 \   'executable': {b -> ale#Var(b, 'go_go_executable')},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#go#govet#GetCommand'),
 \   'callback': 'ale#handlers#go#Handler',
 \   'lint_file': 1,

ale_linters/go/staticcheck.vim

@@ -5,24 +5,28 @@ call ale#Set('go_staticcheck_options', '')
 call ale#Set('go_staticcheck_lint_package', 0)
 
 function! ale_linters#go#staticcheck#GetCommand(buffer) abort
+    let l:filename = expand('#' . a:buffer . ':t')
     let l:options = ale#Var(a:buffer, 'go_staticcheck_options')
     let l:lint_package = ale#Var(a:buffer, 'go_staticcheck_lint_package')
     let l:env = ale#go#EnvString(a:buffer)
 
+    " BufferCdString is used so that we can be sure the paths output from
+    " staticcheck can be calculated to absolute paths in the Handler
     if l:lint_package
-        return l:env . 'staticcheck'
+        return ale#path#BufferCdString(a:buffer)
+        \   . l:env . 'staticcheck'
         \   . (!empty(l:options) ? ' ' . l:options : '') . ' .'
     endif
 
-    return l:env . 'staticcheck'
+    return ale#path#BufferCdString(a:buffer)
+    \   . l:env . 'staticcheck'
     \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' %s:t'
+    \   . ' ' . ale#Escape(l:filename)
 endfunction
 
 call ale#linter#Define('go', {
 \   'name': 'staticcheck',
 \   'executable': 'staticcheck',
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#go#staticcheck#GetCommand'),
 \   'callback': 'ale#handlers#go#Handler',
 \   'output_stream': 'both',

ale_linters/graphql/eslint.vim

@@ -4,7 +4,6 @@
 call ale#linter#Define('graphql', {
 \   'name': 'eslint',
 \   'executable': function('ale#handlers#eslint#GetExecutable'),
-\   'cwd': function('ale#handlers#eslint#GetCwd'),
 \   'command': function('ale#handlers#eslint#GetCommand'),
 \   'callback': 'ale#handlers#eslint#HandleJSON',
 \})

ale_linters/graphql/gqlint.vim

@@ -1,10 +1,15 @@
 " Author: Michiel Westerbeek <happylinks@gmail.com>
 " Description: Linter for GraphQL Schemas
 
+function! ale_linters#graphql#gqlint#GetCommand(buffer) abort
+    return ale#path#BufferCdString(a:buffer)
+    \   . 'gqlint'
+    \   . ' --reporter=simple %t'
+endfunction
+
 call ale#linter#Define('graphql', {
 \   'name': 'gqlint',
 \   'executable': 'gqlint',
-\   'cwd': '%s:h',
-\   'command': 'gqlint --reporter=simple %t',
+\   'command': function('ale_linters#graphql#gqlint#GetCommand'),
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/haskell/cabal_ghc.vim

@@ -4,7 +4,8 @@
 call ale#Set('haskell_cabal_ghc_options', '-fno-code -v0')
 
 function! ale_linters#haskell#cabal_ghc#GetCommand(buffer) abort
-    return 'cabal exec -- ghc '
+    return ale#path#BufferCdString(a:buffer)
+    \   . 'cabal exec -- ghc '
     \   . ale#Var(a:buffer, 'haskell_cabal_ghc_options')
     \   . ' %t'
 endfunction
@@ -14,7 +15,6 @@ call ale#linter#Define('haskell', {
 \   'aliases': ['cabal-ghc'],
 \   'output_stream': 'stderr',
 \   'executable': 'cabal',
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#haskell#cabal_ghc#GetCommand'),
 \   'callback': 'ale#handlers#haskell#HandleGHCFormat',
 \})

ale_linters/haskell/stack_ghc.vim

@@ -4,7 +4,8 @@
 call ale#Set('haskell_stack_ghc_options', '-fno-code -v0')
 
 function! ale_linters#haskell#stack_ghc#GetCommand(buffer) abort
-    return ale#handlers#haskell#GetStackExecutable(a:buffer)
+    return ale#path#BufferCdString(a:buffer)
+    \ . ale#handlers#haskell#GetStackExecutable(a:buffer)
     \ . ' ghc -- '
     \ . ale#Var(a:buffer, 'haskell_stack_ghc_options')
     \ . ' %t'
@@ -15,7 +16,6 @@ call ale#linter#Define('haskell', {
 \   'aliases': ['stack-ghc'],
 \   'output_stream': 'stderr',
 \   'executable': function('ale#handlers#haskell#GetStackExecutable'),
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#haskell#stack_ghc#GetCommand'),
 \   'callback': 'ale#handlers#haskell#HandleGHCFormat',
 \})

ale_linters/java/javac.vim

@@ -9,16 +9,16 @@ call ale#Set('java_javac_classpath', '')
 call ale#Set('java_javac_sourcepath', '')
 
 function! ale_linters#java#javac#RunWithImportPaths(buffer) abort
-    let [l:cwd, l:command] = ale#maven#BuildClasspathCommand(a:buffer)
+    let l:command = ale#maven#BuildClasspathCommand(a:buffer)
 
     " Try to use Gradle if Maven isn't available.
     if empty(l:command)
-        let [l:cwd, l:command] = ale#gradle#BuildClasspathCommand(a:buffer)
+        let l:command = ale#gradle#BuildClasspathCommand(a:buffer)
     endif
 
     " Try to use Ant if Gradle and Maven aren't available
     if empty(l:command)
-        let [l:cwd, l:command] = ale#ant#BuildClasspathCommand(a:buffer)
+        let l:command = ale#ant#BuildClasspathCommand(a:buffer)
     endif
 
     if empty(l:command)
@@ -28,8 +28,7 @@ function! ale_linters#java#javac#RunWithImportPaths(buffer) abort
     return ale#command#Run(
     \   a:buffer,
     \   l:command,
-    \   function('ale_linters#java#javac#GetCommand'),
-    \   {'cwd': l:cwd},
+    \   function('ale_linters#java#javac#GetCommand')
     \)
 endfunction
 
@@ -111,7 +110,8 @@ function! ale_linters#java#javac#GetCommand(buffer, import_paths, meta) abort
 
     " Always run javac from the directory the file is in, so we can resolve
     " relative paths correctly.
-    return '%e -Xlint'
+    return ale#path#BufferCdString(a:buffer)
+    \ . '%e -Xlint'
     \ . ale#Pad(l:cp_option)
     \ . ale#Pad(l:sp_option)
     \ . ' -d ' . ale#Escape(l:class_file_directory)
@@ -154,7 +154,6 @@ endfunction
 call ale#linter#Define('java', {
 \   'name': 'javac',
 \   'executable': {b -> ale#Var(b, 'java_javac_executable')},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#java#javac#RunWithImportPaths'),
 \   'output_stream': 'stderr',
 \   'callback': 'ale_linters#java#javac#Handle',

ale_linters/javascript/eslint.vim

@@ -5,7 +5,6 @@ call ale#linter#Define('javascript', {
 \   'name': 'eslint',
 \   'output_stream': 'both',
 \   'executable': function('ale#handlers#eslint#GetExecutable'),
-\   'cwd': function('ale#handlers#eslint#GetCwd'),
 \   'command': function('ale#handlers#eslint#GetCommand'),
 \   'callback': 'ale#handlers#eslint#HandleJSON',
 \})

ale_linters/kotlin/kotlinc.vim

@@ -15,15 +15,20 @@ function! ale_linters#kotlin#kotlinc#RunWithImportPaths(buffer) abort
     let l:command = ''
 
     " exec maven/gradle only if classpath is not set
-    if !empty(ale#Var(a:buffer, 'kotlin_kotlinc_classpath'))
+    if ale#Var(a:buffer, 'kotlin_kotlinc_classpath') isnot# ''
         return ale_linters#kotlin#kotlinc#GetCommand(a:buffer, [], {})
     endif
 
-    let [l:cwd, l:command] = ale#maven#BuildClasspathCommand(a:buffer)
+    let l:pom_path = ale#path#FindNearestFile(a:buffer, 'pom.xml')
+
+    if !empty(l:pom_path) && executable('mvn')
+        let l:command = ale#path#CdString(fnamemodify(l:pom_path, ':h'))
+        \   . 'mvn dependency:build-classpath'
+    endif
 
     " Try to use Gradle if Maven isn't available.
     if empty(l:command)
-        let [l:cwd, l:command] = ale#gradle#BuildClasspathCommand(a:buffer)
+        let l:command = ale#gradle#BuildClasspathCommand(a:buffer)
     endif
 
     if empty(l:command)
@@ -33,8 +38,7 @@ function! ale_linters#kotlin#kotlinc#RunWithImportPaths(buffer) abort
     return ale#command#Run(
     \   a:buffer,
     \   l:command,
-    \   function('ale_linters#kotlin#kotlinc#GetCommand'),
-    \   {'cwd': l:cwd},
+    \   function('ale_linters#kotlin#kotlinc#GetCommand')
     \)
 endfunction
 

ale_linters/markdown/vale.vim

@@ -1,24 +1,9 @@
 " Author: chew-z https://github.com/chew-z
 " Description: vale for Markdown files
 
-call ale#Set('markdown_vale_executable', 'vale')
-call ale#Set('markdown_vale_input_file', '%t')
-call ale#Set('markdown_vale_options', '')
-
-function! ale_linters#markdown#vale#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'markdown_vale_executable')
-    let l:input_file = ale#Var(a:buffer, 'markdown_vale_input_file')
-
-    " Defaults to `vale --output=JSON %t`
-    return ale#Escape(l:executable)
-    \   . ' --output=JSON '
-    \   . ale#Var(a:buffer, 'markdown_vale_options')
-    \   . ' ' . l:input_file
-endfunction
-
 call ale#linter#Define('markdown', {
 \   'name': 'vale',
-\   'executable': {b -> ale#Var(b, 'markdown_vale_executable')},
-\   'command': function('ale_linters#markdown#vale#GetCommand'),
+\   'executable': 'vale',
+\   'command': 'vale --output=JSON %t',
 \   'callback': 'ale#handlers#vale#Handle',
 \})

ale_linters/mercury/mmc.vim

@@ -5,9 +5,12 @@ call ale#Set('mercury_mmc_executable', 'mmc')
 call ale#Set('mercury_mmc_options', '--make --output-compile-error-lines 100')
 
 function! ale_linters#mercury#mmc#GetCommand(buffer) abort
-    return '%e --errorcheck-only '
+    let l:module_name = expand('#' . a:buffer . ':t:r')
+
+    return ale#path#BufferCdString(a:buffer)
+    \ . '%e --errorcheck-only '
     \ . ale#Var(a:buffer, 'mercury_mmc_options')
-    \ . ' %s:t:r'
+    \ . ' ' . l:module_name
 endfunction
 
 function! ale_linters#mercury#mmc#Handle(buffer, lines) abort
@@ -31,7 +34,6 @@ call ale#linter#Define('mercury', {
 \   'name': 'mmc',
 \   'output_stream': 'stderr',
 \   'executable': {b -> ale#Var(b, 'mercury_mmc_executable')},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#mercury#mmc#GetCommand'),
 \   'callback': 'ale_linters#mercury#mmc#Handle',
 \   'lint_file': 1,

ale_linters/ocaml/ocamllsp.vim

@@ -1,13 +0,0 @@
-" Author: Risto Stevcev <me@risto.codes>
-" Description: The official language server for OCaml
-
-call ale#Set('ocaml_ocamllsp_use_opam', 1)
-
-call ale#linter#Define('ocaml', {
-\   'name': 'ocamllsp',
-\   'lsp': 'stdio',
-\   'executable': function('ale#handlers#ocamllsp#GetExecutable'),
-\   'command': function('ale#handlers#ocamllsp#GetCommand'),
-\   'language': function('ale#handlers#ocamllsp#GetLanguage'),
-\   'project_root': function('ale#handlers#ocamllsp#GetProjectRoot'),
-\})

ale_linters/php/phpcs.vim

@@ -13,7 +13,8 @@ function! ale_linters#php#phpcs#GetCommand(buffer) abort
     \   ? '--standard=' . ale#Escape(l:standard)
     \   : ''
 
-    return '%e -s --report=emacs --stdin-path=%s'
+    return ale#path#BufferCdString(a:buffer)
+    \   . '%e -s --report=emacs --stdin-path=%s'
     \   . ale#Pad(l:standard_option)
     \   . ale#Pad(ale#Var(a:buffer, 'php_phpcs_options'))
 endfunction
@@ -48,7 +49,6 @@ call ale#linter#Define('php', {
 \       'vendor/bin/phpcs',
 \       'phpcs'
 \   ])},
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#php#phpcs#GetCommand'),
 \   'callback': 'ale_linters#php#phpcs#Handle',
 \})

ale_linters/python/flake8.vim

@@ -38,28 +38,30 @@ function! ale_linters#python#flake8#RunWithVersionCheck(buffer) abort
     \)
 endfunction
 
-function! ale_linters#python#flake8#GetCwd(buffer) abort
+function! ale_linters#python#flake8#GetCdString(buffer) abort
     let l:change_directory = ale#Var(a:buffer, 'python_flake8_change_directory')
-    let l:cwd = ''
+    let l:cd_string = ''
 
     if l:change_directory is# 'project'
         let l:project_root = ale#python#FindProjectRootIni(a:buffer)
 
         if !empty(l:project_root)
-            let l:cwd = l:project_root
+            let l:cd_string = ale#path#CdString(l:project_root)
         endif
     endif
 
-    if (l:change_directory is# 'project' && empty(l:cwd))
+    if (l:change_directory is# 'project' && empty(l:cd_string))
     \|| l:change_directory is# 1
     \|| l:change_directory is# 'file'
-        let l:cwd = '%s:h'
+        let l:cd_string = ale#path#BufferCdString(a:buffer)
     endif
 
-    return l:cwd
+    return l:cd_string
 endfunction
 
 function! ale_linters#python#flake8#GetCommand(buffer, version) abort
+    let l:cd_string = ale_linters#python#flake8#GetCdString(a:buffer)
+
     let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
 
     let l:exec_args = l:executable =~? 'pipenv$'
@@ -74,7 +76,8 @@ function! ale_linters#python#flake8#GetCommand(buffer, version) abort
 
     let l:options = ale#Var(a:buffer, 'python_flake8_options')
 
-    return ale#Escape(l:executable) . l:exec_args
+    return l:cd_string
+    \   . ale#Escape(l:executable) . l:exec_args
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . ' --format=default'
     \   . l:display_name_args . ' -'
@@ -158,7 +161,6 @@ endfunction
 call ale#linter#Define('python', {
 \   'name': 'flake8',
 \   'executable': function('ale_linters#python#flake8#GetExecutable'),
-\   'cwd': function('ale_linters#python#flake8#GetCwd'),
 \   'command': function('ale_linters#python#flake8#RunWithVersionCheck'),
 \   'callback': 'ale_linters#python#flake8#Handle',
 \})

ale_linters/python/mypy.vim

@@ -18,7 +18,7 @@ function! ale_linters#python#mypy#GetExecutable(buffer) abort
 endfunction
 
 " The directory to change to before running mypy
-function! ale_linters#python#mypy#GetCwd(buffer) abort
+function! s:GetDir(buffer) abort
     " If we find a directory with "mypy.ini" in it use that,
     " else try and find the "python project" root, or failing
     " that, run from the same folder as the current file
@@ -36,19 +36,24 @@ function! ale_linters#python#mypy#GetCwd(buffer) abort
 endfunction
 
 function! ale_linters#python#mypy#GetCommand(buffer) abort
+    let l:dir = s:GetDir(a:buffer)
     let l:executable = ale_linters#python#mypy#GetExecutable(a:buffer)
+
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run mypy'
     \   : ''
 
-    return '%e' . l:exec_args
-    \   . ale#Pad(ale#Var(a:buffer, 'python_mypy_options'))
-    \   . ' --show-column-numbers'
+    " We have to always switch to an explicit directory for a command so
+    " we can know with certainty the base path for the 'filename' keys below.
+    return ale#path#CdString(l:dir)
+    \   . ale#Escape(l:executable) . l:exec_args
+    \   . ' --show-column-numbers '
+    \   . ale#Var(a:buffer, 'python_mypy_options')
     \   . ' --shadow-file %s %t %s'
 endfunction
 
 function! ale_linters#python#mypy#Handle(buffer, lines) abort
-    let l:dir = ale_linters#python#mypy#GetCwd(a:buffer)
+    let l:dir = s:GetDir(a:buffer)
     " Look for lines like the following:
     "
     " file.py:4: error: No library stub file for module 'django.db'
@@ -90,7 +95,6 @@ endfunction
 call ale#linter#Define('python', {
 \   'name': 'mypy',
 \   'executable': function('ale_linters#python#mypy#GetExecutable'),
-\   'cwd': function('ale_linters#python#mypy#GetCwd'),
 \   'command': function('ale_linters#python#mypy#GetCommand'),
 \   'callback': 'ale_linters#python#mypy#Handle',
 \   'output_stream': 'both'

ale_linters/python/pydocstyle.vim

@@ -21,7 +21,8 @@ function! ale_linters#python#pydocstyle#GetCommand(buffer) abort
     \   ? ' run pydocstyle'
     \   : ''
 
-    return ale#Escape(l:executable) . l:exec_args
+    return ale#path#BufferCdString(a:buffer)
+    \   . ale#Escape(l:executable) . l:exec_args
     \   . ale#Pad(ale#Var(a:buffer, 'python_pydocstyle_options'))
     \   . ' %s:t'
 endfunction
@@ -65,7 +66,6 @@ endfunction
 call ale#linter#Define('python', {
 \   'name': 'pydocstyle',
 \   'executable': function('ale_linters#python#pydocstyle#GetExecutable'),
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#python#pydocstyle#GetCommand'),
 \   'callback': 'ale_linters#python#pydocstyle#Handle',
 \})

ale_linters/python/pylama.vim

@@ -16,20 +16,19 @@ function! ale_linters#python#pylama#GetExecutable(buffer) abort
     return ale#python#FindExecutable(a:buffer, 'python_pylama', ['pylama'])
 endfunction
 
-function! ale_linters#python#pylama#GetCwd(buffer) abort
+function! ale_linters#python#pylama#GetCommand(buffer) abort
+    let l:cd_string = ''
+
     if ale#Var(a:buffer, 'python_pylama_change_directory')
         " Pylama loads its configuration from the current directory only, and
         " applies file masks using paths relative to the current directory.
         " Run from project root, if found, otherwise buffer dir.
         let l:project_root = ale#python#FindProjectRoot(a:buffer)
-
-        return !empty(l:project_root) ? l:project_root : '%s:h'
+        let l:cd_string = l:project_root isnot# ''
+        \   ? ale#path#CdString(l:project_root)
+        \   : ale#path#BufferCdString(a:buffer)
     endif
 
-    return ''
-endfunction
-
-function! ale_linters#python#pylama#GetCommand(buffer) abort
     let l:executable = ale_linters#python#pylama#GetExecutable(a:buffer)
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run pylama'
@@ -38,7 +37,8 @@ function! ale_linters#python#pylama#GetCommand(buffer) abort
     " Note: Using %t to lint changes would be preferable, but many pylama
     " checks use surrounding paths (e.g. C0103 module name, E0402 relative
     " import beyond top, etc.).  Neither is ideal.
-    return ale#Escape(l:executable) . l:exec_args
+    return l:cd_string
+    \   . ale#Escape(l:executable) . l:exec_args
     \   . ale#Pad(ale#Var(a:buffer, 'python_pylama_options'))
     \   . ' %s'
 endfunction
@@ -86,7 +86,6 @@ endfunction
 call ale#linter#Define('python', {
 \   'name': 'pylama',
 \   'executable': function('ale_linters#python#pylama#GetExecutable'),
-\   'cwd': function('ale_linters#python#pylama#GetCwd'),
 \   'command': function('ale_linters#python#pylama#GetCommand'),
 \   'callback': 'ale_linters#python#pylama#Handle',
 \   'lint_file': 1,

ale_linters/python/pylint.vim

@@ -17,26 +17,27 @@ function! ale_linters#python#pylint#GetExecutable(buffer) abort
     return ale#python#FindExecutable(a:buffer, 'python_pylint', ['pylint'])
 endfunction
 
-function! ale_linters#python#pylint#GetCwd(buffer) abort
+function! ale_linters#python#pylint#GetCommand(buffer, version) abort
+    let l:cd_string = ''
+
     if ale#Var(a:buffer, 'python_pylint_change_directory')
         " pylint only checks for pylintrc in the packages above its current
         " directory before falling back to user and global pylintrc.
         " Run from project root, if found, otherwise buffer dir.
         let l:project_root = ale#python#FindProjectRoot(a:buffer)
-
-        return !empty(l:project_root) ? l:project_root : '%s:h'
+        let l:cd_string = l:project_root isnot# ''
+        \   ? ale#path#CdString(l:project_root)
+        \   : ale#path#BufferCdString(a:buffer)
     endif
 
-    return ''
-endfunction
-
-function! ale_linters#python#pylint#GetCommand(buffer, version) abort
     let l:executable = ale_linters#python#pylint#GetExecutable(a:buffer)
+
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run pylint'
     \   : ''
 
-    return ale#Escape(l:executable) . l:exec_args
+    return l:cd_string
+    \   . ale#Escape(l:executable) . l:exec_args
     \   . ale#Pad(ale#Var(a:buffer, 'python_pylint_options'))
     \   . ' --output-format text --msg-template="{path}:{line}:{column}: {msg_id} ({symbol}) {msg}" --reports n'
     \   .  (ale#semver#GTE(a:version, [2, 4, 0]) ? ' --from-stdin' : '')
@@ -103,7 +104,6 @@ call ale#linter#Define('python', {
 \       '%e --version',
 \       {buffer, version -> !ale#semver#GTE(version, [2, 4, 0])},
 \   )},
-\   'cwd': function('ale_linters#python#pylint#GetCwd'),
 \   'command': {buffer -> ale#semver#RunWithVersionCheck(
 \       buffer,
 \       ale#Var(buffer, 'python_pylint_executable'),

ale_linters/python/vulture.vim

@@ -6,6 +6,7 @@ call ale#Set('python_vulture_options', '')
 call ale#Set('python_vulture_use_global', get(g:, 'ale_use_global_executables', 0))
 call ale#Set('python_vulture_change_directory', 1)
 
+
 " The directory to change to before running vulture
 function! s:GetDir(buffer) abort
     let l:project_root = ale#python#FindProjectRoot(a:buffer)
@@ -15,28 +16,29 @@ function! s:GetDir(buffer) abort
     \   : expand('#' . a:buffer . ':p:h')
 endfunction
 
+
 function! ale_linters#python#vulture#GetExecutable(buffer) abort
     return ale#python#FindExecutable(a:buffer, 'python_vulture', ['vulture'])
 endfunction
 
-function! ale_linters#python#vulture#GetCwd(buffer) abort
-    if !ale#Var(a:buffer, 'python_vulture_change_directory')
-        return ''
-    endif
-
-    return s:GetDir(a:buffer)
-endfunction
 
 function! ale_linters#python#vulture#GetCommand(buffer) abort
+    let l:change_dir = ale#Var(a:buffer, 'python_vulture_change_directory')
+    \   ? ale#path#CdString(s:GetDir(a:buffer))
+    \   : ''
+
     let l:executable = ale_linters#python#vulture#GetExecutable(a:buffer)
+
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run vulture'
     \   : ''
+
     let l:lint_dest = ale#Var(a:buffer, 'python_vulture_change_directory')
     \   ? ' .'
     \   : ' %s'
 
-    return ale#Escape(l:executable) . l:exec_args
+    return l:change_dir
+    \   . ale#Escape(l:executable) . l:exec_args
     \   . ' '
     \   . ale#Var(a:buffer, 'python_vulture_options')
     \   . l:lint_dest
@@ -72,7 +74,6 @@ endfunction
 call ale#linter#Define('python', {
 \   'name': 'vulture',
 \   'executable': function('ale_linters#python#vulture#GetExecutable'),
-\   'cwd': function('ale_linters#python#vulture#GetCwd'),
 \   'command': function('ale_linters#python#vulture#GetCommand'),
 \   'callback': 'ale_linters#python#vulture#Handle',
 \   'lint_file': 1,

ale_linters/r/lintr.vim

@@ -21,13 +21,14 @@ function! ale_linters#r#lintr#GetCommand(buffer) abort
     let l:cmd_string = 'suppressPackageStartupMessages(library(lintr));'
     \   . l:lint_cmd
 
-    return 'Rscript --vanilla -e ' . ale#Escape(l:cmd_string) . ' %t'
+    return ale#path#BufferCdString(a:buffer)
+    \   . 'Rscript --vanilla -e '
+    \   . ale#Escape(l:cmd_string) . ' %t'
 endfunction
 
 call ale#linter#Define('r', {
 \   'name': 'lintr',
 \   'executable': 'Rscript',
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#r#lintr#GetCommand'),
 \   'callback': 'ale#handlers#gcc#HandleGCCFormat',
 \   'output_stream': 'both',

ale_linters/rst/rstcheck.vim

@@ -1,5 +1,6 @@
 " Author: John Nduli https://github.com/jnduli
 " Description: Rstcheck for reStructuredText files
+"
 
 function! ale_linters#rst#rstcheck#Handle(buffer, lines) abort
     " matches: 'bad_rst.rst:1: (SEVERE/4) Title overline & underline
@@ -21,11 +22,17 @@ function! ale_linters#rst#rstcheck#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#rst#rstcheck#GetCommand(buffer) abort
+    return ale#path#BufferCdString(a:buffer)
+    \   . 'rstcheck'
+    \   . ' %t'
+endfunction
+
+
 call ale#linter#Define('rst', {
 \   'name': 'rstcheck',
 \   'executable': 'rstcheck',
-\   'cwd': '%s:h',
-\   'command': 'rstcheck %t',
+\   'command': function('ale_linters#rst#rstcheck#GetCommand'),
 \   'callback': 'ale_linters#rst#rstcheck#Handle',
 \   'output_stream': 'both',
 \})

ale_linters/rust/cargo.vim

@@ -23,19 +23,6 @@ function! ale_linters#rust#cargo#GetCargoExecutable(bufnr) abort
     endif
 endfunction
 
-function! ale_linters#rust#cargo#GetCwd(buffer) abort
-    if ale#Var(a:buffer, 'rust_cargo_avoid_whole_workspace')
-        let l:nearest_cargo = ale#path#FindNearestFile(a:buffer, 'Cargo.toml')
-        let l:nearest_cargo_dir = fnamemodify(l:nearest_cargo, ':h')
-
-        if l:nearest_cargo_dir isnot# '.'
-            return l:nearest_cargo_dir
-        endif
-    endif
-
-    return ''
-endfunction
-
 function! ale_linters#rust#cargo#GetCommand(buffer, version) abort
     let l:use_check = ale#Var(a:buffer, 'rust_cargo_use_check')
     \   && ale#semver#GTE(a:version, [0, 17, 0])
@@ -55,6 +42,18 @@ function! ale_linters#rust#cargo#GetCommand(buffer, version) abort
         let l:include_features = ' --features ' . ale#Escape(l:include_features)
     endif
 
+    let l:avoid_whole_workspace = ale#Var(a:buffer, 'rust_cargo_avoid_whole_workspace')
+    let l:nearest_cargo_prefix = ''
+
+    if l:avoid_whole_workspace
+        let l:nearest_cargo = ale#path#FindNearestFile(a:buffer, 'Cargo.toml')
+        let l:nearest_cargo_dir = fnamemodify(l:nearest_cargo, ':h')
+
+        if l:nearest_cargo_dir isnot# '.'
+            let l:nearest_cargo_prefix = 'cd '. ale#Escape(l:nearest_cargo_dir) .' && '
+        endif
+    endif
+
     let l:default_feature_behavior = ale#Var(a:buffer, 'rust_cargo_default_feature_behavior')
 
     if l:default_feature_behavior is# 'all'
@@ -82,7 +81,7 @@ function! ale_linters#rust#cargo#GetCommand(buffer, version) abort
         endif
     endif
 
-    return 'cargo '
+    return l:nearest_cargo_prefix . 'cargo '
     \   . l:subcommand
     \   . (l:use_all_targets ? ' --all-targets' : '')
     \   . (l:use_examples ? ' --examples' : '')
@@ -97,7 +96,6 @@ endfunction
 call ale#linter#Define('rust', {
 \   'name': 'cargo',
 \   'executable': function('ale_linters#rust#cargo#GetCargoExecutable'),
-\   'cwd': function('ale_linters#rust#cargo#GetCwd'),
 \   'command': {buffer -> ale#semver#RunWithVersionCheck(
 \       buffer,
 \       ale_linters#rust#cargo#GetCargoExecutable(buffer),

ale_linters/terraform/terraform.vim

@@ -20,10 +20,6 @@ function! ale_linters#terraform#terraform#GetType(severity) abort
     return 'E'
 endfunction
 
-function! ale_linters#terraform#terraform#GetDetail(error) abort
-    return get(a:error, 'detail', get(a:error, 'summary', ''))
-endfunction
-
 function! ale_linters#terraform#terraform#Handle(buffer, lines) abort
     let l:output = []
 
@@ -37,7 +33,7 @@ function! ale_linters#terraform#terraform#Handle(buffer, lines) abort
             \   'filename': ale#path#GetAbsPath(l:dir, l:error['range']['filename']),
             \   'lnum': l:error['range']['start']['line'],
             \   'col': l:error['range']['start']['column'],
-            \   'text': ale_linters#terraform#terraform#GetDetail(l:error),
+            \   'text': l:error['detail'],
             \   'type': ale_linters#terraform#terraform#GetType(l:error['severity']),
             \})
         else
@@ -45,7 +41,7 @@ function! ale_linters#terraform#terraform#Handle(buffer, lines) abort
             \   'filename': l:file,
             \   'lnum': 0,
             \   'col': 0,
-            \   'text': ale_linters#terraform#terraform#GetDetail(l:error),
+            \   'text': l:error['detail'],
             \   'type': ale_linters#terraform#terraform#GetType(l:error['severity']),
             \})
         endif

ale_linters/tex/texlab.vim

@@ -1,14 +1,11 @@
 " Author: Ricardo Liang <ricardoliang@gmail.com>
-" Author: ourigen <ourigen [at] pm.me>
 " Description: Texlab language server (Rust rewrite)
 
 call ale#Set('tex_texlab_executable', 'texlab')
 call ale#Set('tex_texlab_options', '')
 
 function! ale_linters#tex#texlab#GetProjectRoot(buffer) abort
-    let l:git_path = ale#path#FindNearestDirectory(a:buffer, '.git')
-
-    return !empty(l:git_path) ? fnamemodify(l:git_path, ':h:h') : ''
+    return ''
 endfunction
 
 function! ale_linters#tex#texlab#GetCommand(buffer) abort

ale_linters/typescript/eslint.vim

@@ -4,7 +4,6 @@
 call ale#linter#Define('typescript', {
 \   'name': 'eslint',
 \   'executable': function('ale#handlers#eslint#GetExecutable'),
-\   'cwd': function('ale#handlers#eslint#GetCwd'),
 \   'command': function('ale#handlers#eslint#GetCommand'),
 \   'callback': 'ale#handlers#eslint#HandleJSON',
 \})

ale_linters/typescript/tslint.vim

@@ -59,7 +59,8 @@ function! ale_linters#typescript#tslint#GetCommand(buffer) abort
     \  ? ' -r ' . ale#Escape(l:tslint_rules_dir)
     \  : ''
 
-    return ale#Escape(ale#handlers#tslint#GetExecutable(a:buffer))
+    return ale#path#BufferCdString(a:buffer)
+    \   . ale#Escape(ale#handlers#tslint#GetExecutable(a:buffer))
     \   . ' --format json'
     \   . l:tslint_config_option
     \   . l:tslint_rules_option
@@ -69,7 +70,6 @@ endfunction
 call ale#linter#Define('typescript', {
 \   'name': 'tslint',
 \   'executable': function('ale#handlers#tslint#GetExecutable'),
-\   'cwd': '%s:h',
 \   'command': function('ale_linters#typescript#tslint#GetCommand'),
 \   'callback': 'ale_linters#typescript#tslint#Handle',
 \})

ale_linters/verilog/verilator.vim

@@ -7,11 +7,16 @@ if !exists('g:ale_verilog_verilator_options')
 endif
 
 function! ale_linters#verilog#verilator#GetCommand(buffer) abort
-    " the path to the current file is systematically added to the search path
+    let l:filename = ale#util#Tempname() . '_verilator_linted.v'
+
+    " Create a special filename, so we can detect it in the handler.
+    call ale#command#ManageFile(a:buffer, l:filename)
+    let l:lines = getbufline(a:buffer, 1, '$')
+    call ale#util#Writefile(a:buffer, l:lines, l:filename)
+
     return 'verilator --lint-only -Wall -Wno-DECLFILENAME '
-    \   . '-I%s:h '
     \   . ale#Var(a:buffer, 'verilog_verilator_options') .' '
-    \   . '%t'
+    \   . ale#Escape(l:filename)
 endfunction
 
 function! ale_linters#verilog#verilator#Handle(buffer, lines) abort
@@ -29,7 +34,7 @@ function! ale_linters#verilog#verilator#Handle(buffer, lines) abort
     "
     " to stay compatible with old versions of the tool, the column number is
     " optional in the researched pattern
-    let l:pattern = '^%\(Warning\|Error\)[^:]*:\s*\([^:]\+\):\(\d\+\):\(\d\+\)\?:\? \(.\+\)$'
+    let l:pattern = '^%\(Warning\|Error\)[^:]*:\([^:]\+\):\(\d\+\):\(\d\+\)\?:\? \(.\+\)$'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
@@ -37,14 +42,17 @@ function! ale_linters#verilog#verilator#Handle(buffer, lines) abort
         \   'lnum': str2nr(l:match[3]),
         \   'text': l:match[5],
         \   'type': l:match[1] is# 'Error' ? 'E' : 'W',
-        \   'filename': l:match[2],
         \}
 
         if !empty(l:match[4])
             let l:item.col = str2nr(l:match[4])
         endif
 
-        call add(l:output, l:item)
+        let l:file = l:match[2]
+
+        if l:file =~# '_verilator_linted.v'
+            call add(l:output, l:item)
+        endif
     endfor
 
     return l:output

ale_linters/vim/ale_custom_linting_rules.vim

@@ -22,20 +22,16 @@ function! s:GetALEProjectDir(buffer) abort
     return ale#path#Dirname(ale#path#Dirname(ale#path#Dirname(l:executable)))
 endfunction
 
-function! ale_linters#vim#ale_custom_linting_rules#GetCwd(buffer) abort
-    let l:executable = ale_linters#vim#ale_custom_linting_rules#GetExecutable(a:buffer)
-
-    return ale#path#Dirname(ale#path#Dirname(ale#path#Dirname(l:executable)))
-endfunction
-
 function! ale_linters#vim#ale_custom_linting_rules#GetCommand(buffer) abort
+    let l:dir = s:GetALEProjectDir(a:buffer)
+
     let l:temp_dir = ale#command#CreateDirectory(a:buffer)
     let l:temp_file = l:temp_dir . '/example.vim'
 
     let l:lines = getbufline(a:buffer, 1, '$')
     call ale#util#Writefile(a:buffer, l:lines, l:temp_file)
 
-    return '%e ' . ale#Escape(l:temp_dir)
+    return ale#path#CdString(l:dir) . '%e ' . ale#Escape(l:temp_dir)
 endfunction
 
 function! ale_linters#vim#ale_custom_linting_rules#Handle(buffer, lines) abort
@@ -63,7 +59,6 @@ endfunction
 call ale#linter#Define('vim', {
 \   'name': 'ale_custom_linting_rules',
 \   'executable': function('ale_linters#vim#ale_custom_linting_rules#GetExecutable'),
-\   'cwd': function('ale_linters#vim#ale_custom_linting_rules#GetCwd'),
 \   'command': function('ale_linters#vim#ale_custom_linting_rules#GetCommand'),
 \   'callback': 'ale_linters#vim#ale_custom_linting_rules#Handle',
 \   'read_buffer': 0,

autoload/ale/ant.vim

@@ -23,23 +23,19 @@ function! ale#ant#FindExecutable(buffer) abort
     return ''
 endfunction
 
-" Given a buffer number, get a working directory and command to print the
-" classpath of the root project.
-"
-" Returns an empty string for the command if Ant is not detected.
+" Given a buffer number, build a command to print the classpath of the root
+" project. Returns an empty string if cannot build the command.
 function! ale#ant#BuildClasspathCommand(buffer) abort
     let l:executable = ale#ant#FindExecutable(a:buffer)
+    let l:project_root = ale#ant#FindProjectRoot(a:buffer)
 
-    if !empty(l:executable)
-        let l:project_root = ale#ant#FindProjectRoot(a:buffer)
-
-        if !empty(l:project_root)
-            return [
-            \   l:project_root,
-            \   ale#Escape(l:executable) .' classpath -S -q'
-            \]
-        endif
+    if !empty(l:executable) && !empty(l:project_root)
+        return ale#path#CdString(l:project_root)
+        \   . ale#Escape(l:executable)
+        \   . ' classpath'
+        \   . ' -S'
+        \   . ' -q'
     endif
 
-    return ['', '']
+    return ''
 endfunction

autoload/ale/assert.vim

@@ -52,36 +52,6 @@ function! s:ProcessDeferredCommands(initial_result) abort
     return l:command
 endfunction
 
-function! s:ProcessDeferredCwds(initial_command, initial_cwd) abort
-    let l:result = a:initial_command
-    let l:last_cwd = v:null
-    let l:command_index = 0
-    let l:cwd_list = []
-
-    while ale#command#IsDeferred(l:result)
-        call add(l:cwd_list, l:result.cwd)
-
-        if get(g:, 'ale_run_synchronously_emulate_commands')
-            " Don't run commands, but simulate the results.
-            let l:Callback = g:ale_run_synchronously_callbacks[0]
-            let l:output = get(s:command_output, l:command_index, [])
-            call l:Callback(0, l:output)
-            unlet g:ale_run_synchronously_callbacks
-
-            let l:command_index += 1
-        else
-            " Run the commands in the shell, synchronously.
-            call ale#test#FlushJobs()
-        endif
-
-        let l:result = l:result.value
-    endwhile
-
-    call add(l:cwd_list, a:initial_cwd is v:null ? l:last_cwd : a:initial_cwd)
-
-    return l:cwd_list
-endfunction
-
 " Load the currently loaded linter for a test case, and check that the command
 " matches the given string.
 function! ale#assert#Linter(expected_executable, expected_command) abort
@@ -115,38 +85,6 @@ function! ale#assert#Linter(expected_executable, expected_command) abort
     \   [l:executable, l:command]
 endfunction
 
-function! ale#assert#LinterCwd(expected_cwd) abort
-    let l:buffer = bufnr('')
-    let l:linter = s:GetLinter()
-
-    let l:initial_cwd = ale#linter#GetCwd(l:buffer, l:linter)
-    call ale#command#SetCwd(l:buffer, l:initial_cwd)
-
-    let l:cwd = s:ProcessDeferredCwds(
-    \   ale#linter#GetCommand(l:buffer, l:linter),
-    \   l:initial_cwd,
-    \)
-
-    call ale#command#ResetCwd(l:buffer)
-
-    if type(a:expected_cwd) isnot v:t_list
-        let l:cwd = l:cwd[-1]
-    endif
-
-    AssertEqual a:expected_cwd, l:cwd
-endfunction
-
-function! ale#assert#FixerCwd(expected_cwd) abort
-    let l:buffer = bufnr('')
-    let l:cwd = s:ProcessDeferredCwds(s:FixerFunction(l:buffer), v:null)
-
-    if type(a:expected_cwd) isnot v:t_list
-        let l:cwd = l:cwd[-1]
-    endif
-
-    AssertEqual a:expected_cwd, l:cwd
-endfunction
-
 function! ale#assert#Fixer(expected_result) abort
     let l:buffer = bufnr('')
     let l:result = s:ProcessDeferredCommands(s:FixerFunction(l:buffer))
@@ -215,7 +153,6 @@ endfunction
 
 function! ale#assert#SetUpLinterTestCommands() abort
     command! -nargs=+ GivenCommandOutput :call ale#assert#GivenCommandOutput(<args>)
-    command! -nargs=+ AssertLinterCwd :call ale#assert#LinterCwd(<args>)
     command! -nargs=+ AssertLinter :call ale#assert#Linter(<args>)
     command! -nargs=0 AssertLinterNotExecuted :call ale#assert#LinterNotExecuted()
     command! -nargs=+ AssertLSPOptions :call ale#assert#LSPOptions(<args>)
@@ -227,35 +164,10 @@ endfunction
 
 function! ale#assert#SetUpFixerTestCommands() abort
     command! -nargs=+ GivenCommandOutput :call ale#assert#GivenCommandOutput(<args>)
-    command! -nargs=+ AssertFixerCwd :call ale#assert#FixerCwd(<args>)
     command! -nargs=+ AssertFixer :call ale#assert#Fixer(<args>)
     command! -nargs=0 AssertFixerNotExecuted :call ale#assert#FixerNotExecuted()
 endfunction
 
-function! ale#assert#ResetVariables(filetype, name, ...) abort
-    " If the suffix of the option names format is different, an additional
-    " argument can be used for that instead.
-    if a:0 > 1
-        throw 'Too many arguments'
-    endif
-
-    let l:option_suffix = get(a:000, 0, a:name)
-    let l:prefix = 'ale_' . a:filetype . '_'
-    \   . substitute(l:option_suffix, '-', '_', 'g')
-    let l:filter_expr = 'v:val[: len(l:prefix) - 1] is# l:prefix'
-
-    " Save and clear linter variables.
-    " We'll load the runtime file to reset them to defaults.
-    for l:key in filter(keys(g:), l:filter_expr)
-        execute 'Save g:' . l:key
-        unlet g:[l:key]
-    endfor
-
-    for l:key in filter(keys(b:), l:filter_expr)
-        unlet b:[l:key]
-    endfor
-endfunction
-
 " A dummy function for making sure this module is loaded.
 function! ale#assert#SetUpLinterTest(filetype, name) abort
     " Set up a marker so ALE doesn't create real random temporary filenames.
@@ -265,18 +177,31 @@ function! ale#assert#SetUpLinterTest(filetype, name) abort
     call ale#linter#Reset()
     call ale#linter#PreventLoading(a:filetype)
 
-    Save g:ale_root
-    let g:ale_root = {}
+    let l:prefix = 'ale_' . a:filetype . '_' . a:name
+    let b:filter_expr = 'v:val[: len(l:prefix) - 1] is# l:prefix'
 
-    Save b:ale_root
-    unlet! b:ale_root
+    Save g:ale_lsp_root
+    let g:ale_lsp_root = {}
 
-    call ale#assert#ResetVariables(a:filetype, a:name)
+    Save b:ale_lsp_root
+    unlet! b:ale_lsp_root
 
     Save g:ale_c_build_dir
     unlet! g:ale_c_build_dir
+
+    " Save and clear linter variables.
+    " We'll load the runtime file to reset them to defaults.
+    for l:key in filter(keys(g:), b:filter_expr)
+        execute 'Save g:' . l:key
+        unlet g:[l:key]
+    endfor
+
     unlet! b:ale_c_build_dir
 
+    for l:key in filter(keys(b:), b:filter_expr)
+        unlet b:[l:key]
+    endfor
+
     execute 'runtime ale_linters/' . a:filetype . '/' . a:name . '.vim'
 
     if !exists('g:dir')
@@ -301,10 +226,6 @@ function! ale#assert#TearDownLinterTest() abort
         delcommand GivenCommandOutput
     endif
 
-    if exists(':AssertLinterCwd')
-        delcommand AssertLinterCwd
-    endif
-
     if exists(':AssertLinter')
         delcommand AssertLinter
     endif
@@ -360,7 +281,18 @@ function! ale#assert#SetUpFixerTest(filetype, name, ...) abort
     let s:FixerFunction = function(l:function_name)
 
     let l:option_suffix = get(a:000, 0, a:name)
-    call ale#assert#ResetVariables(a:filetype, a:name, l:option_suffix)
+    let l:prefix = 'ale_' . a:filetype . '_'
+    \   . substitute(l:option_suffix, '-', '_', 'g')
+    let b:filter_expr = 'v:val[: len(l:prefix) - 1] is# l:prefix'
+
+    for l:key in filter(keys(g:), b:filter_expr)
+        execute 'Save g:' . l:key
+        unlet g:[l:key]
+    endfor
+
+    for l:key in filter(keys(b:), b:filter_expr)
+        unlet b:[l:key]
+    endfor
 
     execute 'runtime autoload/ale/fixers/' . substitute(a:name, '-', '_', 'g') . '.vim'
 
@@ -397,10 +329,6 @@ function! ale#assert#TearDownFixerTest() abort
         delcommand GivenCommandOutput
     endif
 
-    if exists(':AssertFixerCwd')
-        delcommand AssertFixerCwd
-    endif
-
     if exists(':AssertFixer')
         delcommand AssertFixer
     endif

autoload/ale/c.vim

@@ -513,18 +513,16 @@ function! ale#c#GetMakeCommand(buffer) abort
         if !empty(l:path)
             let l:always_make = ale#Var(a:buffer, 'c_always_make')
 
-            return [
-            \   fnamemodify(l:path, ':h'),
-            \   'make -n' . (l:always_make ? ' --always-make' : ''),
-            \]
+            return ale#path#CdString(fnamemodify(l:path, ':h'))
+            \   . 'make -n' . (l:always_make ? ' --always-make' : '')
         endif
     endif
 
-    return ['', '']
+    return ''
 endfunction
 
 function! ale#c#RunMakeCommand(buffer, Callback) abort
-    let [l:cwd, l:command] = ale#c#GetMakeCommand(a:buffer)
+    let l:command = ale#c#GetMakeCommand(a:buffer)
 
     if empty(l:command)
         return a:Callback(a:buffer, [])
@@ -534,7 +532,6 @@ function! ale#c#RunMakeCommand(buffer, Callback) abort
     \   a:buffer,
     \   l:command,
     \   {b, output -> a:Callback(a:buffer, output)},
-    \   {'cwd': l:cwd},
     \)
 endfunction
 

autoload/ale/code_action.vim

@@ -71,11 +71,6 @@ function! ale#code_action#ApplyChanges(filename, changes, should_save) abort
 
     if l:buffer > 0
         let l:lines = getbufline(l:buffer, 1, '$')
-
-        " Add empty line if there's trailing newline, like readfile() does.
-        if getbufvar(l:buffer, '&eol')
-            let l:lines += ['']
-        endif
     else
         let l:lines = readfile(a:filename, 'b')
     endif
@@ -94,82 +89,62 @@ function! ale#code_action#ApplyChanges(filename, changes, should_save) abort
         let l:end_column = l:code_edit.end.offset
         let l:text = l:code_edit.newText
 
+        " Adjust the ends according to previous edits.
+        if l:end_line > len(l:lines)
+            let l:end_line_len = 0
+        else
+            let l:end_line_len = len(l:lines[l:end_line - 1])
+        endif
+
         let l:insertions = split(l:text, '\n', 1)
 
-        " Fix invalid columns
-        let l:column = l:column > 0 ? l:column : 1
-        let l:end_column = l:end_column > 0 ? l:end_column : 1
-
-        " Clamp start to BOF
-        if l:line < 1
-            let [l:line, l:column] = [1, 1]
+        if l:line is 1
+            " Same logic as for column below. Vimscript's slice [:-1] will not
+            " be an empty list.
+            let l:start = []
+        else
+            let l:start = l:lines[: l:line - 2]
         endif
 
-        " Clamp start to EOF
-        if l:line > len(l:lines) || l:line == len(l:lines) && l:column > len(l:lines[-1]) + 1
-            let [l:line, l:column] = [len(l:lines), len(l:lines[-1]) + 1]
-        " Special case when start is after EOL
-        elseif l:line < len(l:lines) && l:column > len(l:lines[l:line - 1]) + 1
-            let [l:line, l:column] = [l:line + 1, 1]
+        " Special case when text must be added after new line
+        if l:column > len(l:lines[l:line - 1])
+            call extend(l:start, [l:lines[l:line - 1]])
+            let l:column = 1
         endif
 
-        " Adjust end: clamp if invalid and/or adjust if we moved start
-        if l:end_line < l:line || l:end_line == l:line && l:end_column < l:column
-            let [l:end_line, l:end_column] = [l:line, l:column]
+        if l:column is 1
+            " We need to handle column 1 specially, because we can't slice an
+            " empty string ending on index 0.
+            let l:middle = [l:insertions[0]]
+        else
+            let l:middle = [l:lines[l:line - 1][: l:column - 2] . l:insertions[0]]
         endif
 
-        " Clamp end to EOF
-        if l:end_line > len(l:lines) || l:end_line == len(l:lines) && l:end_column > len(l:lines[-1]) + 1
-            let [l:end_line, l:end_column] = [len(l:lines), len(l:lines[-1]) + 1]
-        " Special case when end is after EOL
-        elseif l:end_line < len(l:lines) && l:end_column > len(l:lines[l:end_line - 1]) + 1
-            let [l:end_line, l:end_column] = [l:end_line + 1, 1]
+        call extend(l:middle, l:insertions[1:])
+
+        if l:end_line <= len(l:lines)
+            " Only extend the last line if end_line is within the range of
+            " lines.
+            let l:middle[-1] .= l:lines[l:end_line - 1][l:end_column - 1 :]
         endif
 
-        " Careful, [:-1] is not an empty list
-        let l:start = l:line is 1 ? [] : l:lines[: l:line - 2]
-        let l:middle = l:column is 1 ? [''] : [l:lines[l:line - 1][: l:column - 2]]
-
-        let l:middle[-1] .= l:insertions[0]
-        let l:middle     += l:insertions[1:]
-        let l:middle[-1] .= l:lines[l:end_line - 1][l:end_column - 1 :]
-
-        let l:end_line_len = len(l:lines[l:end_line - 1])
         let l:lines_before_change = len(l:lines)
         let l:lines = l:start + l:middle + l:lines[l:end_line :]
 
         let l:current_line_offset = len(l:lines) - l:lines_before_change
         let l:column_offset = len(l:middle[-1]) - l:end_line_len
 
-        " Keep cursor where it was (if outside of changes) or move it after
-        " the changed text (if inside), but don't touch it when the change
-        " spans the entire buffer, in which case we have no clue and it's
-        " better to not do anything.
-        if l:line isnot 1 || l:column isnot 1
-        \|| l:end_line < l:lines_before_change
-        \|| l:end_line == l:lines_before_change && l:end_column <= l:end_line_len
-            let l:pos = s:UpdateCursor(l:pos,
-            \ [l:line, l:column],
-            \ [l:end_line, l:end_column],
-            \ [l:current_line_offset, l:column_offset])
-        endif
+        let l:pos = s:UpdateCursor(l:pos,
+        \ [l:line, l:column],
+        \ [l:end_line, l:end_column],
+        \ [l:current_line_offset, l:column_offset])
     endfor
 
-    if l:buffer > 0
-        " Make sure ale#util#{Writefile,SetBufferContents} add trailing
-        " newline if and only if it should be added.
-        if l:lines[-1] is# '' && getbufvar(l:buffer, '&eol')
-            call remove(l:lines, -1)
-        else
-            call setbufvar(l:buffer, '&eol', 0)
-        endif
-    elseif exists('+fixeol') && &fixeol && l:lines[-1] is# ''
-        " Not in buffer, ale#util#Writefile can't check &eol and always adds
-        " newline if &fixeol: remove to prevent double trailing newline.
+    if l:lines[-1] is# ''
         call remove(l:lines, -1)
     endif
 
-    if a:should_save || l:buffer < 0
+    if a:should_save
         call ale#util#Writefile(l:buffer, l:lines, a:filename)
     else
         call ale#util#SetBufferContents(l:buffer, l:lines)

autoload/ale/command.vim

@@ -7,9 +7,6 @@ if !exists('s:buffer_data')
     let s:buffer_data = {}
 endif
 
-" The regular expression used for formatting filenames with modifiers.
-let s:path_format_regex = '\v\%s(%(:h|:t|:r|:e)*)'
-
 " Used to get the data in tests.
 function! ale#command#GetData() abort
     return deepcopy(s:buffer_data)
@@ -29,19 +26,6 @@ function! ale#command#InitData(buffer) abort
     endif
 endfunction
 
-" Set the cwd for commands that are about to run.
-" Used internally.
-function! ale#command#SetCwd(buffer, cwd) abort
-    call ale#command#InitData(a:buffer)
-    let s:buffer_data[a:buffer].cwd = a:cwd
-endfunction
-
-function! ale#command#ResetCwd(buffer) abort
-    if has_key(s:buffer_data, a:buffer)
-        let s:buffer_data[a:buffer].cwd = v:null
-    endif
-endfunction
-
 function! ale#command#ManageFile(buffer, file) abort
     call ale#command#InitData(a:buffer)
     call add(s:buffer_data[a:buffer].file_list, a:file)
@@ -167,24 +151,6 @@ function! s:FormatFilename(filename, mappings, modifiers) abort
     return ale#Escape(l:filename)
 endfunction
 
-" Produce a command prefix to check to a particular directory for a command.
-" %s format markers with filename-modifiers can be used as the directory, and
-" will be returned verbatim for formatting in paths relative to files.
-function! ale#command#CdString(directory) abort
-    let l:match = matchstrpos(a:directory, s:path_format_regex)
-    " Do not escape the directory here if it's a valid format string.
-    " This allows us to use sequences like %s:h, %s:h:h, etc.
-    let l:directory = l:match[1:] == [0, len(a:directory)]
-    \   ? a:directory
-    \   : ale#Escape(a:directory)
-
-    if has('win32')
-        return 'cd /d ' . l:directory . ' && '
-    endif
-
-    return 'cd ' . l:directory . ' && '
-endfunction
-
 " Given a command string, replace every...
 " %s -> with the current filename
 " %t -> with the name of an unused file in a temporary directory
@@ -195,16 +161,11 @@ function! ale#command#FormatCommand(
 \   command,
 \   pipe_file_if_needed,
 \   input,
-\   cwd,
 \   mappings,
 \) abort
     let l:temporary_file = ''
     let l:command = a:command
 
-    if !empty(a:cwd)
-        let l:command = ale#command#CdString(a:cwd) . l:command
-    endif
-
     " First replace all uses of %%, used for literal percent characters,
     " with an ugly string.
     let l:command = substitute(l:command, '%%', '<<PERCENTS>>', 'g')
@@ -220,7 +181,7 @@ function! ale#command#FormatCommand(
         let l:filename = fnamemodify(bufname(a:buffer), ':p')
         let l:command = substitute(
         \   l:command,
-        \   s:path_format_regex,
+        \   '\v\%s(%(:h|:t|:r|:e)*)',
         \   '\=s:FormatFilename(l:filename, a:mappings, submatch(1))',
         \   'g'
         \)
@@ -318,16 +279,9 @@ function! s:ExitCallback(buffer, line_list, Callback, data) abort
     let l:result = a:data.result
     let l:result.value = l:value
 
-    " Set the default cwd for this buffer in this call stack.
-    call ale#command#SetCwd(a:buffer, l:result.cwd)
-
-    try
-        if get(l:result, 'result_callback', v:null) isnot v:null
-            call call(l:result.result_callback, [l:value])
-        endif
-    finally
-        call ale#command#ResetCwd(a:buffer)
-    endtry
+    if get(l:result, 'result_callback', v:null) isnot v:null
+        call call(l:result.result_callback, [l:value])
+    endif
 endfunction
 
 function! ale#command#Run(buffer, command, Callback, ...) abort
@@ -339,13 +293,6 @@ function! ale#command#Run(buffer, command, Callback, ...) abort
 
     let l:output_stream = get(l:options, 'output_stream', 'stdout')
     let l:line_list = []
-    let l:cwd = get(l:options, 'cwd', v:null)
-
-    if l:cwd is v:null
-        " Default the working directory to whatever it was for the last
-        " command run in the chain.
-        let l:cwd = get(get(s:buffer_data, a:buffer, {}), 'cwd', v:null)
-    endif
 
     let [l:temporary_file, l:command, l:file_created] = ale#command#FormatCommand(
     \   a:buffer,
@@ -353,7 +300,6 @@ function! ale#command#Run(buffer, command, Callback, ...) abort
     \   a:command,
     \   get(l:options, 'read_buffer', 0),
     \   get(l:options, 'input', v:null),
-    \   l:cwd,
     \   get(l:options, 'filename_mappings', []),
     \)
     let l:command = ale#job#PrepareCommand(a:buffer, l:command)
@@ -420,14 +366,10 @@ function! ale#command#Run(buffer, command, Callback, ...) abort
     " The `_deferred_job_id` is used for both checking the type of object, and
     " for checking the job ID and status.
     "
-    " The cwd is kept and used as the default value for the next command in
-    " the chain.
-    "
     " The original command here is used in tests.
     let l:result = {
     \   '_deferred_job_id': l:job_id,
     \   'executable': get(l:options, 'executable', ''),
-    \   'cwd': l:cwd,
     \   'command': a:command,
     \}
 

autoload/ale/debugging.vim

@@ -33,13 +33,13 @@ let s:global_variable_list = [
 \    'ale_list_vertical',
 \    'ale_list_window_size',
 \    'ale_loclist_msg_format',
+\    'ale_lsp_root',
 \    'ale_max_buffer_history_size',
 \    'ale_max_signs',
 \    'ale_maximum_file_size',
 \    'ale_open_list',
 \    'ale_pattern_options',
 \    'ale_pattern_options_enabled',
-\    'ale_root',
 \    'ale_set_balloons',
 \    'ale_set_highlights',
 \    'ale_set_loclist',

autoload/ale/definition.vim

@@ -36,7 +36,7 @@ function! ale#definition#UpdateTagStack() abort
 endfunction
 
 function! ale#definition#HandleTSServerResponse(conn_id, response) abort
-    if has_key(a:response, 'request_seq')
+    if get(a:response, 'command', '') is# 'definition'
     \&& has_key(s:go_to_definition_map, a:response.request_seq)
         let l:options = remove(s:go_to_definition_map, a:response.request_seq)
 
@@ -92,19 +92,11 @@ function! s:OnReady(line, column, options, capability, linter, lsp_details) abor
     call ale#lsp#RegisterCallback(l:id, l:Callback)
 
     if a:linter.lsp is# 'tsserver'
-        if a:capability is# 'definition'
-            let l:message = ale#lsp#tsserver_message#Definition(
-            \   l:buffer,
-            \   a:line,
-            \   a:column
-            \)
-        elseif a:capability is# 'typeDefinition'
-            let l:message = ale#lsp#tsserver_message#TypeDefinition(
-            \   l:buffer,
-            \   a:line,
-            \   a:column
-            \)
-        endif
+        let l:message = ale#lsp#tsserver_message#Definition(
+        \   l:buffer,
+        \   a:line,
+        \   a:column
+        \)
     else
         " Send a message saying the buffer has changed first, or the
         " definition position probably won't make sense.
@@ -153,6 +145,12 @@ endfunction
 function! ale#definition#GoToType(options) abort
     for l:linter in ale#linter#Get(&filetype)
         if !empty(l:linter.lsp)
+            " TODO: handle typeDefinition for tsserver if supported by the
+            " protocol
+            if l:linter.lsp is# 'tsserver'
+                continue
+            endif
+
             call s:GoToLSPDefinition(l:linter, a:options, 'typeDefinition')
         endif
     endfor

autoload/ale/engine.vim

@@ -413,7 +413,6 @@ function! s:RunJob(command, options) abort
         return 0
     endif
 
-    let l:cwd = a:options.cwd
     let l:executable = a:options.executable
     let l:buffer = a:options.buffer
     let l:linter = a:options.linter
@@ -426,7 +425,6 @@ function! s:RunJob(command, options) abort
     \   'executable': l:executable,
     \}])
     let l:result = ale#command#Run(l:buffer, l:command, l:Callback, {
-    \   'cwd': l:cwd,
     \   'output_stream': l:output_stream,
     \   'executable': l:executable,
     \   'read_buffer': l:read_buffer,
@@ -543,22 +541,8 @@ function! s:RunIfExecutable(buffer, linter, lint_file, executable) abort
         let l:job_type = a:lint_file ? 'file_linter' : 'linter'
         call setbufvar(a:buffer, 'ale_job_type', l:job_type)
 
-        " Get the cwd for the linter and set it before we call GetCommand.
-        " This will ensure that ale#command#Run uses it by default.
-        let l:cwd = ale#linter#GetCwd(a:buffer, a:linter)
-
-        if l:cwd isnot v:null
-            call ale#command#SetCwd(a:buffer, l:cwd)
-        endif
-
         let l:command = ale#linter#GetCommand(a:buffer, a:linter)
-
-        if l:cwd isnot v:null
-            call ale#command#ResetCwd(a:buffer)
-        endif
-
         let l:options = {
-        \   'cwd': l:cwd,
         \   'executable': a:executable,
         \   'buffer': a:buffer,
         \   'linter': a:linter,

autoload/ale/fix.vim

@@ -172,7 +172,6 @@ function! s:RunJob(result, options) abort
     let l:read_temporary_file = get(a:result, 'read_temporary_file', 0)
     let l:read_buffer = get(a:result, 'read_buffer', 1)
     let l:output_stream = get(a:result, 'output_stream', 'stdout')
-    let l:cwd = get(a:result, 'cwd', v:null)
 
     if l:read_temporary_file
         let l:output_stream = 'none'
@@ -191,7 +190,6 @@ function! s:RunJob(result, options) abort
     \   'read_buffer': l:read_buffer,
     \   'input': l:input,
     \   'log_output': 0,
-    \   'cwd': l:cwd,
     \   'filename_mappings': ale#GetFilenameMappings(l:buffer, l:fixer_name),
     \})
 

autoload/ale/fix/registry.vim

@@ -32,11 +32,6 @@ let s:default_registry = {
 \       'suggested_filetypes': ['python'],
 \       'description': 'Fix PEP8 issues with black.',
 \   },
-\   'buildifier': {
-\       'function': 'ale#fixers#buildifier#Fix',
-\       'suggested_filetypes': ['bzl'],
-\       'description': 'Format BUILD and .bzl files with buildifier.',
-\   },
 \   'deno': {
 \       'function': 'ale#fixers#deno#Fix',
 \       'suggested_filetypes': ['typescript'],
@@ -112,7 +107,7 @@ let s:default_registry = {
 \   },
 \   'prettier': {
 \       'function': 'ale#fixers#prettier#Fix',
-\       'suggested_filetypes': ['javascript', 'typescript', 'css', 'less', 'scss', 'json', 'json5', 'graphql', 'markdown', 'vue', 'html', 'yaml', 'openapi', 'ruby'],
+\       'suggested_filetypes': ['javascript', 'typescript', 'css', 'less', 'scss', 'json', 'json5', 'graphql', 'markdown', 'vue', 'html', 'yaml', 'openapi'],
 \       'description': 'Apply prettier to a file.',
 \   },
 \   'prettier_eslint': {

autoload/ale/fixers/autoimport.vim

@@ -19,9 +19,7 @@ function! ale#fixers#autoimport#Fix(buffer) abort
     endif
 
     return {
-    \   'cwd': '%s:h',
-    \   'command': ale#Escape(l:executable)
-    \       . (!empty(l:options) ? ' ' . l:options : '')
-    \       . ' -',
+    \   'command': ale#path#BufferCdString(a:buffer)
+    \   .   ale#Escape(l:executable) . (!empty(l:options) ? ' ' . l:options : '') . ' -',
     \}
 endfunction

autoload/ale/fixers/black.vim

@@ -17,25 +17,25 @@ function! ale#fixers#black#GetExecutable(buffer) abort
 endfunction
 
 function! ale#fixers#black#Fix(buffer) abort
+    let l:cd_string = ale#Var(a:buffer, 'python_black_change_directory')
+    \   ? ale#path#BufferCdString(a:buffer)
+    \   : ''
+
     let l:executable = ale#fixers#black#GetExecutable(a:buffer)
+
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run black'
     \   : ''
+
     let l:options = ale#Var(a:buffer, 'python_black_options')
 
     if expand('#' . a:buffer . ':e') is? 'pyi'
         let l:options .= '--pyi'
     endif
 
-    let l:result = {
-    \   'command': ale#Escape(l:executable) . l:exec_args
+    return {
+    \   'command': l:cd_string . ale#Escape(l:executable) . l:exec_args
     \       . (!empty(l:options) ? ' ' . l:options : '')
     \       . ' -',
     \}
-
-    if ale#Var(a:buffer, 'python_black_change_directory')
-        let l:result.cwd = '%s:h'
-    endif
-
-    return l:result
 endfunction

autoload/ale/fixers/buildifier.vim

@@ -1,37 +0,0 @@
-" Author: Jon Parise <jon@indelible.org>
-" Description: Format Bazel BUILD and .bzl files with buildifier.
-"
-call ale#Set('bazel_buildifier_executable', 'buildifier')
-call ale#Set('bazel_buildifier_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('bazel_buildifier_options', '')
-
-function! ale#fixers#buildifier#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'bazel_buildifier', [
-    \   'buildifier',
-    \])
-endfunction
-
-function! ale#fixers#buildifier#Fix(buffer) abort
-    let l:executable = ale#Escape(ale#fixers#buildifier#GetExecutable(a:buffer))
-    let l:options = ale#Var(a:buffer, 'bazel_buildifier_options')
-    let l:filename = fnamemodify(bufname(a:buffer), ':t')
-
-    let l:command = l:executable . ' -mode fix -lint fix'
-
-    " Attempt to guess the file type based on the filename. buildifier itself
-    " usually does this based on the filenames provided on the command line,
-    " but because we're piping our buffer via stdin, we do this manually.
-    if l:filename =~? 'WORKSPACE'
-        let l:command .= ' -type workspace'
-    elseif l:filename =~? 'BUILD'
-        let l:command .= ' -type build'
-    elseif l:filename =~? '.bzl$'
-        let l:command .= ' -type bzl'
-    endif
-
-    if l:options isnot# ''
-        let l:command .= ' ' . l:options
-    endif
-
-    return {'command': l:command . ' -'}
-endfunction

autoload/ale/fixers/clangformat.vim

@@ -5,8 +5,6 @@ scriptencoding utf-8
 call ale#Set('c_clangformat_executable', 'clang-format')
 call ale#Set('c_clangformat_use_global', get(g:, 'ale_use_global_executables', 0))
 call ale#Set('c_clangformat_options', '')
-call ale#Set('c_clangformat_style_option', '')
-call ale#Set('c_clangformat_use_local_file', 0)
 
 function! ale#fixers#clangformat#GetExecutable(buffer) abort
     return ale#node#FindExecutable(a:buffer, 'c_clangformat', [
@@ -18,24 +16,6 @@ function! ale#fixers#clangformat#Fix(buffer) abort
     let l:executable = ale#Escape(ale#fixers#clangformat#GetExecutable(a:buffer))
     let l:filename = ale#Escape(bufname(a:buffer))
     let l:options = ale#Var(a:buffer, 'c_clangformat_options')
-    let l:style_option = ale#Var(a:buffer, 'c_clangformat_style_option')
-    let l:use_local_file = ale#Var(a:buffer, 'c_clangformat_use_local_file')
-
-    if l:style_option isnot# ''
-        let l:style_option = '-style=' . "'" . l:style_option . "'"
-    endif
-
-    if l:use_local_file
-        let l:config = ale#path#FindNearestFile(a:buffer, '.clang-format')
-
-        if !empty(l:config)
-            let l:style_option = '-style=file'
-        endif
-    endif
-
-    if l:style_option isnot# ''
-        let l:options .= ' ' . l:style_option
-    endif
 
     let l:command = l:executable . ' --assume-filename=' . l:filename
 

autoload/ale/fixers/erlfmt.vim

@@ -1,21 +0,0 @@
-" Author: AntoineGagne - https://github.com/AntoineGagne
-" Description: Integration of erlfmt with ALE.
-
-call ale#Set('erlang_erlfmt_executable', 'erlfmt')
-call ale#Set('erlang_erlfmt_use_global', get(g:, 'ale_use_global_executables', 0))
-call ale#Set('erlang_erlfmt_options', '')
-
-function! ale#fixers#erlfmt#GetExecutable(buffer) abort
-    return ale#node#FindExecutable(a:buffer, 'erlang_erlfmt', ['erlfmt'])
-endfunction
-
-function! ale#fixers#erlfmt#Fix(buffer) abort
-    let l:options = ale#Var(a:buffer, 'erlang_erlfmt_options')
-    let l:executable = ale#fixers#erlfmt#GetExecutable(a:buffer)
-
-    let l:command = ale#Escape(l:executable) . (empty(l:options) ? '' : ' ' . l:options) . ' %s'
-
-    return {
-    \   'command': l:command
-    \}
-endfunction

autoload/ale/fixers/eslint.vim

@@ -53,8 +53,8 @@ function! ale#fixers#eslint#ApplyFixForVersion(buffer, version) abort
     " Use --fix-to-stdout with eslint_d
     if l:executable =~# 'eslint_d$' && ale#semver#GTE(a:version, [3, 19, 0])
         return {
-        \   'cwd': ale#handlers#eslint#GetCwd(a:buffer),
-        \   'command': ale#node#Executable(a:buffer, l:executable)
+        \   'command': ale#handlers#eslint#GetCdString(a:buffer)
+        \       . ale#node#Executable(a:buffer, l:executable)
         \       . ale#Pad(l:options)
         \       . ' --stdin-filename %s --stdin --fix-to-stdout',
         \   'process_with': 'ale#fixers#eslint#ProcessEslintDOutput',
@@ -64,8 +64,8 @@ function! ale#fixers#eslint#ApplyFixForVersion(buffer, version) abort
     " 4.9.0 is the first version with --fix-dry-run
     if ale#semver#GTE(a:version, [4, 9, 0])
         return {
-        \   'cwd': ale#handlers#eslint#GetCwd(a:buffer),
-        \   'command': ale#node#Executable(a:buffer, l:executable)
+        \   'command': ale#handlers#eslint#GetCdString(a:buffer)
+        \       . ale#node#Executable(a:buffer, l:executable)
         \       . ale#Pad(l:options)
         \       . ' --stdin-filename %s --stdin --fix-dry-run --format=json',
         \   'process_with': 'ale#fixers#eslint#ProcessFixDryRunOutput',
@@ -73,8 +73,8 @@ function! ale#fixers#eslint#ApplyFixForVersion(buffer, version) abort
     endif
 
     return {
-    \   'cwd': ale#handlers#eslint#GetCwd(a:buffer),
-    \   'command': ale#node#Executable(a:buffer, l:executable)
+    \   'command': ale#handlers#eslint#GetCdString(a:buffer)
+    \       . ale#node#Executable(a:buffer, l:executable)
     \       . ale#Pad(l:options)
     \       . (!empty(l:config) ? ' -c ' . ale#Escape(l:config) : '')
     \       . ' --fix %t',

autoload/ale/fixers/isort.vim

@@ -17,7 +17,9 @@ endfunction
 
 function! ale#fixers#isort#Fix(buffer) abort
     let l:options = ale#Var(a:buffer, 'python_isort_options')
+
     let l:executable = ale#fixers#isort#GetExecutable(a:buffer)
+
     let l:exec_args = l:executable =~? 'pipenv$'
     \   ? ' run isort'
     \   : ''
@@ -27,8 +29,8 @@ function! ale#fixers#isort#Fix(buffer) abort
     endif
 
     return {
-    \   'cwd': '%s:h',
-    \   'command': ale#Escape(l:executable) . l:exec_args
+    \   'command': ale#path#BufferCdString(a:buffer)
+    \   . ale#Escape(l:executable) . l:exec_args
     \   . (!empty(l:options) ? ' ' . l:options : '') . ' -',
     \}
 endfunction

autoload/ale/fixers/prettier.vim

@@ -34,11 +34,19 @@ function! ale#fixers#prettier#ProcessPrettierDOutput(buffer, output) abort
     return a:output
 endfunction
 
-function! ale#fixers#prettier#GetCwd(buffer) abort
+function! ale#fixers#prettier#GetProjectRoot(buffer) abort
     let l:config = ale#path#FindNearestFile(a:buffer, '.prettierignore')
 
+    if !empty(l:config)
+        return fnamemodify(l:config, ':h')
+    endif
+
     " Fall back to the directory of the buffer
-    return !empty(l:config) ? fnamemodify(l:config, ':h') : '%s:h'
+    return fnamemodify(bufname(a:buffer), ':p:h')
+endfunction
+
+function! ale#fixers#prettier#CdProjectRoot(buffer) abort
+    return ale#path#CdString(ale#fixers#prettier#GetProjectRoot(a:buffer))
 endfunction
 
 function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
@@ -77,7 +85,6 @@ function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
         \    'yaml': 'yaml',
         \    'openapi': 'yaml',
         \    'html': 'html',
-        \    'ruby': 'ruby',
         \}
 
         for l:filetype in l:filetypes
@@ -95,8 +102,8 @@ function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
     " Special error handling needed for prettier_d
     if l:executable =~# 'prettier_d$'
         return {
-        \   'cwd': '%s:h',
-        \   'command':ale#Escape(l:executable)
+        \   'command': ale#path#BufferCdString(a:buffer)
+        \       . ale#Escape(l:executable)
         \       . (!empty(l:options) ? ' ' . l:options : '')
         \       . ' --stdin-filepath %s --stdin',
         \   'process_with': 'ale#fixers#prettier#ProcessPrettierDOutput',
@@ -106,8 +113,8 @@ function! ale#fixers#prettier#ApplyFixForVersion(buffer, version) abort
     " 1.4.0 is the first version with --stdin-filepath
     if ale#semver#GTE(a:version, [1, 4, 0])
         return {
-        \   'cwd': ale#fixers#prettier#GetCwd(a:buffer),
-        \   'command': ale#Escape(l:executable)
+        \   'command': ale#fixers#prettier#CdProjectRoot(a:buffer)
+        \       . ale#Escape(l:executable)
         \       . (!empty(l:options) ? ' ' . l:options : '')
         \       . ' --stdin-filepath %s --stdin',
         \}

autoload/ale/fixers/prettier_eslint.vim

@@ -37,8 +37,8 @@ function! ale#fixers#prettier_eslint#ApplyFixForVersion(buffer, version) abort
     " 4.4.0 is the first version with --stdin-filepath
     if ale#semver#GTE(a:version, [4, 4, 0])
         return {
-        \   'cwd': '%s:h',
-        \   'command': ale#Escape(l:executable)
+        \   'command': ale#path#BufferCdString(a:buffer)
+        \       . ale#Escape(l:executable)
         \       . l:eslint_config_option
         \       . (!empty(l:options) ? ' ' . l:options : '')
         \       . ' --stdin-filepath %s --stdin',

autoload/ale/fixers/stylelint.vim

@@ -17,8 +17,8 @@ function! ale#fixers#stylelint#Fix(buffer) abort
     let l:options = ale#Var(a:buffer, 'stylelint_options')
 
     return {
-    \   'cwd': '%s:h',
-    \   'command': ale#node#Executable(a:buffer, l:executable)
+    \   'command': ale#path#BufferCdString(a:buffer)
+    \       . ale#node#Executable(a:buffer, l:executable)
     \       . ' %t'
     \       . ale#Pad(l:options)
     \       . ' --fix',

autoload/ale/fixers/yamlfix.vim

@@ -7,6 +7,7 @@ call ale#Set('yaml_yamlfix_use_global', get(g:, 'ale_use_global_executables', 0)
 
 function! ale#fixers#yamlfix#Fix(buffer) abort
     let l:options = ale#Var(a:buffer, 'yaml_yamlfix_options')
+
     let l:executable = ale#python#FindExecutable(
     \   a:buffer,
     \   'yaml_yamlfix',
@@ -18,8 +19,7 @@ function! ale#fixers#yamlfix#Fix(buffer) abort
     endif
 
     return {
-    \   'cwd': '%s:h',
-    \   'command': ale#Escape(l:executable)
-    \       . (!empty(l:options) ? ' ' . l:options : '') . ' -',
+    \   'command': ale#path#BufferCdString(a:buffer)
+    \   .   ale#Escape(l:executable) . (!empty(l:options) ? ' ' . l:options : '') . ' -',
     \}
 endfunction

autoload/ale/floating_preview.vim

@@ -47,53 +47,16 @@ function! ale#floating_preview#Show(lines, ...) abort
         endif
     augroup END
 
-    let [l:lines, l:width, l:height] = s:PrepareWindowContent(a:lines)
-
+    let l:width = max(map(copy(a:lines), 'strdisplaywidth(v:val)'))
+    let l:height = min([len(a:lines), 10])
     call nvim_win_set_width(w:preview['id'], l:width)
     call nvim_win_set_height(w:preview['id'], l:height)
-    call nvim_buf_set_lines(w:preview['buffer'], 0, -1, v:false, l:lines)
+
+    call nvim_buf_set_lines(w:preview['buffer'], 0, -1, v:false, a:lines)
     call nvim_buf_set_option(w:preview['buffer'], 'modified', v:false)
     call nvim_buf_set_option(w:preview['buffer'], 'modifiable', v:false)
 endfunction
 
-function! s:PrepareWindowContent(lines) abort
-    let l:max_height = 10
-
-    let l:width = max(map(copy(a:lines), 'strdisplaywidth(v:val)'))
-    let l:height = min([len(a:lines), l:max_height])
-
-    if empty(g:ale_floating_window_border)
-        return [a:lines, l:width, l:height]
-    endif
-
-    " Add the size of borders
-    let l:width += 2
-    let l:height += 2
-
-    let l:hor          = g:ale_floating_window_border[0]
-    let l:top          = g:ale_floating_window_border[1]
-    let l:top_left     = g:ale_floating_window_border[2]
-    let l:top_right    = g:ale_floating_window_border[3]
-    let l:bottom_right = g:ale_floating_window_border[4]
-    let l:bottom_left  = g:ale_floating_window_border[5]
-
-    let l:lines = [l:top_left . repeat(l:top, l:width - 2) . l:top_right]
-
-    for l:line in a:lines
-        let l:line_width = strchars(l:line)
-        let l:lines = add(l:lines, l:hor . l:line . repeat(' ', l:width - l:line_width - 2). l:hor)
-    endfor
-
-    " Truncate the lines
-    if len(l:lines) > l:max_height + 1
-        let l:lines = l:lines[0:l:max_height]
-    endif
-
-    let l:lines = add(l:lines, l:bottom_left . repeat(l:top, l:width - 2) . l:bottom_right)
-
-    return [l:lines, l:width, l:height]
-endfunction
-
 function! s:Create(options) abort
     let l:buffer = nvim_create_buf(v:false, v:false)
     let l:winid = nvim_open_win(l:buffer, v:false, {
@@ -125,3 +88,4 @@ function! s:Close() abort
 
     unlet w:preview
 endfunction
+

autoload/ale/gradle.vim

@@ -50,25 +50,18 @@ function! ale#gradle#FindExecutable(buffer) abort
     return ''
 endfunction
 
-" Given a buffer number, get a working directory and command to print the
-" classpath of the root project.
-"
-" Returns an empty string for the command if Gradle is not detected.
+" Given a buffer number, build a command to print the classpath of the root
+" project. Returns an empty string if cannot build the command.
 function! ale#gradle#BuildClasspathCommand(buffer) abort
     let l:executable = ale#gradle#FindExecutable(a:buffer)
+    let l:project_root = ale#gradle#FindProjectRoot(a:buffer)
 
-    if !empty(l:executable)
-        let l:project_root = ale#gradle#FindProjectRoot(a:buffer)
-
-        if !empty(l:project_root)
-            return [
-            \   l:project_root,
-            \   ale#Escape(l:executable)
-            \   . ' -I ' . ale#Escape(s:init_path)
-            \   . ' -q printClasspath'
-            \]
-        endif
+    if !empty(l:executable) && !empty(l:project_root)
+        return ale#path#CdString(l:project_root)
+        \   . ale#Escape(l:executable)
+        \   . ' -I ' . ale#Escape(s:init_path)
+        \   . ' -q printClasspath'
     endif
 
-    return ['', '']
+    return ''
 endfunction

autoload/ale/handlers/cppcheck.vim

@@ -1,9 +1,10 @@
 " Description: Handle errors for cppcheck.
 
-function! ale#handlers#cppcheck#GetCwd(buffer) abort
+function! ale#handlers#cppcheck#GetCdCommand(buffer) abort
     let [l:dir, l:json_path] = ale#c#FindCompileCommands(a:buffer)
+    let l:cd_command = !empty(l:dir) ? ale#path#CdString(l:dir) : ''
 
-    return !empty(l:dir) ? l:dir : ''
+    return l:cd_command
 endfunction
 
 function! ale#handlers#cppcheck#GetBufferPathIncludeOptions(buffer) abort

autoload/ale/handlers/eslint.vim

@@ -39,8 +39,9 @@ function! ale#handlers#eslint#GetExecutable(buffer) abort
     return ale#node#FindExecutable(a:buffer, 'javascript_eslint', s:executables)
 endfunction
 
-" Given a buffer, return an appropriate working directory for ESLint.
-function! ale#handlers#eslint#GetCwd(buffer) abort
+" Given a buffer, return a command prefix string which changes directory
+" as necessary for running ESLint.
+function! ale#handlers#eslint#GetCdString(buffer) abort
     " ESLint 6 loads plugins/configs/parsers from the project root
     " By default, the project root is simply the CWD of the running process.
     " https://github.com/eslint/rfcs/blob/master/designs/2018-simplified-package-loading/README.md
@@ -55,24 +56,11 @@ function! ale#handlers#eslint#GetCwd(buffer) abort
         let l:nmi = strridx(l:executable, 'node_modules')
         let l:project_dir = l:executable[0:l:nmi - 2]
     else
-        " Patched behaviour: looks up yarn pnp before node_modules to add
-        " support for Yarn Berry.
         let l:modules_dir = ale#path#FindNearestDirectory(a:buffer, 'node_modules')
-        let l:yarn_cpnp = ale#path#FindNearestFile(a:buffer, '.pnp.cjs')
-        let l:yarn_pnp = ale#path#FindNearestFile(a:buffer, '.pnp.js')
-
-        if !empty(l:yarn_pnp)
-            let l:project_dir = !empty(l:yarn_pnp) ? fnamemodify(l:yarn_pnp, ':h') : ''
-        elseif !empty(l:yarn_cpnp)
-            let l:project_dir = !empty(l:yarn_cpnp) ? fnamemodify(l:yarn_cpnp, ':h') : ''
-        elseif !empty(l:modules_dir)
-            let l:project_dir = !empty(l:modules_dir) ? fnamemodify(l:modules_dir, ':h:h') : ''
-        else
-            let l:project_dir = ''
-        endif
+        let l:project_dir = !empty(l:modules_dir) ? fnamemodify(l:modules_dir, ':h:h') : ''
     endif
 
-    return !empty(l:project_dir) ? l:project_dir : ''
+    return !empty(l:project_dir) ? ale#path#CdString(l:project_dir) : ''
 endfunction
 
 function! ale#handlers#eslint#GetCommand(buffer) abort
@@ -80,7 +68,8 @@ function! ale#handlers#eslint#GetCommand(buffer) abort
 
     let l:options = ale#Var(a:buffer, 'javascript_eslint_options')
 
-    return ale#node#Executable(a:buffer, l:executable)
+    return ale#handlers#eslint#GetCdString(a:buffer)
+    \   . ale#node#Executable(a:buffer, l:executable)
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . ' -f json --stdin --stdin-filename %s'
 endfunction

autoload/ale/handlers/ocamllsp.vim

@@ -1,23 +0,0 @@
-" Author: Risto Stevcev <me@risto.codes>
-" Description: Handlers for the official OCaml language server
-
-function! ale#handlers#ocamllsp#GetExecutable(buffer) abort
-    return 'ocamllsp'
-endfunction
-
-function! ale#handlers#ocamllsp#GetCommand(buffer) abort
-    let l:executable = ale#handlers#ocamllsp#GetExecutable(a:buffer)
-    let l:ocaml_ocamllsp_use_opam = ale#Var(a:buffer, 'ocaml_ocamllsp_use_opam')
-
-    return l:ocaml_ocamllsp_use_opam ? 'opam config exec -- ' . l:executable : l:executable
-endfunction
-
-function! ale#handlers#ocamllsp#GetLanguage(buffer) abort
-    return getbufvar(a:buffer, '&filetype')
-endfunction
-
-function! ale#handlers#ocamllsp#GetProjectRoot(buffer) abort
-    let l:dune_project_file = ale#path#FindNearestFile(a:buffer, 'dune-project')
-
-    return !empty(l:dune_project_file) ? fnamemodify(l:dune_project_file, ':h') : ''
-endfunction

autoload/ale/handlers/shellcheck.vim

@@ -40,21 +40,21 @@ function! ale#handlers#shellcheck#GetDialectArgument(buffer) abort
     return ''
 endfunction
 
-function! ale#handlers#shellcheck#GetCwd(buffer) abort
-    return ale#Var(a:buffer, 'sh_shellcheck_change_directory') ? '%s:h' : ''
-endfunction
-
 function! ale#handlers#shellcheck#GetCommand(buffer, version) abort
     let l:options = ale#Var(a:buffer, 'sh_shellcheck_options')
     let l:exclude_option = ale#Var(a:buffer, 'sh_shellcheck_exclusions')
     let l:dialect = ale#Var(a:buffer, 'sh_shellcheck_dialect')
     let l:external_option = ale#semver#GTE(a:version, [0, 4, 0]) ? ' -x' : ''
+    let l:cd_string = ale#Var(a:buffer, 'sh_shellcheck_change_directory')
+    \   ? ale#path#BufferCdString(a:buffer)
+    \   : ''
 
     if l:dialect is# 'auto'
         let l:dialect = ale#handlers#shellcheck#GetDialectArgument(a:buffer)
     endif
 
-    return '%e'
+    return l:cd_string
+    \   . '%e'
     \   . (!empty(l:dialect) ? ' -s ' . l:dialect : '')
     \   . (!empty(l:options) ? ' ' . l:options : '')
     \   . (!empty(l:exclude_option) ? ' -e ' . l:exclude_option : '')
@@ -111,7 +111,6 @@ function! ale#handlers#shellcheck#DefineLinter(filetype) abort
     call ale#linter#Define(a:filetype, {
     \   'name': 'shellcheck',
     \   'executable': {buffer -> ale#Var(buffer, 'sh_shellcheck_executable')},
-    \   'cwd': function('ale#handlers#shellcheck#GetCwd'),
     \   'command': {buffer -> ale#semver#RunWithVersionCheck(
     \       buffer,
     \       ale#Var(buffer, 'sh_shellcheck_executable'),

autoload/ale/linter.vim

@@ -151,30 +151,17 @@ function! ale#linter#PreProcess(filetype, linter) abort
         endif
 
         let l:obj.address = a:linter.address
-
-        if has_key(a:linter, 'cwd')
-            throw '`cwd` makes no sense for socket LSP connections'
-        endif
     else
         throw '`address` must be defined for getting the LSP address'
     endif
 
-    if has_key(a:linter, 'cwd')
-        let l:obj.cwd = a:linter.cwd
-
-        if type(l:obj.cwd) isnot v:t_string
-        \&& type(l:obj.cwd) isnot v:t_func
-            throw '`cwd` must be a String or Function if defined'
-        endif
-    endif
-
     if l:needs_lsp_details
         " Default to using the filetype as the language.
         let l:obj.language = get(a:linter, 'language', a:filetype)
 
         if type(l:obj.language) isnot v:t_string
         \&& type(l:obj.language) isnot v:t_func
-            throw '`language` must be a String or Function if defined'
+            throw '`language` must be a String or Funcref if defined'
         endif
 
         if has_key(a:linter, 'project_root')
@@ -428,12 +415,6 @@ function! ale#linter#GetExecutable(buffer, linter) abort
     \   : l:Executable
 endfunction
 
-function! ale#linter#GetCwd(buffer, linter) abort
-    let l:Cwd = get(a:linter, 'cwd', v:null)
-
-    return type(l:Cwd) is v:t_func ? l:Cwd(a:buffer) : l:Cwd
-endfunction
-
 " Given a buffer and linter, get the command String for the linter.
 function! ale#linter#GetCommand(buffer, linter) abort
     let l:Command = a:linter.command

autoload/ale/lsp.vim

@@ -357,7 +357,6 @@ function! ale#lsp#MarkConnectionAsTsserver(conn_id) abort
     let l:conn.capabilities.completion = 1
     let l:conn.capabilities.completion_trigger_characters = ['.']
     let l:conn.capabilities.definition = 1
-    let l:conn.capabilities.typeDefinition = 1
     let l:conn.capabilities.symbol_search = 1
     let l:conn.capabilities.rename = 1
     let l:conn.capabilities.code_actions = 1

autoload/ale/lsp/tsserver_message.vim

@@ -64,14 +64,6 @@ function! ale#lsp#tsserver_message#Definition(buffer, line, column) abort
     \}]
 endfunction
 
-function! ale#lsp#tsserver_message#TypeDefinition(buffer, line, column) abort
-    return [0, 'ts@typeDefinition', {
-    \   'line': a:line,
-    \   'offset': a:column,
-    \   'file': expand('#' . a:buffer . ':p'),
-    \}]
-endfunction
-
 function! ale#lsp#tsserver_message#References(buffer, line, column) abort
     return [0, 'ts@references', {
     \   'line': a:line,

autoload/ale/lsp_linter.vim

@@ -201,11 +201,7 @@ function! ale#lsp_linter#GetConfig(buffer, linter) abort
 endfunction
 
 function! ale#lsp_linter#FindProjectRoot(buffer, linter) abort
-    let l:buffer_ale_root = getbufvar(
-    \   a:buffer,
-    \   'ale_root',
-    \   getbufvar(a:buffer, 'ale_lsp_root', {})
-    \)
+    let l:buffer_ale_root = getbufvar(a:buffer, 'ale_lsp_root', {})
 
     if type(l:buffer_ale_root) is v:t_string
         return l:buffer_ale_root
@@ -222,15 +218,9 @@ function! ale#lsp_linter#FindProjectRoot(buffer, linter) abort
         endif
     endif
 
-    let l:global_root = g:ale_root
-
-    if empty(g:ale_root) && exists('g:ale_lsp_root')
-        let l:global_root = g:ale_lsp_root
-    endif
-
     " Try to get a global setting for the root
-    if has_key(l:global_root, a:linter.name)
-        let l:Root = l:global_root[a:linter.name]
+    if has_key(g:ale_lsp_root, a:linter.name)
+        let l:Root = g:ale_lsp_root[a:linter.name]
 
         if type(l:Root) is v:t_func
             return l:Root(a:buffer)
@@ -300,7 +290,6 @@ function! s:StartLSP(options, address, executable, command) abort
         \   a:command,
         \   0,
         \   v:false,
-        \   v:null,
         \   [],
         \)[1]
         let l:command = ale#job#PrepareCommand(l:buffer, l:command)

autoload/ale/maven.vim

@@ -17,6 +17,7 @@ function! ale#maven#FindProjectRoot(buffer) abort
     return ''
 endfunction
 
+
 " Given a buffer number, find the path to the executable.
 " First search on the path for 'mvnw' (mvnw.cmd on Windows), if nothing is found,
 " try the global command. Returns an empty string if cannot find the executable.
@@ -35,23 +36,16 @@ function! ale#maven#FindExecutable(buffer) abort
     return ''
 endfunction
 
-" Given a buffer number, get a working directory and command to print the
-" classpath of the root project.
-"
-" Returns an empty string for the command if Maven is not detected.
+" Given a buffer number, build a command to print the classpath of the root
+" project. Returns an empty string if cannot build the command.
 function! ale#maven#BuildClasspathCommand(buffer) abort
     let l:executable = ale#maven#FindExecutable(a:buffer)
+    let l:project_root = ale#maven#FindProjectRoot(a:buffer)
 
-    if !empty(l:executable)
-        let l:project_root = ale#maven#FindProjectRoot(a:buffer)
-
-        if !empty(l:project_root)
-            return [
-            \   l:project_root,
-            \   ale#Escape(l:executable) . ' dependency:build-classpath'
-            \]
-        endif
+    if !empty(l:executable) && !empty(l:project_root)
+        return ale#path#CdString(l:project_root)
+        \ . l:executable . ' dependency:build-classpath'
     endif
 
-    return ['', '']
+    return ''
 endfunction

autoload/ale/path.vim

@@ -77,6 +77,26 @@ function! ale#path#ResolveLocalPath(buffer, search_string, global_fallback) abor
     return l:path
 endfunction
 
+" Output 'cd <directory> && '
+" This function can be used changing the directory for a linter command.
+function! ale#path#CdString(directory) abort
+    if has('win32')
+        return 'cd /d ' . ale#Escape(a:directory) . ' && '
+    endif
+
+    return 'cd ' . ale#Escape(a:directory) . ' && '
+endfunction
+
+" Output 'cd <buffer_filename_directory> && '
+" This function can be used changing the directory for a linter command.
+function! ale#path#BufferCdString(buffer) abort
+    if has('win32')
+        return 'cd /d %s:h && '
+    endif
+
+    return 'cd %s:h && '
+endfunction
+
 " Return 1 if a path is an absolute path.
 function! ale#path#IsAbsolute(filename) abort
     if has('win32') && a:filename[:0] is# '\'

doc/ale-bazel.txt

@@ -1,28 +0,0 @@
-===============================================================================
-ALE Bazel Integration                                       *ale-bazel-options*
-
-===============================================================================
-buildifier                                               *ale-bazel-buildifier*
-
-g:ale_bazel_buildifier_executable           *g:ale_bazel_buildifier_executable*
-                                            *b:ale_bazel_buildifier_executable*
-  Type: |String|
-  Default: `'buildifier'`
-
-  See |ale-integrations-local-executables|
-
-
-g:ale_bazel_buildifier_options                 *g:ale_bazel_buildifier_options*
-                                               *b:ale_bazel_buildifier_options*
-  Type: |String|
-  Default: `''`
-
-  This variable can be set to pass extra options to buildifier.
-
-
-g:ale_bazel_buildifier_use_global           *g:ale_bazel_buildifier_use_global*
-                                            *b:ale_bazel_buildifier_use_global*
-  Type: |Number|
-  Default: `get(g:, 'ale_use_global_executables', 0)`
-
-  See |ale-integrations-local-executables|

doc/ale-c.txt

@@ -202,45 +202,7 @@ g:ale_c_clangformat_options                       *g:ale_c_clangformat_options*
   Type: |String|
   Default: `''`
 
-  This variable can be changed to modify flags given to clang-format.
-
-
-g:ale_c_clangformat_style_option             *g:ale_c_clangformat_style_option*
-                                             *b:ale_c_clangformat_style_option*
-  Type: |String|
-  Default: `''`
-
-  This variable can be changed to modify only the style flag given to
-  clang-format. The contents of the variable are passed directly to the -style
-  flag of clang-format.
-
-  Example: >
-      {
-    \ BasedOnStyle:                        Microsoft,
-    \ ColumnLimit:                         80,
-    \ AllowShortBlocksOnASingleLine:       Always,
-    \ AllowShortFunctionsOnASingleLine:    Inline,
-    \ }
-<
-  If you set this variable, ensure you don't modify -style in
-  |g:ale_c_clangformat_options|, as this will cause clang-format to error.
-
-
-g:ale_c_clangformat_use_local_file         *g:ale_c_clangformat_use_local_file*
-                                           *b:ale_c_clangformat_use_local_file*
-  Type: |Number|
-  Default: `0`
-
-  This variable can be changed to modify whether to use a local .clang-format
-  file. If the file is found, the flag '-style=file' is passed to clang-format
-  and any options configured via |g:ale_c_clangformat_style_option| are not
-  passed.
-
-  If this option is enabled but no .clang-format file is found, default back to
-  |g:ale_c_clangformat_style_option|, if it set.
-
-  If you set this variable, ensure you don't modify -style in
-  |g:ale_c_clangformat_options|, as this will cause clang-format to error.
+  This variable can be change to modify flags given to clang-format.
 
 
 ===============================================================================

doc/ale-development.txt

@@ -311,7 +311,6 @@ The full list of commands that will be temporarily defined for linter tests
 given the above setup are as follows.
 
 `GivenCommandOutput [...]`         - Define output for ale#command#Run.
-`AssertLinterCwd cwd`              - Check the `cwd` for the linter.
 `AssertLinter executable, command` - Check the executable and command.
 `AssertLinterNotExecuted`          - Check that linters will not be executed.
 `AssertLSPLanguage language`       - Check the language given to an LSP server.
@@ -358,7 +357,6 @@ The full list of commands that will be temporarily defined for fixer tests
 given the above setup are as follows.
 
 `GivenCommandOutput [...]`         - Define output for ale#command#Run.
-`AssertFixerCwd cwd`               - Check the `cwd` for the fixer.
 `AssertFixer results`              - Check the fixer results
 `AssertFixerNotExecuted`           - Check that fixers will not be executed.
 

doc/ale-erlang.txt

@@ -71,26 +71,6 @@ g:ale_erlang_erlc_options                           *g:ale_erlang_erlc_options*
   or `-pa`.
 
 
--------------------------------------------------------------------------------
-erlfmt                                                      *ale-erlang-erlfmt*
-
-g:ale_erlang_erlfmt_executable                 *g:ale_erlang_erlfmt_executable*
-                                               *b:ale_erlang_erlfmt_executable*
-  Type: |String|
-  Default: `'erlfmt'`
-
-  This variable can be changed to specify the erlfmt executable.
-
-
-g:ale_erlang_erlfmt_options                       *g:ale_erlang_erlfmt_options*
-                                                  *b:ale_erlang_erlfmt_options*
-  Type: |String|
-  Default: `''`
-
-  This variable controls additional parameters passed to `erlfmt`, such as
-  `--insert-pragma` or `--print-width`.
-
-
 -------------------------------------------------------------------------------
 syntaxerl                                                *ale-erlang-syntaxerl*
 

doc/ale-ocaml.txt

@@ -10,21 +10,6 @@ merlin                                                       *ale-ocaml-merlin*
   detailed instructions
   (https://github.com/the-lambda-church/merlin/wiki/vim-from-scratch).
 
-===============================================================================
-ocamllsp                                                   *ale-ocaml-ocamllsp*
-
-  The `ocaml-lsp-server` is the official OCaml implementation of the Language
-  Server Protocol. See the installation instructions:
-  https://github.com/ocaml/ocaml-lsp#installation
-
-g:ale_ocaml_ocamllsp_use_opam                   *g:ale_ocaml_ocamllsp_use_opam*
-                                                *b:ale_ocaml_ocamllsp_use_opam*
-  Type: |Number|
-  Default: `get(g:, 'ale_ocaml_ocamllsp_use_opam', 1)`
-
-  This variable can be set to change whether or not opam is used to execute
-  the language server.
-
 ===============================================================================
 ols                                                             *ale-ocaml-ols*
 

doc/ale-ruby.txt

@@ -41,11 +41,6 @@ g:ale_ruby_debride_options                         *g:ale_ruby_debride_options*
   This variable can be changed to modify flags given to debride.
 
 
-===============================================================================
-prettier                                                    *ale-ruby-prettier*
-
-See |ale-javascript-prettier| for information about the available options.
-
 
 ===============================================================================
 rails_best_practices                            *ale-ruby-rails_best_practices*

doc/ale-supported-languages-and-tools.txt

@@ -43,8 +43,6 @@ Notes:
   * `shfmt`
 * Bats
   * `shellcheck`
-* Bazel
-  * `buildifier`
 * BibTeX
   * `bibclean`
 * Bourne Shell
@@ -150,10 +148,8 @@ Notes:
   * `ruumba`
 * Erlang
   * `SyntaxErl`
-  * `dialyzer`
   * `elvis`!!
   * `erlc`
-  * `erlfmt`
 * Fish
   * `fish` (-n flag)
   * `fish_indent`
@@ -333,7 +329,6 @@ Notes:
 * OCaml
   * `merlin` (see |ale-ocaml-merlin|)
   * `ocamlformat`
-  * `ocamllsp`
   * `ocp-indent`
   * `ols`
 * OpenApi
@@ -436,7 +431,6 @@ Notes:
 * Ruby
   * `brakeman`
   * `debride`
-  * `prettier`
   * `rails_best_practices`!!
   * `reek`
   * `rubocop`

doc/ale.txt

@@ -342,12 +342,6 @@ the buffers being checked.
 When a |Dictionary| is returned for an |ALEFix| callback, the following keys
 are supported for running the commands.
 
-  `cwd`                 An optional |String| for setting the working directory
-                      for the command.
-
-                      If not set, or `v:null`, the `cwd` of the last command
-                      that spawn this one will be used.
-
   `command`             A |String| for the command to run. This key is required.
 
                       When `%t` is included in a command string, a temporary
@@ -653,8 +647,7 @@ Hover information can be displayed in the preview window instead by setting
 |g:ale_hover_to_preview| to `1`.
 
 When using Neovim, if |g:ale_hover_to_floating_preview| or |g:ale_floating_preview|
-is set to 1, the hover information will show in a floating window. And
-|g:ale_floating_window_border| for the border setting.
+is set to 1, the hover information will show in a floating window.
 
 For Vim 8.1+ terminals, mouse hovering is disabled by default. Enabling
 |balloonexpr| commands in terminals can cause scrolling issues in terminals,
@@ -964,8 +957,8 @@ g:ale_default_navigation                             *g:ale_default_navigation*
   buffer, such as for |ALEFindReferences|, or |ALEGoToDefinition|.
 
 
-g:ale_detail_to_floating_preview             *g:ale_detail_to_floating_preview*
-                                             *b:ale_detail_to_floating_preview*
+g:ale_detail_to_floating_preview                            *g:ale_detail_to_floating_preview*
+                                                            *b:ale_detail_to_floating_preview*
   Type: |Number|
   Default: `0`
 
@@ -1196,7 +1189,7 @@ g:ale_fix_on_save_ignore                             *g:ale_fix_on_save_ignore*
   let g:ale_fix_on_save_ignore = [g:AddBar]
 <
 
-g:ale_floating_preview                                 *g:ale_floating_preview*
+g:ale_floating_preview                                       *g:ale_floating_preview*
 
   Type: |Number|
   Default: `0`
@@ -1206,19 +1199,6 @@ g:ale_floating_preview                                 *g:ale_floating_preview*
   |g:ale_detail_to_floating_preview| to `1`.
 
 
-g:ale_floating_window_border                       *g:ale_floating_window_border*
-
-  Type: |List|
-  Default: `['|', '-', '+', '+', '+', '+']`
-
-  When set to `[]`, window borders are disabled. The elements in the list set
-  the horizontal, top, top-left, top-right, bottom-right and bottom-left
-  border characters, respectively.
-
-  If the terminal supports Unicode, you might try setting the value to
-  ` ['│', '─', '╭', '╮', '╯', '╰']`, to make it look nicer.
-
-
 g:ale_history_enabled                                   *g:ale_history_enabled*
 
   Type: |Number|
@@ -1277,8 +1257,8 @@ g:ale_hover_to_preview                                 *g:ale_hover_to_preview*
   instead of in balloons or the message line.
 
 
-g:ale_hover_to_floating_preview               *g:ale_hover_to_floating_preview*
-                                              *b:ale_hover_to_floating_preview*
+g:ale_hover_to_floating_preview                       *g:ale_hover_to_floating_preview*
+                                                      *b:ale_hover_to_floating_preview*
   Type: |Number|
   Default: `0`
 
@@ -1738,6 +1718,24 @@ g:ale_lsp_suggestions                                   *g:ale_lsp_suggestions*
   addition to warnings and errors.
 
 
+g:ale_lsp_root                                                 *g:ale_lsp_root*
+                                                               *b:ale_lsp_root*
+
+  Type: |Dictionary| or |String|
+  Default: {}
+
+  This option is used to determine the project root for the LSP linter. If the
+  value is a |Dictionary|, it maps a linter to either a string containing the
+  project root or a |Funcref| to call to look up the root. The funcref is
+  provided the buffer number as its argument.
+
+  The buffer-specific variable may additionally be a string containing the
+  project root itself.
+
+  If neither variable yields a result, a linter-specific function is invoked to
+  detect a project root. If this, too, yields no result, the linter is disabled.
+
+
 g:ale_max_buffer_history_size                   *g:ale_max_buffer_history_size*
 
   Type: |Number|
@@ -1882,25 +1880,6 @@ g:ale_rename_tsserver_find_in_strings   *g:ale_rename_tsserver_find_in_strings*
   `1`.
 
 
-g:ale_root                                                         *g:ale_root*
-                                                                   *b:ale_root*
-
-  Type: |Dictionary| or |String|
-  Default: {}
-
-  This option is used to determine the project root for a linter. If the value
-  is a |Dictionary|, it maps a linter to either a |String| containing the
-  project root or a |Funcref| to call to look up the root. The |Funcref| is
-  provided the buffer number as its argument.
-
-  The buffer-specific variable may additionally be a string containing the
-  project root itself.
-
-  If neither variable yields a result, a linter-specific function is invoked to
-  detect a project root. If this, too, yields no result, and the linter is an
-  LSP linter, it will not run.
-
-
 g:ale_set_balloons                                         *g:ale_set_balloons*
                                                            *b:ale_set_balloons*
 
@@ -2635,8 +2614,6 @@ documented in additional help files.
     gawk..................................|ale-awk-gawk|
   bats....................................|ale-bats-options|
     shellcheck............................|ale-bats-shellcheck|
-  bazel...................................|ale-bazel-options|
-    buildifier............................|ale-bazel-buildifier|
   bib.....................................|ale-bib-options|
     bibclean..............................|ale-bib-bibclean|
   c.......................................|ale-c-options|
@@ -2718,7 +2695,6 @@ documented in additional help files.
     dialyzer..............................|ale-erlang-dialyzer|
     elvis.................................|ale-erlang-elvis|
     erlc..................................|ale-erlang-erlc|
-    erlfmt................................|ale-erlang-erlfmt|
     syntaxerl.............................|ale-erlang-syntaxerl|
   eruby...................................|ale-eruby-options|
     ruumba................................|ale-eruby-ruumba|
@@ -2867,7 +2843,6 @@ documented in additional help files.
     uncrustify............................|ale-objcpp-uncrustify|
   ocaml...................................|ale-ocaml-options|
     merlin................................|ale-ocaml-merlin|
-    ocamllsp..............................|ale-ocaml-ocamllsp|
     ols...................................|ale-ocaml-ols|
     ocamlformat...........................|ale-ocaml-ocamlformat|
     ocp-indent............................|ale-ocaml-ocp-indent|
@@ -2956,7 +2931,6 @@ documented in additional help files.
   ruby....................................|ale-ruby-options|
     brakeman..............................|ale-ruby-brakeman|
     debride...............................|ale-ruby-debride|
-    prettier..............................|ale-ruby-prettier|
     rails_best_practices..................|ale-ruby-rails_best_practices|
     reek..................................|ale-ruby-reek|
     rubocop...............................|ale-ruby-rubocop|
@@ -3599,12 +3573,6 @@ ale#command#Run(buffer, command, callback, [options])       *ale#command#Run()*
 <
   The following `options` can be provided.
 
-    `cwd`               - An optional |String| for setting the working directory
-                        for the command, just as per |ale#linter#Define|.
-
-                        If not set, or `v:null`, the `cwd` of the last command
-                        that spawned this one will be used.
-
     `output_stream`     - Either `'stdout'`, `'stderr'`, `'both'`, or
                         `'none`' for selecting which output streams to read
                         lines from.
@@ -3830,33 +3798,10 @@ ale#linter#Define(filetype, linter)                       *ale#linter#Define()*
 
                          The result can be computed with |ale#command#Run()|.
 
-                         The command string can be formatted with format
-                         markers. See |ale-command-format-strings|.
-
                          This command will be fed the lines from the buffer to
                          check, and will produce the lines of output given to
                          the `callback`.
 
-  `cwd`                    An optional |String| for setting the working
-                         directory for the command, or a |Funcref| for a
-                         function to call for computing the command, accepting
-                         a buffer number. The working directory can be
-                         specified as a format string for determining the path
-                         dynamically. See |ale-command-format-strings|.
-
-                         To set the working directory to the directory
-                         containing the file you're checking, you should
-                         probably use `'%s:h'` as the option value.
-
-                         If this option is absent or the string is empty, the
-                         `command` will be run with no determined working
-                         directory in particular.
-
-                         The directory specified with this option will be used
-                         as the default working directory for all commands run
-                         in a chain with |ale#command#Run()|, unless otherwise
-                         specified.
-
   `output_stream`          A |String| for the output stream the lines of output
                          should be read from for the command which is run. The
                          accepted values are `'stdout'`, `'stderr'`, and

plugin/ale.vim

@@ -87,6 +87,9 @@ let g:ale_lint_on_save = get(g:, 'ale_lint_on_save', 1)
 " This flag can be set to 1 to enable linting when the filetype is changed.
 let g:ale_lint_on_filetype_changed = get(g:, 'ale_lint_on_filetype_changed', 1)
 
+" This Dictionary configures the default LSP roots for various linters.
+let g:ale_lsp_root = get(g:, 'ale_lsp_root', {})
+
 " If set to 1, hints and suggestion from LSP servers and tsserver will be shown.
 let g:ale_lsp_suggestions = get(g:, 'ale_lsp_suggestions', 0)
 
@@ -101,9 +104,6 @@ let g:ale_enabled = get(g:, 'ale_enabled', 1)
 " mapping filename paths from one system to another.
 let g:ale_filename_mappings = get(g:, 'ale_filename_mappings', {})
 
-" This Dictionary configures the default project roots for various linters.
-let g:ale_root = get(g:, 'ale_root', {})
-
 " These flags dictates if ale uses the quickfix or the loclist (loclist is the
 " default, quickfix overrides loclist).
 let g:ale_set_loclist = get(g:, 'ale_set_loclist', 1)
@@ -150,11 +150,6 @@ let g:ale_hover_to_floating_preview = get(g:, 'ale_hover_to_floating_preview', 0
 " Detail uses floating windows in Neovim
 let g:ale_detail_to_floating_preview = get(g:, 'ale_detail_to_floating_preview', 0)
 
-" Border setting for floating preview windows in Neovim
-" The element in the list presents - horizontal, top, top-left, top-right,
-" bottom-right and bottom-left
-let g:ale_floating_window_border = get(g:, 'ale_floating_window_border', ['|', '-', '+', '+', '+', '+'])
-
 " This flag can be set to 0 to disable warnings for trailing whitespace
 let g:ale_warn_about_trailing_whitespace = get(g:, 'ale_warn_about_trailing_whitespace', 1)
 " This flag can be set to 0 to disable warnings for trailing blank lines

supported-tools.md

@@ -52,8 +52,6 @@ formatting.
   * [shfmt](https://github.com/mvdan/sh)
 * Bats
   * [shellcheck](https://www.shellcheck.net/)
-* Bazel
-  * [buildifier](https://github.com/bazelbuild/buildtools)
 * BibTeX
   * [bibclean](http://ftp.math.utah.edu/pub/bibclean/)
 * Bourne Shell
@@ -146,7 +144,7 @@ formatting.
   * [credo](https://github.com/rrrene/credo)
   * [dialyxir](https://github.com/jeremyjh/dialyxir) :floppy_disk:
   * [dogma](https://github.com/lpil/dogma) :floppy_disk:
-  * [elixir-ls](https://github.com/elixir-lsp/elixir-ls) :warning:
+  * [elixir-ls](https://github.com/JakeBecker/elixir-ls) :warning:
   * [mix](https://hexdocs.pm/mix/Mix.html) :warning: :floppy_disk:
 * Elm
   * [elm-format](https://github.com/avh4/elm-format)
@@ -159,10 +157,8 @@ formatting.
   * [ruumba](https://github.com/ericqweinstein/ruumba)
 * Erlang
   * [SyntaxErl](https://github.com/ten0s/syntaxerl)
-  * [dialyzer](http://erlang.org/doc/man/dialyzer.html)
   * [elvis](https://github.com/inaka/elvis) :floppy_disk:
   * [erlc](http://erlang.org/doc/man/erlc.html)
-  * [erlfmt](https://github.com/WhatsApp/erlfmt)
 * Fish
   * fish [-n flag](https://linux.die.net/man/1/fish)
   * [fish_indent](https://fishshell.com/docs/current/cmds/fish_indent.html)
@@ -342,7 +338,6 @@ formatting.
 * OCaml
   * [merlin](https://github.com/the-lambda-church/merlin) see `:help ale-ocaml-merlin` for configuration instructions
   * [ocamlformat](https://github.com/ocaml-ppx/ocamlformat)
-  * [ocamllsp](https://github.com/ocaml/ocaml-lsp)
   * [ocp-indent](https://github.com/OCamlPro/ocp-indent)
   * [ols](https://github.com/freebroccolo/ocaml-language-server)
 * OpenApi
@@ -445,7 +440,6 @@ formatting.
 * Ruby
   * [brakeman](http://brakemanscanner.org/) :floppy_disk:
   * [debride](https://github.com/seattlerb/debride) :floppy_disk:
-  * [prettier](https://github.com/prettier/plugin-ruby)
   * [rails_best_practices](https://github.com/flyerhzm/rails_best_practices) :floppy_disk:
   * [reek](https://github.com/troessner/reek)
   * [rubocop](https://github.com/bbatsov/rubocop)

test/command_callback/test_ansible_lint_command_callback.vader

@@ -7,16 +7,11 @@ After:
   unlet! b:executable
   call ale#assert#TearDownLinterTest()
 
-Execute(The ansible_lint version <5.0.0 command callback should return default string):
-  GivenCommandOutput ['v4.1.2']
+Execute(The ansible_lint command callback should return default string):
   AssertLinter 'ansible-lint', ale#Escape('ansible-lint') . ' -p %t'
 
-Execute(The ansible_lint version >=5.0.0 command callback should return default string):
-  GivenCommandOutput ['v5.1.2']
-  AssertLinter 'ansible-lint', ale#Escape('ansible-lint') . ' --parseable-severity -x yaml'
-
 Execute(The ansible_lint executable should be configurable):
   let g:ale_ansible_ansible_lint_executable = '~/.local/bin/ansible-lint'
-  GivenCommandOutput ['v4.1.2']
+
   AssertLinter '~/.local/bin/ansible-lint',
   \ ale#Escape('~/.local/bin/ansible-lint') . ' -p %t'

test/command_callback/test_c_cppcheck_command_callbacks.vader

@@ -17,14 +17,14 @@ Execute(The executable should be configurable):
 
   let b:ale_c_cppcheck_executable = 'foobar'
 
-  AssertLinterCwd ''
   AssertLinter 'foobar', ale#Escape('foobar') . b:command_tail
 
 Execute(cppcheck for C should detect compile_commands.json files):
   call ale#test#SetFilename('cppcheck_paths/one/foo.c')
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cppcheck_paths/one')
-  AssertLinter 'cppcheck', ale#Escape('cppcheck')
+  AssertLinter 'cppcheck',
+  \ ale#path#CdString(ale#path#Simplify(g:dir . '/cppcheck_paths/one'))
+  \   . ale#Escape('cppcheck')
   \   . ' -q --language=c'
   \   . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
   \   . ' --project=' . ale#Escape('compile_commands.json')
@@ -33,8 +33,9 @@ Execute(cppcheck for C should detect compile_commands.json files):
 Execute(cppcheck for C should detect compile_commands.json files in build directories):
   call ale#test#SetFilename('cppcheck_paths/with_build_dir/foo.cpp')
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cppcheck_paths/with_build_dir')
-  AssertLinter 'cppcheck', ale#Escape('cppcheck')
+  AssertLinter 'cppcheck',
+  \ ale#path#CdString(ale#path#Simplify(g:dir . '/cppcheck_paths/with_build_dir'))
+  \   . ale#Escape('cppcheck')
   \   . ' -q --language=c'
   \   . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
   \   . ' --project=' . ale#Escape(ale#path#Simplify('build/compile_commands.json'))
@@ -57,8 +58,9 @@ Execute(cppcheck for C should ignore compile_commands.json file if buffer is mod
   set buftype=
   set modified
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cppcheck_paths/one')
-  AssertLinter 'cppcheck', ale#Escape('cppcheck')
+  AssertLinter 'cppcheck',
+  \   ale#path#CdString(ale#path#Simplify(g:dir . '/cppcheck_paths/one'))
+  \   . ale#Escape('cppcheck')
   \   . ' -q --language=c'
   \   . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
   \   . ' --enable=style'

test/command_callback/test_cargo_command_callbacks.vader

@@ -118,23 +118,20 @@ Execute(--all-features should be used when g:ale_rust_cargo_default_feature_beha
   GivenCommandOutput ['cargo 0.22.0 (3423351a5 2017-10-06)']
   AssertLinter 'cargo', [ale#Escape('cargo') . ' --version', 'cargo check --frozen --message-format=json -q --all-features']
 
-Execute(Cargo should run from the crate directory when set to avoid the workspace):
+Execute(When a crate belongs to a workspace we should cd into the crate):
   let g:ale_rust_cargo_avoid_whole_workspace = 1
   call ale#test#SetFilename('cargo_workspace_paths/subpath/test.rs')
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cargo_workspace_paths/subpath')
-  call ale#semver#ResetVersionCache()
   AssertLinter 'cargo', [
   \ ale#Escape('cargo') . ' --version',
-  \ 'cargo check --frozen --message-format=json -q',
+  \ 'cd ' . ale#Escape(ale#path#Simplify(g:dir . '/cargo_workspace_paths/subpath')) . ' && '
+  \   . 'cargo check --frozen --message-format=json -q',
   \]
 
-Execute(Cargo should not run from the crate directory when not set to avoid the workspace):
+Execute(When a crate belongs to a workspace we chdir into the crate, unless we disabled it):
   let g:ale_rust_cargo_avoid_whole_workspace = 0
   call ale#test#SetFilename('cargo_workspace_paths/subpath/test.rs')
 
-  AssertLinterCwd ''
-  call ale#semver#ResetVersionCache()
   AssertLinter 'cargo', [
   \ ale#Escape('cargo') . ' --version',
   \ 'cargo check --frozen --message-format=json -q',

test/command_callback/test_cpp_cppcheck_command_callbacks.vader

@@ -17,14 +17,14 @@ Execute(The executable should be configurable):
 
   let b:ale_cpp_cppcheck_executable = 'foobar'
 
-  AssertLinterCwd ''
   AssertLinter 'foobar', ale#Escape('foobar') . b:command_tail
 
 Execute(cppcheck for C++ should detect compile_commands.json files):
   call ale#test#SetFilename('cppcheck_paths/one/foo.cpp')
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cppcheck_paths/one')
-  AssertLinter 'cppcheck', ale#Escape('cppcheck')
+  AssertLinter 'cppcheck',
+  \ ale#path#CdString(ale#path#Simplify(g:dir . '/cppcheck_paths/one'))
+  \   . ale#Escape('cppcheck')
   \   . ' -q --language=c++'
   \   . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
   \   . ' --project=' . ale#Escape('compile_commands.json')
@@ -33,8 +33,9 @@ Execute(cppcheck for C++ should detect compile_commands.json files):
 Execute(cppcheck for C++ should detect compile_commands.json files in build directories):
   call ale#test#SetFilename('cppcheck_paths/with_build_dir/foo.cpp')
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cppcheck_paths/with_build_dir')
-  AssertLinter 'cppcheck', ale#Escape('cppcheck')
+  AssertLinter 'cppcheck',
+  \ ale#path#CdString(ale#path#Simplify(g:dir . '/cppcheck_paths/with_build_dir'))
+  \   . ale#Escape('cppcheck')
   \   . ' -q --language=c++'
   \   . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
   \   . ' --project=' . ale#Escape(ale#path#Simplify('build/compile_commands.json'))
@@ -57,8 +58,9 @@ Execute(cppcheck for C++ should ignore compile_commands.json file if buffer is m
   set buftype=
   set modified
 
-  AssertLinterCwd ale#path#Simplify(g:dir . '/cppcheck_paths/one')
-  AssertLinter 'cppcheck', ale#Escape('cppcheck')
+  AssertLinter 'cppcheck',
+  \   ale#path#CdString(ale#path#Simplify(g:dir . '/cppcheck_paths/one'))
+  \   . ale#Escape('cppcheck')
   \   . ' -q --language=c++'
   \   . ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
   \   . ' --enable=style'

test/command_callback/test_cs_csc_command_callbacks.vader

@@ -5,38 +5,43 @@ After:
   call ale#assert#TearDownLinterTest()
 
 Execute(The csc linter should return the correct default command):
-  AssertLinterCwd expand('%:p:h')
-  AssertLinter 'csc', 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
+  AssertLinter 'csc', ale#path#CdString(g:dir)
+  \ . 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
 
 Execute(The options should be be used in the command):
   let g:ale_cs_csc_options = ''
 
-  AssertLinter 'csc', 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
+  AssertLinter 'csc', ale#path#CdString(g:dir)
+  \ . 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
 
 Execute(The souce path should be be used in the command):
   let g:ale_cs_csc_source = '../foo/bar'
 
-  AssertLinterCwd '../foo/bar'
-  AssertLinter 'csc', 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
+  AssertLinter 'csc', ale#path#CdString('../foo/bar')
+  \ . 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
 
 Execute(The list of search pathes for assemblies should be be used in the command if not empty):
   let g:ale_cs_csc_assembly_path = ['/usr/lib/mono', '../foo/bar']
 
-  AssertLinter 'csc', 'csc /unsafe'
+  AssertLinter 'csc', ale#path#CdString(g:dir)
+  \ . 'csc /unsafe'
   \ . ' /lib:' . ale#Escape('/usr/lib/mono') . ',' . ale#Escape('../foo/bar')
   \ . ' /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
 
   let g:ale_cs_csc_assembly_path = []
 
-  AssertLinter 'csc', 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
+  AssertLinter 'csc', ale#path#CdString(g:dir)
+  \ . 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
 
 Execute(The list of assemblies should be be used in the command if not empty):
   let g:ale_cs_csc_assemblies = ['foo.dll', 'bar.dll']
 
-  AssertLinter 'csc', 'csc /unsafe'
+  AssertLinter 'csc', ale#path#CdString(g:dir)
+  \ . 'csc /unsafe'
   \ . ' /r:' . ale#Escape('foo.dll') . ',' . ale#Escape('bar.dll')
   \ . ' /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
 
   let g:ale_cs_csc_assemblies = []
 
-  AssertLinter 'csc', 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')
+  AssertLinter 'csc', ale#path#CdString(g:dir)
+  \ . 'csc /unsafe /out:TEMP /t:module /recurse:' . ale#Escape('*.cs')

test/command_callback/test_cs_mcsc_command_callbacks.vader

@@ -5,38 +5,43 @@ After:
   call ale#assert#TearDownLinterTest()
 
 Execute(The mcsc linter should return the correct default command):
-  AssertLinterCwd expand('%:p:h')
-  AssertLinter 'mcs', 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
+  AssertLinter 'mcs', ale#path#CdString(g:dir)
+  \ . 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
 
 Execute(The options should be be used in the command):
   let g:ale_cs_mcsc_options = '-pkg:dotnet'
 
-  AssertLinter 'mcs', 'mcs -unsafe -pkg:dotnet -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
+  AssertLinter 'mcs', ale#path#CdString(g:dir)
+  \ . 'mcs -unsafe -pkg:dotnet -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
 
 Execute(The souce path should be be used in the command):
   let g:ale_cs_mcsc_source = '../foo/bar'
 
-  AssertLinterCwd '../foo/bar'
-  AssertLinter 'mcs', 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
+  AssertLinter 'mcs', ale#path#CdString('../foo/bar')
+  \ . 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
 
 Execute(The list of search pathes for assemblies should be be used in the command if not empty):
   let g:ale_cs_mcsc_assembly_path = ['/usr/lib/mono', '../foo/bar']
 
-  AssertLinter 'mcs', 'mcs -unsafe'
+  AssertLinter 'mcs', ale#path#CdString(g:dir)
+  \ . 'mcs -unsafe'
   \ . ' -lib:' . ale#Escape('/usr/lib/mono') . ',' . ale#Escape('../foo/bar')
   \ . ' -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
 
   let g:ale_cs_mcsc_assembly_path = []
 
-  AssertLinter 'mcs', 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
+  AssertLinter 'mcs', ale#path#CdString(g:dir)
+  \ . 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
 
 Execute(The list of assemblies should be be used in the command if not empty):
   let g:ale_cs_mcsc_assemblies = ['foo.dll', 'bar.dll']
 
-  AssertLinter 'mcs', 'mcs -unsafe'
+  AssertLinter 'mcs', ale#path#CdString(g:dir)
+  \ . 'mcs -unsafe'
   \ . ' -r:' . ale#Escape('foo.dll') . ',' . ale#Escape('bar.dll')
   \ . ' -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
 
   let g:ale_cs_mcsc_assemblies = []
 
-  AssertLinter 'mcs', 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')
+  AssertLinter 'mcs', ale#path#CdString(g:dir)
+  \ . 'mcs -unsafe -out:TEMP -t:module -recurse:' . ale#Escape('*.cs')

test/command_callback/test_dialyxir_command_callback.vader

@@ -1,16 +0,0 @@
-Before:
-  call ale#assert#SetUpLinterTest('elixir', 'dialyxir')
-  call ale#test#SetFilename('elixir_paths/mix_project/lib/app.ex')
-
-After:
-  call ale#assert#TearDownLinterTest()
-
-Execute(Builds dialyxir command with a normal project):
-  AssertLinterCwd ale#path#Simplify(g:dir . '/elixir_paths/mix_project')
-  AssertLinter 'mix', 'mix help dialyzer && mix dialyzer'
-
-Execute(Builds dialyxir command with an umbrella project):
-  call ale#test#SetFilename('elixir_paths/umbrella_project/apps/mix_project/lib/app.ex')
-
-  AssertLinterCwd ale#path#Simplify(g:dir . '/elixir_paths/umbrella_project')
-  AssertLinter 'mix', 'mix help dialyzer && mix dialyzer'