038e4a8c31
* Fix ansible-lint linter definition. Use ansible-lint's feature auto-detection instead of temporary file. For auto-detection to work, ansible project has to be also a git repository. Don't use yaml rules. These are checked by yamllint. Refactor pattern to work with ansible-lint >=5.0 version. Clean-up obsolete test cases. * Pull Request changes
103 lines
3.9 KiB
VimL
103 lines
3.9 KiB
VimL
" Authors: Bjorn Neergaard <bjorn@neersighted.com>, Vytautas Macionis <vytautas.macionis@manomail.de>
|
|
" Description: ansible-lint for ansible-yaml files
|
|
|
|
call ale#Set('ansible_ansible_lint_executable', 'ansible-lint')
|
|
|
|
function! ale_linters#ansible#ansible_lint#GetExecutable(buffer) abort
|
|
return ale#Var(a:buffer, 'ansible_ansible_lint_executable')
|
|
endfunction
|
|
|
|
function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
|
|
for l:line in a:lines[:10]
|
|
if match(l:line, '^Traceback') >= 0
|
|
return [{
|
|
\ 'lnum': 1,
|
|
\ 'text': 'An exception was thrown. See :ALEDetail',
|
|
\ 'detail': join(a:lines, "\n"),
|
|
\}]
|
|
endif
|
|
endfor
|
|
|
|
let l:version_group = ale#semver#GTE(a:version, [5, 0, 0]) ? '>=5.0.0' : '<5.0.0'
|
|
let l:output = []
|
|
|
|
if '>=5.0.0' is# l:version_group
|
|
" Matches patterns line the following:
|
|
" test.yml:3:148: syntax-check 'var' is not a valid attribute for a Play
|
|
" roles/test/tasks/test.yml:8: [package-latest] [VERY_LOW] Package installs should not use latest
|
|
" D:\test\tasks\test.yml:8: [package-latest] [VERY_LOW] package installs should not use latest
|
|
let l:pattern = '\v^(%([a-zA-Z]:)?[^:]+):(\d+):%((\d+):)? %(\[([-[:alnum:]]+)\]) %(\[([_[:alnum:]]+)\]) (.*)$'
|
|
let l:error_codes = { 'VERY_HIGH': 'E', 'HIGH': 'E', 'MEDIUM': 'W', 'LOW': 'W', 'VERY_LOW': 'W', 'INFO': 'I' }
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
if ale#path#IsBufferPath(a:buffer, l:match[1])
|
|
call add(l:output, {
|
|
\ 'lnum': l:match[2] + 0,
|
|
\ 'col': l:match[3] + 0,
|
|
\ 'text': l:match[6],
|
|
\ 'code': l:match[4],
|
|
\ 'type': l:error_codes[l:match[5]],
|
|
\})
|
|
endif
|
|
endfor
|
|
endif
|
|
|
|
if '<5.0.0' is# l:version_group
|
|
" Matches patterns line the following:
|
|
" test.yml:35: [EANSIBLE0002] Trailing whitespace
|
|
let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?: \[?([[:alnum:]]+)\]? (.*)$'
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
let l:code = l:match[4]
|
|
|
|
if l:code is# 'EANSIBLE0002'
|
|
\&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
|
|
" Skip warnings for trailing whitespace if the option is off.
|
|
continue
|
|
endif
|
|
|
|
if ale#path#IsBufferPath(a:buffer, l:match[1])
|
|
call add(l:output, {
|
|
\ 'lnum': l:match[2] + 0,
|
|
\ 'col': l:match[3] + 0,
|
|
\ 'text': l:match[5],
|
|
\ 'code': l:code,
|
|
\ 'type': l:code[:0] is# 'E' ? 'E' : 'W',
|
|
\})
|
|
endif
|
|
endfor
|
|
endif
|
|
|
|
return l:output
|
|
endfunction
|
|
|
|
function! ale_linters#ansible#ansible_lint#GetCommand(buffer, version) abort
|
|
let l:commands = {
|
|
\ '>=5.0.0': '%e --parseable-severity -x yaml',
|
|
\ '<5.0.0': '%e -p %t'
|
|
\}
|
|
let l:command = ale#semver#GTE(a:version, [5, 0]) ? l:commands['>=5.0.0'] : l:commands['<5.0.0']
|
|
|
|
return l:command
|
|
endfunction
|
|
|
|
call ale#linter#Define('ansible', {
|
|
\ 'name': 'ansible_lint',
|
|
\ 'aliases': ['ansible', 'ansible-lint'],
|
|
\ 'executable': function('ale_linters#ansible#ansible_lint#GetExecutable'),
|
|
\ 'command': {buffer -> ale#semver#RunWithVersionCheck(
|
|
\ buffer,
|
|
\ ale_linters#ansible#ansible_lint#GetExecutable(buffer),
|
|
\ '%e --version',
|
|
\ function('ale_linters#ansible#ansible_lint#GetCommand'),
|
|
\ )},
|
|
\ 'callback': {buffer, lines -> ale#semver#RunWithVersionCheck(
|
|
\ buffer,
|
|
\ ale_linters#ansible#ansible_lint#GetExecutable(buffer),
|
|
\ '%e --version',
|
|
\ {buffer, version -> ale_linters#ansible#ansible_lint#Handle(
|
|
\ buffer,
|
|
\ l:version,
|
|
\ lines)},
|
|
\ )},
|
|
\})
|