a6caa85a58
Although using %t to lint changes was desirable, many pylama checks use surrounding paths and file contents (e.g. C0103 module name, E0402 relative import beyond top, etc.) The more such errors I find during testing, the less %t seems like a good idea. Switch to %s. Also set `lint_file` to 1 and mark Pylama as a file linter in the docs. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
85 lines
3.2 KiB
Text
85 lines
3.2 KiB
Text
Before:
|
|
call ale#assert#SetUpLinterTest('python', 'pylama')
|
|
call ale#test#SetFilename('test.py')
|
|
|
|
let b:bin_dir = has('win32') ? 'Scripts' : 'bin'
|
|
let b:command_tail = ' %s'
|
|
|
|
After:
|
|
unlet! b:bin_dir
|
|
unlet! b:executable
|
|
unlet! b:command_tail
|
|
|
|
call ale#assert#TearDownLinterTest()
|
|
|
|
Execute(The pylama command callback should return a default):
|
|
AssertLinter 'pylama',
|
|
\ ale#path#BufferCdString(bufnr(''))
|
|
\ . ale#Escape('pylama') . b:command_tail
|
|
|
|
Execute(The option for disabling changing directories should work):
|
|
let g:ale_python_pylama_change_directory = 0
|
|
|
|
AssertLinter 'pylama', ale#Escape('pylama') . b:command_tail
|
|
|
|
Execute(The pylama executable should be configurable, and escaped properly):
|
|
let g:ale_python_pylama_executable = 'executable with spaces'
|
|
|
|
AssertLinter 'executable with spaces',
|
|
\ ale#path#BufferCdString(bufnr(''))
|
|
\ . ale#Escape('executable with spaces') . b:command_tail
|
|
|
|
Execute(The pylama command callback should let you set options):
|
|
let g:ale_python_pylama_options = '--some-option'
|
|
|
|
AssertLinter 'pylama',
|
|
\ ale#path#BufferCdString(bufnr(''))
|
|
\ . ale#Escape('pylama') . ' --some-option' . b:command_tail
|
|
|
|
Execute(The pylama command callback should switch directories to the detected project root):
|
|
silent execute 'file ' . fnameescape(g:dir . '/python_paths/no_virtualenv/subdir/foo/bar.py')
|
|
|
|
AssertLinter 'pylama',
|
|
\ ale#path#CdString(ale#path#Simplify(g:dir . '/python_paths/no_virtualenv/subdir'))
|
|
\ . ale#Escape('pylama') . b:command_tail
|
|
|
|
Execute(The pylama command callback shouldn't detect virtualenv directories where they don't exist):
|
|
silent execute 'file ' . fnameescape(g:dir . '/python_paths/no_virtualenv/subdir/foo/bar.py')
|
|
|
|
AssertLinter 'pylama',
|
|
\ ale#path#CdString(ale#path#Simplify(g:dir . '/python_paths/no_virtualenv/subdir'))
|
|
\ . ale#Escape('pylama') . b:command_tail
|
|
|
|
Execute(The pylama command callback should detect virtualenv directories and switch to the project root):
|
|
silent execute 'file ' . fnameescape(g:dir . '/python_paths/with_virtualenv/subdir/foo/bar.py')
|
|
|
|
let b:executable = ale#path#Simplify(
|
|
\ g:dir . '/python_paths/with_virtualenv/env/' . b:bin_dir . '/pylama'
|
|
\)
|
|
|
|
AssertLinter b:executable,
|
|
\ ale#path#CdString(ale#path#Simplify(g:dir . '/python_paths/with_virtualenv/subdir'))
|
|
\ . ale#Escape(b:executable) . b:command_tail
|
|
|
|
Execute(You should able able to use the global pylama instead):
|
|
silent execute 'file ' . fnameescape(g:dir . '/python_paths/with_virtualenv/subdir/foo/bar.py')
|
|
let g:ale_python_pylama_use_global = 1
|
|
|
|
AssertLinter 'pylama',
|
|
\ ale#path#CdString(ale#path#Simplify(g:dir . '/python_paths/with_virtualenv/subdir'))
|
|
\ . ale#Escape('pylama') . b:command_tail
|
|
|
|
Execute(Setting executable to 'pipenv' appends 'run pylama'):
|
|
let g:ale_python_pylama_executable = 'path/to/pipenv'
|
|
|
|
AssertLinter 'path/to/pipenv',
|
|
\ ale#path#BufferCdString(bufnr(''))
|
|
\ . ale#Escape('path/to/pipenv') . ' run pylama' . b:command_tail
|
|
|
|
Execute(Pipenv is detected when python_pylama_auto_pipenv is set):
|
|
let g:ale_python_pylama_auto_pipenv = 1
|
|
call ale#test#SetFilename('/testplugin/test/python_fixtures/pipenv/whatever.py')
|
|
|
|
AssertLinter 'pipenv',
|
|
\ ale#path#BufferCdString(bufnr(''))
|
|
\ . ale#Escape('pipenv') . ' run pylama' . b:command_tail
|