This repository has been archived on 2024-07-19. You can view files and clone it, but cannot push or open issues or pull requests.
ale/test/eslint-test-files
Kevin Locke 106c27644b
eslint: Use cwd from executable location to fix nested projects (#3222)
* Split FindNearestExecutable from FindExecutable

The path searching in ale#node#FindExecutable() will be useful for
eslint.  Refactor it into a separate function so it can be used without
regard for the state of the _use_global and _executable variables.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

* eslint: Set project root from local executable

Using the nearest directory with node_modules does not work correctly
for nested projects where the eslint dependencies are in the outer
project.  For example:
https://github.com/dense-analysis/ale/issues/3143#issuecomment-652452362

Adopt the behavior of SublimeLinter, which runs from project_root
determined by the presence of the eslint executable in node_modules/.bin
(or eslint in dependencies/devDependencies of package.json, which we can
add later as necessary).  See [NodeLinter#find_local_executable].

[NodeLinter#find_local_executable]: https://github.com/SublimeLinter/SublimeLinter/blob/056e6f6/lint/base_linter/node_linter.py#L109

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
2020-07-08 14:42:01 +01:00
..
app-with-eslint-d/node_modules/.bin Automatically use eslint_d for eslint, when available 2017-05-25 22:34:59 +01:00
node_modules/.bin Fix #421 Automatically detect create-react-app paths 2017-03-29 00:21:27 +01:00
other-app/subdir Fix #421 Automatically detect create-react-app paths 2017-03-29 00:21:27 +01:00
react-app eslint: Use cwd from executable location to fix nested projects (#3222) 2020-07-08 14:42:01 +01:00
package.json Fix #923 Use package.json as a last resort for eslint --fix 2017-09-12 09:10:37 +01:00