This repository has been archived on 2024-07-19. You can view files and clone it, but cannot push or open issues or pull requests.
ale/ale_linters/php
Adriaan Zonnenberg 6befe9e37c Fix PHP column matching for unexpected single quotes (#370)
* PHP: Fix column matching for unexpected single quotes

Unexpected single quotes resulted in an empty match, because PHP
surrounds the errors with quotes, and we check for the next quote to be
the ending delimiter.

For example: an unexpected string 'foo' would be presented as
`unexpected ''foo''`, and then the match would be `''`. The inner part
of that match is an empty string.

This adds a check for the keyword "expecting". Any quote after
"expecting" won't be matched, so we can use greedy matching instead of
non-greedy.

* PHP: Use "very magic"

The pattern started to get unreadable

Also replaced non-greedy matching (`\{-}`) by greedy matching, because
we don't need to match non-greedily anymore and it reads a little nicer.

* PHP: Add tests for column matches

And with that, also a test for unexpected single quotes.
2017-03-01 23:26:03 +00:00
..
hack.vim Copy all loclist items returned from handlers, and set up defaults for convenience 2017-02-26 14:51:22 +00:00
php.vim Fix PHP column matching for unexpected single quotes (#370) 2017-03-01 23:26:03 +00:00
phpcs.vim Copy all loclist items returned from handlers, and set up defaults for convenience 2017-02-26 14:51:22 +00:00
phpmd.vim Copy all loclist items returned from handlers, and set up defaults for convenience 2017-02-26 14:51:22 +00:00