refactor: use flags instead of positionals, reorganize cli init
All checks were successful
/ sast (push) Successful in 43s
/ tests (push) Successful in 45s
/ build (push) Successful in 47s

This commit is contained in:
Marc 2024-07-13 23:44:04 -04:00
parent 1720855a2d
commit 2b54cbb95b
Signed by: marc
GPG key ID: 048E042F22B5DC79

View file

@ -23,49 +23,57 @@ func SetupDatabaseConnection(cmd *cobra.Command, args []string) {
cmd.SetContext(context.WithValue(cmd.Context(), "db", db)) cmd.SetContext(context.WithValue(cmd.Context(), "db", db))
} }
var cli = &cobra.Command{ func NewCli() *cobra.Command {
Use: "cobble", cli := &cobra.Command{
Short: "Cobble is a simple SQL migration utility.", Use: "cobble",
} Short: "Cobble is a simple SQL migration utility.",
}
var up = &cobra.Command{ up := &cobra.Command{
Use: "up", Use: "up",
Short: "Applies migrations", Short: "Applies migrations",
PreRun: SetupDatabaseConnection, PreRun: SetupDatabaseConnection,
Run: func(cmd *cobra.Command, args []string) { Run: func(cmd *cobra.Command, args []string) {
db := cmd.Context().Value("db").(DB) db := cmd.Context().Value("db").(DB)
migrationRoot := args[0] migrationRoot := args[0]
migrationGraph, _ := NewMigrationGraphFromDirectory(migrationRoot) migrationGraph, _ := NewMigrationGraphFromDirectory(migrationRoot)
migrationHistory, _ := migrationGraph.GetLinearHistory() migrationHistory, _ := migrationGraph.GetLinearHistory()
for _, migration := range migrationHistory { for _, migration := range migrationHistory {
log.Printf("%s", migration.Name) log.Printf("%s", migration.Name)
if err := migration.Apply(db); err != nil { if err := migration.Apply(db); err != nil {
os.Exit(1) os.Exit(1)
}
} }
} },
}, }
}
var inspect = &cobra.Command{ inspect := &cobra.Command{
Use: "inspect", Use: "inspect",
Short: "Prints the nth migration in the history", Short: "Prints the nth migration in the history",
Run: func(cmd *cobra.Command, args []string) { Run: func(cmd *cobra.Command, args []string) {
migrationRoot := args[0] migrationRoot, _ := cmd.Flags().GetString("root")
migrationIndex, _ := strconv.Atoi(args[1]) migrationIndex, _ := cmd.Flags().GetInt("index")
migrationGraph, _ := NewMigrationGraphFromDirectory(migrationRoot) migrationGraph, _ := NewMigrationGraphFromDirectory(migrationRoot)
migrationHistory, _ := migrationGraph.GetLinearHistory() migrationHistory, _ := migrationGraph.GetLinearHistory()
migration := migrationHistory[migrationIndex] migration := migrationHistory[migrationIndex]
sql, _ := migration.Sql() sql, _ := migration.Sql()
fmt.Printf("%s:\n%s", migration.Name, sql) fmt.Printf("%s:\n%s", migration.Name, sql)
}, },
} }
func main() {
cli.AddCommand(up) cli.AddCommand(up)
cli.AddCommand(inspect) cli.AddCommand(inspect)
if err := cli.Execute(); err != nil { cli.PersistentFlags().StringP("root", "r", "./migrations", "Root directory where migration files live.")
inspect.PersistentFlags().IntP("index", "i", 0, "Zero-based index of the migration to target.")
inspect.MarkFlagRequired("index")
return cli
}
func main() {
if err := NewCli().Execute(); err != nil {
log.Fatal(err) log.Fatal(err)
os.Exit(1) os.Exit(1)
} }