marc/packwatch
Archived
1
0
Fork 0
Code Issues 5 Pull requests 10 Projects Releases 2 Packages Wiki Activity

refactor: error behaviour on limit exceeded

Browse source
This commit is contained in:
Marc Cataford 2021-02-19 09:49:13 -05:00
parent ef6fb52498
commit dd8958875f
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/__tests__/index.test.ts
View file

@ -204,7 +204,9 @@ describe('Packwatch', () => {
unpackedSize: '140B', unpackedSize: '140B',
}) })
await packwatch({ cwd: workspacePath }) await expect(async () =>
packwatch({ cwd: workspacePath }),
).rejects.toThrow('PACKAGE_EXCEEDS_LIMIT')
expect(mockLogger.mock.calls).toHaveLength(1) expect(mockLogger.mock.calls).toHaveLength(1)
expect(mockLogger.mock.calls[0][0]).toEqual( expect(mockLogger.mock.calls[0][0]).toEqual(
expect.stringMatching( expect.stringMatching(

8
src/index.ts
View file

@ -36,11 +36,9 @@ export default async function packwatch({
console.log( console.log(
'❗ It looks like you ran PackWatch without a manifest. To prevent accidental passes in CI or hooks, packwatch will terminate with an error. If you are running packwatch for the first time in your project, this is expected!', '❗ It looks like you ran PackWatch without a manifest. To prevent accidental passes in CI or hooks, packwatch will terminate with an error. If you are running packwatch for the first time in your project, this is expected!',
) )
throw new Error('NO_MANIFEST_NO_UPDATE')
} }
// If the update flag wasn't specified, exit with a non-zero code so we return
// don't "accidentally" pass CI builds if the manifest didn't exist
if (!isUpdatingManifest) throw new Error()
else return
} }
const previousStats = getPreviousPackageStats(cwd) const previousStats = getPreviousPackageStats(cwd)
@ -79,7 +77,7 @@ export default async function packwatch({
console.log( console.log(
`🔥🔥📦🔥🔥 Your package exceeds the limit set in ${MANIFEST_FILENAME}! ${packageSize} > ${limit}\nEither update the limit by using the --update-manifest flag or trim down your packed files!`, `🔥🔥📦🔥🔥 Your package exceeds the limit set in ${MANIFEST_FILENAME}! ${packageSize} > ${limit}\nEither update the limit by using the --update-manifest flag or trim down your packed files!`,
) )
return throw new Error('PACKAGE_EXCEEDS_LIMIT')
} }
/* /*