Ability to set "ok interval" #18

New issue

Open

opened 2020-04-24 13:25:07 +00:00 by timsuchanek · 1 comment

timsuchanek commented

2020-04-24 13:25:07 +00:00

(Migrated from github.com)

As of now, we can CI failures, as soon as we wrote some code that just adds 0.1kB. It would be great to set a higher granularity. A few possible options:

Being able to set granularity to kB
Being able to set a "max higher" amount, which will end up in warnings

The reason we don't just increase the kB, is that it then says, that our bundle shrank, which is also not true.

As of now, we can CI failures, as soon as we wrote some code that just adds 0.1kB. It would be great to set a higher granularity. A few possible options: 1. Being able to set granularity to kB 2. Being able to set a "max higher" amount, which will end up in warnings The reason we don't just increase the kB, is that it then says, that our bundle shrank, which is also not true.

👍 2

mcataford commented

2020-05-02 02:10:56 +00:00

(Migrated from github.com)

Hi @timsuchanek!

I jotted down some best practices that might help your use case, especially around setting the threshold!

Let me know what you think.

I'm currently planning out work to rejig Packwatch to add in more customization, if you have any suggestions re:what would be useful in your workflow, please let me know!

Hi @timsuchanek! I jotted down some best practices that might help your use case, especially around [setting the threshold](https://github.com/mcataford/packwatch/blob/master/BEST_PRACTICES.md#setting-sensible-thresholds)! Let me know what you think. I'm currently planning out work to rejig Packwatch to add in more customization, if you have any suggestions re:what would be useful in your workflow, please let me know!

This repo is archived. You cannot comment on issues.