marc/rotini
Archived
1
0
Fork 0
Code Issues 4 Pull requests 10 Projects Releases Packages Wiki Activity

feat(frontend): file downloads #23

Merged
mcataford merged 6 commits from feat/download-files into main 2023-08-18 23:01:24 +00:00
Conversation 0 Commits 6 Files changed 6 +126 -12
mcataford commented 2023-08-18 05:29:18 +00:00 (Migrated from github.com)
Copy link

This introduces functionality for the download buttons in the main filelist and the file details panel.

⚠️ Testing flaw

Testing around the virtual anchor used to trigger downloads proved tricky, FIXME comments were left to tag the two cases that are lackluster.

Because the action of fetching from the API is covered and QA covered the interaction, this is considered "accepted risk".

This introduces functionality for the download buttons in the main filelist and the file details panel. :warning: **Testing flaw** Testing around the virtual anchor used to trigger downloads proved tricky, `FIXME` comments were left to tag the two cases that are lackluster. Because the action of fetching from the API is covered and QA covered the interaction, this is considered "accepted risk".
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
automerge

   
backend

   
bug

Something isn't working

  
ci/tooling

   
dependencies

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature

New features or capabilities

  
frontend

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
research

   
test-dependencies

   
wontfix

This will not be worked on

No labels
automerge
backend
bug
ci/tooling
dependencies
documentation
duplicate
enhancement
feature
frontend
good first issue
help wanted
invalid
question
research
test-dependencies
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: marc/rotini#23
No description provided.
Delete branch "feat/download-files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?