marc/rss-reader
1
0
Fork 0
Code Issues 5 Pull requests 10 Projects Releases Packages Wiki Activity

refactor: move lots of logic to hooks, declutter #22

Merged
mcataford merged 8 commits from refactor/hooks-declutter into main 2022-03-13 14:19:00 +00:00
Conversation 7 Commits 8 Files changed 17 +378 -292
mcataford commented 2022-03-12 16:58:37 +00:00 (Migrated from github.com)
Copy link
  • Moved a lot of stray logic into hooks;
  • Introduced react-query to handle fetching feeds -- should take care of caching / redundant request avoidance for us;
  • Pushed data into containers instead of feeding from top-level for cleaner interfaces
  • Deprecates the useAppState hook in favour of granular hooks for navigation and feed fetching
  • Enables standard HTML mode (i.e. !DOCTYPE)
- Moved a lot of stray logic into hooks; - Introduced `react-query` to handle fetching feeds -- should take care of caching / redundant request avoidance for us; - Pushed data into containers instead of feeding from top-level for cleaner interfaces - Deprecates the `useAppState` hook in favour of granular hooks for navigation and feed fetching - Enables standard HTML mode (i.e. `!DOCTYPE`)
github-actions[bot] commented 2022-03-12 17:03:59 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622cd2739707605278642d67--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622cd2739707605278642d67--sleepy-shaw-d8efec.netlify.app
github-actions[bot] commented 2022-03-12 18:01:47 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622ce005970760661e642edb--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622ce005970760661e642edb--sleepy-shaw-d8efec.netlify.app
github-actions[bot] commented 2022-03-12 18:05:05 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622ce0caa3e476503f7380f1--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622ce0caa3e476503f7380f1--sleepy-shaw-d8efec.netlify.app
github-actions[bot] commented 2022-03-12 18:22:15 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622ce4d13bf38e7e7bdabd14--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622ce4d13bf38e7e7bdabd14--sleepy-shaw-d8efec.netlify.app
github-actions[bot] commented 2022-03-12 18:44:44 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622cea150deada13e725a898--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622cea150deada13e725a898--sleepy-shaw-d8efec.netlify.app
github-actions[bot] commented 2022-03-12 18:52:28 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622cebe697076075856430d8--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622cebe697076075856430d8--sleepy-shaw-d8efec.netlify.app
github-actions[bot] commented 2022-03-13 14:16:56 +00:00 (Migrated from github.com)
Copy link

👀 Branch deployed at Website Draft URL: https://622dfcd2e6bcc3342dae7a3f--sleepy-shaw-d8efec.netlify.app

:eyes: Branch deployed at Website Draft URL: https://622dfcd2e6bcc3342dae7a3f--sleepy-shaw-d8efec.netlify.app
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
automerge

   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
maintenance

   
question

Further information is requested

  
wontfix

This will not be worked on

No labels
automerge
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
maintenance
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: marc/rss-reader#22
No description provided.
Delete branch "refactor/hooks-declutter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?