marc/v
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor(python): remove unnecessary client instantiation

Browse source
This commit is contained in:
Marc 2024-01-28 23:30:06 -05:00
parent 4114a112bb
commit 766fd089a6
Signed by: marc
GPG key ID: 048E042F22B5DC79
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
python/install.go
View file

@ -32,6 +32,13 @@ func (t VersionTag) MajorMinor() string {
return t.Major + "." + t.Minor
}
// Installing new distribution happens in three stages:
// 1. Validating that the version number is of a valid format;
// 2. Downloading the source tarball;
// 3. Unzipping + building from source.
//
// The tarball is cached in the `cache` state directory and is reused
// if the same version is installed again later.
func InstallPythonDistribution(version string, noCache bool) error {
if err := ValidateVersion(version); err != nil {
return err
@ -56,8 +63,6 @@ func downloadSource(version string, skipCache bool) (PackageMetadata, error) {
archivePath := state.GetStatePath("cache", archiveName)
sourceUrl, _ := url.JoinPath(pythonReleasesBaseURL, version, archiveName)
client := http.Client{}
logger.InfoLogger.Println(logger.Bold("Downloading source for Python " + version))
logger.InfoLogger.SetPrefix(" ")
defer logger.InfoLogger.SetPrefix("")
@ -67,7 +72,7 @@ func downloadSource(version string, skipCache bool) (PackageMetadata, error) {
if _, err := os.Stat(archivePath); errors.Is(err, os.ErrNotExist) || skipCache {
logger.InfoLogger.Println("Fetching from " + sourceUrl)
resp, err := client.Get(sourceUrl)
resp, err := http.Get(sourceUrl)
if err != nil {
return PackageMetadata{}, err