marc/packwatch
Archived
1
0
Fork 0
Code Issues 5 Pull requests 10 Projects Releases 2 Packages Wiki Activity

refactor: more cleanup #164

Merged
mcataford merged 11 commits from more-refactor into master 2021-03-19 20:49:27 +00:00
Conversation 1 Commits 11 Files changed 9 +94 -51
mcataford commented 2021-02-19 07:17:24 +00:00 (Migrated from github.com)
Copy link
  • Extracts invariants
  • Better error usage to derive final return code
  • Fixes types
- Extracts invariants - Better error usage to derive final return code - Fixes types
mcataford (Migrated from github.com) reviewed 2021-02-19 14:50:01 +00:00
src/__tests__/index.test.ts
@ -10,3 +10,4 @@
const workspacePath = await fs.mkdtemp(`${tmpdir()}/`)
return workspacePath
}
mcataford (Migrated from github.com) commented 2021-02-19 14:50:01 +00:00

The recursive option here was unused.

The `recursive` option here was unused.
codecov-io commented 2021-02-19 15:04:39 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #164 (a5081e3) into master (7267397) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           63        67    +4     
  Branches        13        12    -1     
=========================================
+ Hits            63        67    +4
Impacted Files Coverage Δ
src/utils.ts 100.00% <ø> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/invariants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7267397...a5081e3. Read the comment docs.

# [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=h1) Report > Merging [#164](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=desc) (a5081e3) into [master](https://codecov.io/gh/mcataford/packwatch/commit/72673970c08d51c1b8b91e0e02a6193ffbfa4480?el=desc) (7267397) will **not change** coverage. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/mcataford/packwatch/pull/164/graphs/tree.svg?width=650&height=150&src=pr&token=IVEisJMCje)](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #164 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 3 +1 Lines 63 67 +4 Branches 13 12 -1 ========================================= + Hits 63 67 +4 ``` | [Impacted Files](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/utils.ts](https://codecov.io/gh/mcataford/packwatch/pull/164/diff?src=pr&el=tree#diff-c3JjL3V0aWxzLnRz) | `100.00% <ø> (ø)` | | | [src/index.ts](https://codecov.io/gh/mcataford/packwatch/pull/164/diff?src=pr&el=tree#diff-c3JjL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | | [src/invariants.ts](https://codecov.io/gh/mcataford/packwatch/pull/164/diff?src=pr&el=tree#diff-c3JjL2ludmFyaWFudHMudHM=) | `100.00% <100.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=footer). Last update [7267397...a5081e3](https://codecov.io/gh/mcataford/packwatch/pull/164?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
Idea

   
invalid

This doesn't seem right

  
question

Further information is requested

  
released

   
security

Pull requests that address a security vulnerability

  
semantic-release

   
wontfix

This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
Idea
invalid
question
released
security
semantic-release
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: marc/packwatch#164
No description provided.
Delete branch "more-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?