build: transition to Typescript without Babel #252

Merged

mcataford merged 6 commits from ts-via-tsc-without-babel into master

2021-06-05 15:29:16 +00:00

mcataford commented

2021-06-04 03:09:03 +00:00

(Migrated from github.com)

While Babel offers a lot of cool features, very little of it is in use here. All we need to get along really is just typescript.

This PR...

Removes Babel entirely and makes the build/test only rely on tsc;
Fixes outstanding type errors;
Moves to yarn from sources to allow the latest Typescript to work (previously pinned to avoid patch errors)

While Babel offers a lot of cool features, very little of it is in use here. All we need to get along really is just `typescript`. This PR... > Removes Babel entirely and makes the build/test only rely on `tsc`; > Fixes outstanding type errors; > Moves to `yarn from sources` to allow the latest Typescript to work (previously pinned to avoid patch errors)

codecov-commenter commented

2021-06-04 03:10:30 +00:00

(Migrated from github.com)

Codecov Report

Merging #252 (9fce4b3) into master (5482139) will decrease coverage by 1.03%.
The diff coverage is 93.33%.

@@             Coverage Diff             @@
##            master     #252      +/-   ##
===========================================
- Coverage   100.00%   98.96%   -1.04%     
===========================================
  Files            4        4              
  Lines           73       97      +24     
  Branches        12       19       +7     
===========================================
+ Hits            73       96      +23     
- Misses           0        1       +1

Impacted Files	Coverage Δ
src/utils.ts	`97.77% <90.90%> (-2.23%)`	⬇️
src/index.ts	`100.00% <100.00%> (ø)`
src/logger.ts	`100.00% <0.00%> (ø)`
src/invariants.ts	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5482139...9fce4b3. Read the comment docs.

# [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford) Report > Merging [#252](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford) (9fce4b3) into [master](https://codecov.io/gh/mcataford/packwatch/commit/548213968ac58bd245291e981379112303d5cb8d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford) (5482139) will **decrease** coverage by `1.03%`. > The diff coverage is `93.33%`. [![Impacted file tree graph](https://codecov.io/gh/mcataford/packwatch/pull/252/graphs/tree.svg?width=650&height=150&src=pr&token=IVEisJMCje&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford)](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford) ```diff @@ Coverage Diff @@ ## master #252 +/- ## =========================================== - Coverage 100.00% 98.96% -1.04% =========================================== Files 4 4 Lines 73 97 +24 Branches 12 19 +7 =========================================== + Hits 73 96 +23 - Misses 0 1 +1 ``` | [Impacted Files](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford) | Coverage Δ | | |---|---|---| | [src/utils.ts](https://codecov.io/gh/mcataford/packwatch/pull/252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford#diff-c3JjL3V0aWxzLnRz) | `97.77% <90.90%> (-2.23%)` | :arrow_down: | | [src/index.ts](https://codecov.io/gh/mcataford/packwatch/pull/252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford#diff-c3JjL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | | | [src/logger.ts](https://codecov.io/gh/mcataford/packwatch/pull/252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford#diff-c3JjL2xvZ2dlci50cw==) | `100.00% <0.00%> (ø)` | | | [src/invariants.ts](https://codecov.io/gh/mcataford/packwatch/pull/252/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford#diff-c3JjL2ludmFyaWFudHMudHM=) | `100.00% <0.00%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford). Last update [5482139...9fce4b3](https://codecov.io/gh/mcataford/packwatch/pull/252?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marc+Cataford).

mcataford commented

2021-06-04 03:47:50 +00:00

(Migrated from github.com)

TODO:

Add coverage and strategy for malformed manifest

EDIT:
Deferring the above to its own task so this can move along. The coverage gap is mainly introduced by extra nullcheck-adjacent logic added to squash typecheck problems.

TODO: - [ ] Add coverage and strategy for malformed manifest EDIT: Deferring the above to its own task so this can move along. The coverage gap is mainly introduced by extra nullcheck-adjacent logic added to squash typecheck problems.

This repo is archived. You cannot comment on pull requests.

No reviewers