chore: Add babel-preset-env #7

Merged

msrose merged 2 commits from add-babel-preset-env into master

2020-03-06 21:25:45 +00:00

msrose commented

2020-03-05 04:10:18 +00:00

(Migrated from github.com)

Playing around with the CLI, I don't think babel actually does anything unless you specify presets or plugins, which is weird and confusing 🤔

∫ michael ~/Documents/test-stuff/test-babel ∫
Σ yarn babel test.js
yarn run v1.22.0
warning package.json: No license field
$ /Users/michael/Documents/test-stuff/test-babel/node_modules/.bin/babel test.js
const hey = [...[1, 2, 3]];
console.log(hey);

✨  Done in 0.61s.

∫ michael ~/Documents/test-stuff/test-babel ∫
Σ yarn babel test.js --presets @babel/preset-env
yarn run v1.22.0
warning package.json: No license field
$ /Users/michael/Documents/test-stuff/test-babel/node_modules/.bin/babel test.js --presets @babel/preset-env
"use strict";

var hey = [1, 2, 3].concat();
console.log(hey);

✨  Done in 0.53s.

This targets node 10 (the lowest maintained LTS version of node) so if any new syntax does get used packwatch will still work with at least node 10.

Playing around with the CLI, I don't think babel actually does anything unless you specify presets or plugins, which is weird and confusing 🤔 ``` ∫ michael ~/Documents/test-stuff/test-babel ∫ Σ yarn babel test.js yarn run v1.22.0 warning package.json: No license field $ /Users/michael/Documents/test-stuff/test-babel/node_modules/.bin/babel test.js const hey = [...[1, 2, 3]]; console.log(hey); ✨ Done in 0.61s. ``` ``` ∫ michael ~/Documents/test-stuff/test-babel ∫ Σ yarn babel test.js --presets @babel/preset-env yarn run v1.22.0 warning package.json: No license field $ /Users/michael/Documents/test-stuff/test-babel/node_modules/.bin/babel test.js --presets @babel/preset-env "use strict"; var hey = [1, 2, 3].concat(); console.log(hey); ✨ Done in 0.53s. ``` This targets node 10 (the lowest maintained LTS version of node) so if any new syntax does get used packwatch will still work with at least node 10.

codecov-io commented

2020-03-06 21:20:12 +00:00

(Migrated from github.com)

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          34     34           
  Branches        5      5           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432ce16...d8a7cbf. Read the comment docs.

# [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/7?src=pr&el=h1) Report > Merging [#7](https://codecov.io/gh/mcataford/packwatch/pull/7?src=pr&el=desc) into [master](https://codecov.io/gh/mcataford/packwatch/commit/432ce163b07486db50c08a570073cda2a721b8ee?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/mcataford/packwatch/pull/7/graphs/tree.svg?width=650&token=IVEisJMCje&height=150&src=pr)](https://codecov.io/gh/mcataford/packwatch/pull/7?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #7 +/- ## ===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 34 34 Branches 5 5 ===================================== Hits 34 34 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/mcataford/packwatch/pull/7?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/7?src=pr&el=footer). Last update [432ce16...d8a7cbf](https://codecov.io/gh/mcataford/packwatch/pull/7?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

mcataford (Migrated from github.com) approved these changes 2020-03-06 21:25:40 +00:00

mcataford (Migrated from github.com) left a comment

LGTM

mcataford commented

2020-03-08 17:15:23 +00:00

(Migrated from github.com)

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

:tada: This PR is included in version 2.0.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/packwatch/v/2.0.0) - [GitHub release](https://github.com/mcataford/packwatch/releases/tag/v2.0.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

This repo is archived. You cannot comment on pull requests.

No reviewers

mcataford