marc/packwatch
Archived
1
0
Fork 0
Code Issues 5 Pull requests 10 Projects Releases 2 Packages Wiki Activity

feat: Only generate manifest if update is specified #8

Merged
msrose merged 4 commits from only-generate-manifest-with-option into master 2020-03-08 17:12:50 +00:00
Conversation 5 Commits 4 Files changed 1 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/index.js
View file

@ -33,7 +33,9 @@ if (!existsSync(MANIFEST_FILENAME)) {
console.log(
`Package size (${currentStats.packageSize}) adopted as new limit.`,
)
process.exit(0)
// If the update flag wasn't specified, exit with a non-zero code so we
// don't "accidentally" pass CI builds if the manifest didn't exist
process.exit(isUpdatingManifest ? 0 : 1)
}
mcataford commented 2020-03-08 17:12:19 +00:00 (Migrated from github.com)
Review
Copy link

An argument could be made that there's never a valid use case in which you'd want CI to run --update-manifest and pass either (since having --update-manifest in CI would always pass the check). That being said, I feel that this can be addressed further up and check if a CI env variable is set to error out early if --update-manifest is passed in.

LGTM.

An argument could be made that there's never a valid use case in which you'd want CI to run `--update-manifest` and pass either (since having `--update-manifest` in CI would always pass the check). That being said, I feel that this can be addressed further up and check if a CI env variable is set to error out early if `--update-manifest` is passed in. LGTM.
const previousStats = getPreviousPackageStats()