chore: Run build on pull requests #9

Merged

msrose merged 2 commits from run-build-on-pr into master

2020-03-06 21:08:38 +00:00

msrose commented

2020-03-05 05:04:50 +00:00

(Migrated from github.com)

Seems like the push event only applies to repository branches https://help.github.com/en/actions/reference/events-that-trigger-workflows#push-event-push, I suspect that the pull_request event is needed to run the build on branches of forks.

UPDATE: confirmed by the fact that it's building this PR 😅

msrose commented

2020-03-05 05:09:05 +00:00

(Migrated from github.com)

Of note: seems like it ends up running the checks twice for repository branches 🤔 https://github.com/msrose/node-package/pull/17

codecov-io commented

2020-03-06 20:57:26 +00:00

(Migrated from github.com)

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #9   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          34     34           
  Branches        5      5           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f11a0...d30fbda. Read the comment docs.

# [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/9?src=pr&el=h1) Report > Merging [#9](https://codecov.io/gh/mcataford/packwatch/pull/9?src=pr&el=desc) into [master](https://codecov.io/gh/mcataford/packwatch/commit/42f11a0e72cf4caf94a908e2ea6391e391ecbd87?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/mcataford/packwatch/pull/9/graphs/tree.svg?width=650&token=IVEisJMCje&height=150&src=pr)](https://codecov.io/gh/mcataford/packwatch/pull/9?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #9 +/- ## ===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 34 34 Branches 5 5 ===================================== Hits 34 34 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/mcataford/packwatch/pull/9?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/mcataford/packwatch/pull/9?src=pr&el=footer). Last update [42f11a0...d30fbda](https://codecov.io/gh/mcataford/packwatch/pull/9?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

mcataford (Migrated from github.com) approved these changes 2020-03-06 21:08:29 +00:00

mcataford (Migrated from github.com) left a comment

LGTM

mcataford commented

2020-03-06 21:14:34 +00:00

(Migrated from github.com)

@all-contributors please add @msrose for infra

allcontributors[bot] commented

2020-03-06 21:14:41 +00:00

(Migrated from github.com)

@mcataford

I've put up a pull request to add @msrose! 🎉

@mcataford I've put up [a pull request](https://github.com/mcataford/packwatch/pull/11) to add @msrose! :tada:

mcataford commented

2020-03-08 17:15:44 +00:00

(Migrated from github.com)

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

:tada: This PR is included in version 2.0.0 :tada: The release is available on: - [npm package (@latest dist-tag)](https://www.npmjs.com/package/packwatch/v/2.0.0) - [GitHub release](https://github.com/mcataford/packwatch/releases/tag/v2.0.0) Your **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:

This repo is archived. You cannot comment on pull requests.

No reviewers

mcataford